Create, close, cancel, Purchase Orders (UXPROD-1141)

[UISACQCOMP-37] Date range filters in Orders and Circulation log does not honor tenant locale Created: 29/Jun/21  Updated: 14/Oct/21  Resolved: 08/Jul/21

Status: Closed
Project: stripes-acq-components
Components: None
Affects versions: None
Fix versions: 2.4.1
Parent: Create, close, cancel, Purchase Orders

Type: Bug Priority: P3
Reporter: Lisa Sjögren Assignee: Dennis Bridges
Resolution: Done Votes: 0
Labels: support, ui-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: File Proof.mp4     PNG File image-2021-06-29-16-39-03-828.png     PNG File image-2021-06-29-16-41-11-510.png     PNG File image-2021-06-29-16-43-31-815.png     PNG File image-2021-06-29-16-46-38-219.png     PNG File image-2021-06-29-16-47-01-113.png    
Issue links:
Blocks
blocks UISACQCOMP-38 UISACQCOMP (stripes-acq-components) B... Closed
Cloners
is cloned by UICIRCLOG-76 Date range filters in Circulation log... Closed
Defines
defines STCOM-854 Expose getLocalFormat Datepicker util Closed
defines UXPROD-2630 Thunderjet - R2 Enhancements/Bugfixes Closed
Sprint: ACQ Sprint 118
Story Points: 2
Development Team: Thunderjet
Release: R2 2021 Bugfix
Affected Institution:
Chalmers
Epic Link: Create, close, cancel, Purchase Orders

 Description   

Overview: Date range filters in Orders and Circulation log does not honour tenant locale. This appears to be a regression in Iris.

Steps to Reproduce:

  1. Log into some https://folio-iris.dev.folio.org/
  2. Go to Settings > Tenant > Language and localization, and select English (Sweden). Save this configuration
  3. Go to the Orders app and (in either Orders or PO line segment) and expand one of the date range accordions.

Expected Results:
The placeholder text in the date field is, and the accepted date input format, is YYYY-MM-DD. See below of what it looks like in Orders in Honeysuckle:

Actual Results:
The placeholder text in the date field is MM-DD-YYYY. Trying to filter by a date in the format YYYY-MM-DD produces an error message.


This behaviour has so far been observed in the date range filters in the Orders app and the Circulation log app, in tenants with their locale set to English (Sweden) and Italian. It appears to be a regression in Iris.

Other apps, like Inventory have correct date formats in the filter. Actual date data seems to be correctly formatted.

Interested parties: Marie Widigson



 Comments   
Comment by Marie Widigson [ 30/Jun/21 ]

Just noted that in Iris there is a new tenant locale Swedish/Svenska. If choosing this I get the expected date format YYYY-MM-DD.

At the moment, choosing "Swedish/Svenska" still presents FOLIO in English anyway so we could use that for the moment, but as we want to have FOLIO in English but with Swedish date format, and therefore would prefer to have English (Sweden) working as before.

Another long term thought is to separate choice of language and choice of date format.

Comment by Mikita Siadykh [ 07/Jul/21 ]

Tetiana Paranich changes are available on testing env, plz review

Comment by Tetiana Paranich [ 08/Jul/21 ]

Work as expected on https://folio-testing.dev.folio.org

Google Chrome Version 91.0.4472.124 (Official Build) (64-bit)

See the attached Proof.mp4

Comment by Dennis Bridges [ 26/Jul/21 ]

test successful in bugfest-juniper

Comment by Marie Widigson [ 14/Oct/21 ]

Hi! I can confirm that it's fixed in Orders but the bug remains in Circulation log. As far as I can see it's still the same in Snapshot Stephanie Buck

Comment by Stephanie Buck [ 14/Oct/21 ]

Mikita Siadykh and Dennis Bridges - if this error is still showing in circ log, should a separate bug be filed? 

Comment by Dennis Bridges [ 14/Oct/21 ]

Stephanie Buck yes, I think that would make sense as it will likely require a new release version.

Comment by Stephanie Buck [ 14/Oct/21 ]

Thanks, Dennis Bridges. I'll try to reproduce the circ log error. If I can, I'll duplicate this ticket and narrow in on circ log in the description. Would it still be Thunderjet or would I assign to the circ log devs on Firebird?

Comment by Mikita Siadykh [ 14/Oct/21 ]

Stephanie Buck yep, and it's better to place in UICIRCLOG project firstly, it's more likely issue in module with config or version as component works fine in orders 

 

https://github.com/folio-org/ui-circulation-log/blob/master/src/CirculationLogList/CirculationLogListFilter/CirculationLogListFilter.js#L92

you can add this link to new bug, it references line of wrong config in ui-curculation-log 

 

Comment by Stephanie Buck [ 14/Oct/21 ]

Will do. Thanks Mikita Siadykh!

Comment by Stephanie Buck [ 14/Oct/21 ]

Please see UICIRCLOG-76 for the circ log ticket, Marie Widigson.

Generated at Thu Feb 08 22:21:45 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.