[UIPFU-59] User lookup modal fails unexpectedly when punctuation is present in the patron group name Created: 10/Jun/22  Updated: 06/Oct/22  Resolved: 06/Oct/22

Status: Closed
Project: ui-plugin-find-user
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P3
Reporter: Erin Nettifee Assignee: Michal Kuklis
Resolution: Done Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File Skärmavbild 2022-10-06 kl. 4.30.11 em.png     PNG File Skärmavbild 2022-10-06 kl. 4.33.49 em.png     PNG File Skärmavbild 2022-10-06 kl. 4.34.19 em.png     PNG File Skærmbillede 2022-09-26 kl. 15.08.30.png     PNG File Skærmbillede 2022-09-26 kl. 15.09.20.png     PNG File Skærmbillede 2022-09-26 kl. 15.09.42.png    
Issue links:
Defines
defines UXPROD-3691 R3 2022 | Prokopovych Enhancements/Bu... Closed
Sprint: Prokopovych - Sprint 149, Prokopovych - Sprint 150
Development Team: Prokopovych
Release: Nolana (R3 2022)
Affected Institution:
Duke
RCA Group: Incomplete/missing requirements

 Description   

The user lookup modal behaves differently than the Users app filter if the name of the patron group has a character in it like a period or an ampersand.

For example, at Duke we have a patron group currently named 'Fuqua-Ph.D' that contains Ph.D students at the business school.

The filter works as expected in the Users app - you can choose it from the patron group filter on the left and results are returned as expected.

The filter does NOT work as expected in the User lookup modal that appears in the Check out app. When you click 'Fuqua-Ph.D' it says no users are found.

The root issue seems to be that the query in the Users app queries by the group UUID, e.g.

%28patronGroup%3D%3D%228aa3900c-54a8-4fa9-9800-207c34a65a7a%22%29%20sortby%20personal.lastName%20personal.firstName

Whereas the query in the User lookup modal queries by the name of the group, which means that the character in the group name is transformed into the ASCII character code and the search fails.

%28patronGroup%3D%3D%22Fuqua-Ph%22%29%20sortby%20personal.lastName%20personal.firstName

So either the modal needs to fetch by the UUID (desired - since that would match the behavior in the Users app filter), or if that's not possible, we need to disallow non-alpha characters in patron group names.



 Comments   
Comment by Erin Nettifee [ 10/Jun/22 ]

patty.wanninger FYI on this. I'm not sure how to prioritize - I suspect it's a P3, but from Duke's perspective at least, we would need to know when this could be fixed so that we can adjust patron group labels if it won't be fixed before we go live.

It's obviously simple to change the label in the UI, but we have to also adjust our integration script, which is a little bit more time-consuming. So I just want to get info on the FOLIO side before I go through adjusting the integration.

Comment by Charlotte Whitt [ 20/Jun/22 ]

Support SIG: patty.wanninger please see Erin's comment above re. priority. Right now the ticket is a P3 for Nolana R3 2022.

Comment by Charlotte Whitt [ 06/Sep/22 ]

Support SIG: The work is now assigned to sprint 149

Comment by Charlotte Whitt [ 19/Sep/22 ]

Support SIG: Sharon Wiles-Young will check if this is an issue also at Lehigh.

Comment by Sharon Wiles-Young [ 20/Sep/22 ]

9/20 Mark tested in Lehigh's test database (Lotus HF3) and patron group with punctuation worked from patron look up in check out app

Comment by Charlotte Whitt [ 26/Sep/22 ]

I tested this in FOLIO Snapshot, and here it does not work:

I can create the Patron group: Fuqua-Ph.D
I can create a user with the given patron group: Fuqua-Ph.D
But when using the look up modal when doing a Check out, then the UI behaves like the check box can not be checked.

Comment by Charlotte Whitt [ 04/Oct/22 ]

I tried to test now, but still see the problem. I'll try again tomorrow when the new build of Snapshot has happened.

Comment by Charlotte Whitt [ 06/Oct/22 ]

Manual test in FOLIO Snapshot, version @folio/inventory 9.2.1000002160, using Chrome.

All works excellent. Thanks Michal Kuklis. I'll close the ticket as done.

Generated at Fri Feb 09 00:34:10 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.