[UIIN-746] Inventory - Permissions. View Instance records which are marked as Staff suppress Created: 27/Sep/19  Updated: 18/Feb/21  Resolved: 18/Feb/21

Status: Closed
Project: ui-inventory
Components: None
Affects versions: None
Fix versions: None

Type: Story Priority: P4
Reporter: Charlotte Whitt Assignee: Unassigned
Resolution: Done Votes: 0
Labels: permissions
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
is blocked by MODINV-167 Handle "Inventory: View instance reco... Closed
Defines
defines UXPROD-2166 Inventory Permissions. View Instance ... Closed
Relates
relates to UIIN-289 Filter Instance records by Suppress i... Closed
relates to UIIN-967 Filter Instance records by Suppress i... Closed
relates to UIIN-968 Filter Instance records by Staff supp... Closed
Sprint:
Story Points: 2
Development Team: Prokopovych
Tester Assignee: Charlotte Whitt

 Description   

Purpose: In the instance record, it's possible to mark the instance record, that it should not be displayed for staff - that means typical only viewable for catalogers, who are working on a draft record, etc. To support who can view these records, we need a permission that allows users (typical catalogers) to view instance records being check marked as 'Staff suppress'.

Usecase: Permission in Users to enable/disable the view of staff-suppressed instance records

Scenarios:

  1. Scenario
    • Login to FOLIO Snapshot
    • Given the Inventory module
    • When enabled
    • Then a logical permission should be provided called "Inventory: View instance records being suppressed for staff"
  2. Scenario
    • Given User A has been given the permission "Inventory: View instance records being suppressed for staff"
    • When User A accesses FOLIO
    • Then:
      • The Inventory app should be visible in the top navigation bar
      • The Inventory app should be fully accessible to User A, meaning User A can:
        • Search and filter instance, holdings and item records
        • View Instance records in detailed screen
        • View Instance records, which are being marked as suppressed for staff
        • View filter for Staff suppress in 1st pane - see UIIN-289 Closed
  3. Scenario
    • Given User A has been given the permission "View instance records being suppressed for staff" as part of a custom permission set
    • When User A accesses FOLIO
    • Then User A should have all rights normally conferred by this permission (see scenario 2) plus whatever additional rights conferred by the users custom permission set.


 Comments   
Comment by Zak Burke [ 17/Oct/19 ]

It's important to note that they way this feature is implemented in the backend, there is no difference in the actual, server-enforced permissions between the psets "Inventory: View instances, holdings, and items" and "Inventory: View instance records being suppressed for staff". When a user views records without the latter pset, we will have to change those queries to filter out the suppressed records.

Comment by Marc Johnson [ 17/Oct/19 ]

Zak Burke As is being discussed on MODINV-167 Closed , I think there will need to be a difference on the server side. Or are you proposing client side filtering of the records?

Comment by Zak Burke [ 17/Oct/19 ]

I was unaware of MODINV-167 Closed .

My comment was in the context of PR #735 which implements this permission as an exact copy of ui-inventory.instance.view. IOW, because there is no back-end support for this kind of permission (an instance record is an instance record is an instance record; it doesn't matter whether its staff_suppress value is "true" or "false" any more than if its title field is "Hamlet" or "Bill and Ted's Excellent Adventure"; they're all just instance records from the point of view of permissions), the only possible implementation I considered was constructing different queries based on the presence or absence of this permission.

If we're going to handle this on the backend, that's great ... but the same issue applies, it just moves the responsibility for all the work to construct such queries to the backend.

Comment by Khalilah Gambrell [ 17/Oct/19 ]

Moving this issue to the backlog. cc: Tetyana Afanasyeva and Oleksandr Antonenko

Comment by Charlotte Whitt [ 18/Oct/19 ]

Following up on Cate Boerema's comment in MODINV-167 Closed , I have reassigned this story to the Core Functional team.

CC: Khalilah Gambrell

Generated at Fri Feb 09 00:20:51 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.