[UIIN-1289] Closing the "View MARC" record takes you to a different app instead of the Instance details, sometimes Created: 06/Oct/20  Updated: 07/Oct/20  Resolved: 07/Oct/20

Status: Closed
Project: ui-inventory
Components: None
Affects versions: None
Fix versions: 5.0.0

Type: Bug Priority: P2
Reporter: Ann-Marie Breaux (Inactive) Assignee: Stephanie Buck
Resolution: Done Votes: 0
Labels: regression, ui-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: File KerstinEkman.mrc     File Misdirect from View MARC screen.mp4     File Moving from Checkout to Users.mp4    
Sprint: Firebird Sprint 99
Story Points: 1
Development Team: Firebird
Release: Q3 2020

 Description   

Overview: If you view a MARC record in Inventory, and do not close it before going to a different app, when you come back to Inventory and close the MARC record, instead of being shown the Inventory search results/Instance details, you are taken to the other app.

Current workaround: open a new session and be sure to close the View MARC before going to another FOLIO app

Steps to Reproduce:

  1. Log into folio-snapshot-load as diku_admin
  2. Go to Inventory and check to see if there are any records with source = MARC (Query search: source==MARC, or use the new Source filter).
  3. If no source=MARC records in Inventory, then import a small MARC file, using the secret button (so that Instances are created)
  4. Search for the Instance, view its details, and then click Actions/View MARC, to see the underlying MARC record
  5. Click the X at the top left of the MARC record to close it
  6. That should return you to the Inventory search results and the Instance detail view
  7. Click Actions/View MARC again, to see the MARC record
  8. Now navigate to any other FOLIO app - Settings, Check-out, etc.
  9. Go back to the Inventory app, where you will see the MARC record
  10. Click the X at the top left of the MARC record to close it
  11. What screen do you see next?

Expected Results: Whenever the user closes a View MARC screen, they should be returned to the current Inventory search results, with the selected Instance's details showing

Actual Results: If a user navigates to a different app without closing the View MARC screen first, then when they go back to Inventory and close the MARC record, they are redirected to the other app. And then there's no way to get back to the FOLIO instance.

Additional Information: See attached video
More steps added by Charlotte Whitt:
12. Go back to the Inventory app, where you will see the MARC record in SRS
13. Select Inventory in the top menu with apps
14. What screen do you see next: Inventory



 Comments   
Comment by Charlotte Whitt [ 06/Oct/20 ]

Ann-Marie Breaux I can reproduce the bug in FOLIO snapshot, as user diku_admin - but apparently this error is triggered by the X at the top left of the MARC record:

  1. Log into FOLIO Snapshot as diku_admin
  2. Load a MARC record by using Data Import (Secret button) - KerstinEkman.mrc
  3. Go to Inventory and Search for the record by using the Source filter: MARC
  4. Display the instance, view its details https://folio-snapshot.dev.folio.org/inventory/view/f8a30fb3-9568-4d96-92a3-f658375e447e?filters=source.MARC&sort=title (this link works today: 10/6/2020)
  5. Click Actions/View MARC, to see the underlying MARC record
  6. Click the X at the top left of the MARC record to close it
  7. That should return you to the Inventory search results and the Instance detail view
  8. Click Actions/View MARC again, to see the MARC record
  9. Now navigate to any other FOLIO app - Data Import, Settings, Check-out, etc.
  10. Go back to the Inventory app, where you will see the MARC record in SRS
  11. Click the X at the top left of the MARC record to close it
  12. What screen do you see next: Data Import/Settings/Check-out
  13. Go back to the Inventory app, where you will see the MARC record in SRS
  14. Select Inventory in the top menu with apps
  15. What screen do you see next: Inventory
Comment by Ann-Marie Breaux (Inactive) [ 06/Oct/20 ]

Hi Stephanie Buck We're trying to figrue out who should fix this UIIN bug. Charlotte Whitt was able to reproduce it, and Kateryna Senchenko from Folijet did a little analysis of it. "Here is what I managed to find out - 1) Yes, this is a UIIN bug 2) "View source" component and "Go back" (by clicking on the X icon) functionality were implemented by Mikita Siadykh so I believe it might be the responsibility of Firebird team"

Could you review and decide if Firebird is willing to fix it? It would be best if it's fixed before UIIN is released. Thank you!

Comment by Zak Burke [ 06/Oct/20 ]

The code behind this is in UIIN and has to do with the URL passed to the close-handler for the view-source Pane.

This is the same issue we faced in ui-requests or ui-checkout (sorry, can't remember, do you, Cate Boerema? did we work with Holly Mistlebauer on this?) when a request or check-out would be denied because of a block. The UI would show a modal with “Denied because patron has <link>block</link>“. In that case, we had the opposite problem: folks didn’t realize they were navigating away from ui-requests when they clicked the link and they wanted to return to the requests app when they clicked the block's close-x but were seeing the ui-users landing page.

In Ann-Marie Breaux's video, she first navigates from instance-details to SRS, then closes that pane, returning her to the previous URL (which happens to be instance-details). She then opens SRS, navigates away to settings, navigates back to SRS, then closes that pane, returning her to the previous URL (which happens to be data-import settings).

The issue is essentially “What URL should FOLIO return to when clicking the close-x of a full-screen modal?” (A) the previous URL of the app that owns the modal (as desired here) or (B) the previous URL in FOLIO overall (as desired in that other situation described above).

Comment by Cate Boerema (Inactive) [ 06/Oct/20 ]

Hi Zak Burke, we have seen this problem before and the solution has been to have the close-x return to (A) the previous URL of the app that owns the modal. IIRC, doing B resulted in a weird loop that made it impossible to get back to the base of the owning app (and A is more logical for users, as well).

We are doing A when you move from Checkout to users. I'll upload a screencast in case anyone is interested.

Comment by Stephanie Buck [ 06/Oct/20 ]

Ann-Marie Breaux, we'll take a look but we're not certain it was quickMARC work.

Comment by Mikita Siadykh [ 06/Oct/20 ]

Cate Boerema Stephanie Buck
now it just goes back to the previous browser url

Stephanie I think this one can be assigned to Firebird as there are some code re-usage on split screen

Comment by Stephanie Buck [ 06/Oct/20 ]

Thanks Mikita Siadykh. I'll assign it over. Ann-Marie Breaux or Cate Boerema, is there a target release for this? Hotfix 3 or Honeysuckle?

Comment by Charlotte Whitt [ 06/Oct/20 ]

Stephanie Buck This bug has P2 priority, while we do have a work around:

  1. Select Inventory in the top menu with apps
  2. What screen do you see next: Inventory

So this late in the process of Goldenrod, we can accept to have it solved with Honeysuckle.

Comment by Mikita Siadykh [ 06/Oct/20 ]

Charlotte Whitt
I think it works as expected on Goldenrod - not fully sure, but based on the versions seems like yes

cc Stephanie Buck

Comment by Ann-Marie Breaux (Inactive) [ 06/Oct/20 ]

Thank you for fixing this Mikita Siadykh. It was definitely a regression. Worked fine in Goldenrod.

Comment by Ann-Marie Breaux (Inactive) [ 06/Oct/20 ]

Stephanie Buck This should go in the UIIN Q3 2020/Honeysuckle release. No need for a hotfix to Goldenrod

Comment by Mikita Siadykh [ 07/Oct/20 ]

Stephanie Buck tested on snapshot env, please review

Comment by Ann-Marie Breaux (Inactive) [ 07/Oct/20 ]

Hi Mikita Siadykh I went ahead and tested since I saw your comments - looks great on snapshot-load. Does exactly what it used to do, and what it is supposed to do. Thank you very much for the quick fix!

Comment by Stephanie Buck [ 07/Oct/20 ]

Charlotte Whitt and Ann-Marie Breaux, love that new Source filter! This works well now, thank you Mikita Siadykh.

Generated at Thu Feb 08 23:23:28 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.