Batch Importer (Bib/Acq) (UXPROD-47)

[UIDATIMP-915] folio-testing UI is completely broken for all apps Created: 04/May/21  Updated: 22/Jun/21  Resolved: 25/May/21

Status: Closed
Project: ui-data-import
Components: None
Affects versions: None
Fix versions: 4.1.0
Parent: Batch Importer (Bib/Acq)

Type: Bug Priority: P2
Reporter: Zak Burke Assignee: Mariia Aloshyna
Resolution: Done Votes: 0
Labels: data-import, di-functional-bug, epam-folijet
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: Text File folio-testing.dev.folio.org-1620127557515.log.txt    
Issue links:
Blocks
blocks UIDATIMP-898 Data Import Settings > Apply baseline... Closed
blocks UIDATIMP-900 Data Import Settings > Apply baseline... Closed
Defines
defines UXPROD-2851 NFR: Data Import (Batch Importer for ... Closed
Sprint: Folijet Sprint 113, Folijet Sprint 114, Folijet Sprint 115
Story Points: 5
Development Team: Folijet
Release: R2 2021
Epic Link: Batch Importer (Bib/Acq)

 Description   

Overview: All apps at folio-testing fail to render.
Steps to Reproduce:

  1. Visit folio-testing
  2. Click any app

Expected Results: business as usual
Actual Results: a completely blank screen and a completely trashed console
Additional Information:

  • This has been going on since ~2021-04-30
  • This is not reproducible locally with testing's yarn.lock file This will reproduce locally when compiled and run with NODE_ENV=development
  • folio-snapshot does not show these results, even when its yarn.lock file exactly matches that of folio-testing (i.e. immediately after the nightly rebuilds), which is a total head-scratcher.

Interested parties: John Malconian, Ivan Kryzhanovskyi



 Comments   
Comment by Zak Burke [ 04/May/21 ]

Playing with this more, I am able to duplicate it with NODE_ENV=development and that seems to be the differentiating factor.

Comment by Zak Burke [ 04/May/21 ]

Mariia Aloshyna , Ivan Kryzhanovskyi: I don't entirely understand what is going on here, i.e. why this shows up given NODE_ENV=development but not NODE_ENV=production, but I believe the source of the trouble is two PRs in ui-data-import, 895 and 898, both aimed at providing baseline shortcut keys.

Steps to reproduce:

git clone git@github.com:folio-org/platform-complete.git
cd platform-complete
git checkout snapshot
yarn
export NODE_ENV=development
[copy stripes.config.js to ....local, changing the okapi.url field to https://folio-testing-okapi.dev.folio.org]
yarn stripes build ./stripes.config.js.local --output --no-minify --sourcemap
yarn stripes serve --existing-build ./output

Point a browser at http://localhost:3000 and click any app; observe the failure and the console:

react_devtools_backend.js:2557 TypeError: Cannot read property 'a' of undefined
    at Object.K (moment.js:5670)
    at Object.<anonymous> (ViewJobProfile.js:186)
    [...]

Although ViewJobProfile.js:186,

  static contextType = UploadingJobsContext;

hasn't changed in two years, in fact UploadingJobsContext changed in PR #895.

Steps to demonstrate that these are the troublesome commits:
Edit package.json, changing the data-import dep to the last commit before #895:

    "@folio/data-import": "folio-org/ui-data-import#f7201839a4242f2ba4709e86f034ddd72367c707",

build and serve again, and point a browser at http://localhost:3000 and click any app; observe apps now function as usual.

I didn't investigate further as I'm not familiar at all with this app. Hopefully it's as simple as making sure the object provided to the context is correctly connected :crossed-fingers:.

Comment by Ann-Marie Breaux (Inactive) [ 13/May/21 ]

Folijet shortcut changes reverted; will try again once this issue is resolved

Comment by Ann-Marie Breaux (Inactive) [ 25/May/21 ]

Hi Mariia Aloshyna All seems find with folio-testing now, so I'm closing this. Thank you!

Generated at Thu Feb 08 23:25:54 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.