Batch Importer (Bib/Acq)
(UXPROD-47)
|
|
| Status: | Closed |
| Project: | ui-data-import |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 4.1.0 | Parent: | Batch Importer (Bib/Acq) |
| Type: | Bug | Priority: | P2 |
| Reporter: | Zak Burke | Assignee: | Mariia Aloshyna |
| Resolution: | Done | Votes: | 0 |
| Labels: | data-import, di-functional-bug, epam-folijet | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||
| Sprint: | Folijet Sprint 113, Folijet Sprint 114, Folijet Sprint 115 | ||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||
| Development Team: | Folijet | ||||||||||||||||||||
| Release: | R2 2021 | ||||||||||||||||||||
| Epic Link: | Batch Importer (Bib/Acq) | ||||||||||||||||||||
| Description |
|
Overview: All apps at folio-testing fail to render.
Expected Results: business as usual
Interested parties: John Malconian, Ivan Kryzhanovskyi |
| Comments |
| Comment by Zak Burke [ 04/May/21 ] |
|
Playing with this more, I am able to duplicate it with NODE_ENV=development and that seems to be the differentiating factor. |
| Comment by Zak Burke [ 04/May/21 ] |
|
Mariia Aloshyna , Ivan Kryzhanovskyi: I don't entirely understand what is going on here, i.e. why this shows up given NODE_ENV=development but not NODE_ENV=production, but I believe the source of the trouble is two PRs in ui-data-import, 895 and 898, both aimed at providing baseline shortcut keys. Steps to reproduce:
git clone git@github.com:folio-org/platform-complete.git
cd platform-complete
git checkout snapshot
yarn
export NODE_ENV=development
[copy stripes.config.js to ....local, changing the okapi.url field to https://folio-testing-okapi.dev.folio.org]
yarn stripes build ./stripes.config.js.local --output --no-minify --sourcemap
yarn stripes serve --existing-build ./output
Point a browser at http://localhost:3000 and click any app; observe the failure and the console: react_devtools_backend.js:2557 TypeError: Cannot read property 'a' of undefined at Object.K (moment.js:5670) at Object.<anonymous> (ViewJobProfile.js:186) [...] Although ViewJobProfile.js:186,
static contextType = UploadingJobsContext;
hasn't changed in two years, in fact UploadingJobsContext changed in PR #895. Steps to demonstrate that these are the troublesome commits:
"@folio/data-import": "folio-org/ui-data-import#f7201839a4242f2ba4709e86f034ddd72367c707",
build and serve again, and point a browser at http://localhost:3000 and click any app; observe apps now function as usual. I didn't investigate further as I'm not familiar at all with this app. Hopefully it's as simple as making sure the object provided to the context is correctly connected :crossed-fingers:. |
| Comment by Ann-Marie Breaux (Inactive) [ 13/May/21 ] |
|
Folijet shortcut changes reverted; will try again once this issue is resolved |
| Comment by Ann-Marie Breaux (Inactive) [ 25/May/21 ] |
|
Hi Mariia Aloshyna All seems find with folio-testing now, so I'm closing this. Thank you! |