Batch Importer (Bib/Acq) (UXPROD-47)

[UIDATIMP-1162] Fix Accessibility problems on /data-import view all logs page. Created: 27/Apr/22  Updated: 28/Sep/22  Resolved: 14/Jun/22

Status: Closed
Project: ui-data-import
Components: None
Affects versions: None
Fix versions: 5.2.0
Parent: Batch Importer (Bib/Acq)

Type: Task Priority: P3
Reporter: Jakhongir Abdukhamidov Assignee: Jakhongir Abdukhamidov
Resolution: Done Votes: 0
Labels: accessibility, data-import, epam-folijet
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File accessibilityCheckbox.png     PNG File accessibilityRow.png     PNG File image-2022-06-13-11-42-07-121.png     PNG File prevLogs-1.png    
Issue links:
Blocks
is blocked by UIREQ-716 MCL (aXe testing and development) Closed
Continues
continues UIDATIMP-1116 Accessibility check: Data Import View... Closed
Defines
defines UXPROD-3502 Enhancements to the Data Import log (... Closed
Relates
relates to UIDATIMP-1190 View all logs table allows user to so... Closed
Sprint: Folijet Sprint 142, Folijet Sprint 141
Story Points: 1
Development Team: Folijet
Release: Morning Glory (R2 2022)
Epic Link: Batch Importer (Bib/Acq)

 Description   

1. Elements with role="row" should have direct children elements with roles cell, columnheader, gridcell, rowheader on stripes components.

    Issue description: 

    **    Required ARIA children role not present: cell, columnheader, gridcell, rowheader. 

    Element Source

 

<div role="grid">
     <div role="rowgroup">
        <div data-row-index="0" aria-rowindex="2" role="row">
          <div role="row" aria-rowindex="2">
            <a href="/">
              <div role="gridcell">...</div>
            </a>
          </div>
        </div>
        ...
     </div>
</div>

FIX: 

It's already been discussed in the slack stripes channel slack discuss link.

and already been made a PR as well, https://github.com/folio-org/ui-requests/pull/849

2. Second issue is interconnected to the first one. 
   Issue Description:  
   Required ARIA parents role not present: grid, rowgroup, table, treegrid

   FIX:  
   Solving the first issue resolves the second one too.

 

 

 

 

     **     

 



 Comments   
Comment by Jakhongir Abdukhamidov [ 27/Apr/22 ]

Needs to be checked after this PR is merged.

 

Comment by Ann-Marie Breaux (Inactive) [ 02/May/22 ]

Hi Jakhongir Abdukhamidov Just wanted to doublecheck - does this require UIREQ-716 Closed to be finished, or does it require STCOM-904 Closed and/or STSMACOM-624 Closed ? For now, I've blocked it on UIREQ-716 Closed . Thank you!

Comment by Jakhongir Abdukhamidov [ 02/May/22 ]

Hi Ann-Marie Breaux, Yeah Thanks, It also uses the same component as view all logs and if that solution is approved then we can do the same for view all logs too but we don't actually directly need this PR to be merged for us to implement the same solution. 

Comment by Jakhongir Abdukhamidov [ 13/Jun/22 ]

Hi Ann-Marie Breaux, All accessibility problems fixed on view all logs page except the one that requires STSMACOM-669 Closed to be merged, but we can fix that one problem in scope of UIDATIMP-1190 Closed as it solves both accessibility and checkbox sorting.

Color contrast shows some number of problems in axe-tools but Folio modules use WCAG contrast checker and it shows zero problems. 

 

 

Comment by Ann-Marie Breaux (Inactive) [ 14/Jun/22 ]

Hi Jakhongir Abdukhamidov All sounds good - thank you for finding these issues and getting them sorted out. Closing this Jira

Generated at Fri Feb 09 00:33:43 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.