[UICR-161] UI error when editing a note on a Course record Created: 23/Jun/22 Updated: 28/Dec/22 Resolved: 06/Oct/22 |
|
| Status: | Closed |
| Project: | ui-courses |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 5.2.0 |
| Type: | Bug | Priority: | P3 |
| Reporter: | Molly Driscoll | Assignee: | Charlotte Whitt |
| Resolution: | Done | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue links: |
|
||||||||
| Sprint: | |||||||||
| Development Team: | Thor | ||||||||
| Release: | Morning Glory (R2 2022) Bug Fix | ||||||||
| Affected Institution: |
!!!ALL!!!, MI State University/Library of Michigan
|
||||||||
| Tester Assignee: | Charlotte Whitt | ||||||||
| RCA Group: | Implementation coding issue | ||||||||
| Description |
| Comments |
| Comment by Ann-Marie Breaux (Inactive) [ 24/Jun/22 ] |
|
Hi Charlotte Whitt Here's another courses one with no dev team. Per your request, I won't assign to Thor. Could you review and decide next steps? Thank you! |
| Comment by Zak Burke [ 01/Jul/22 ] |
|
We are facing a similar bug in ui-requests that we've tracked down to the line
<FormattedMessage id={requestStatusesTranslations[rq.status]} />,
in RequestsRoute. If rq.status is empty or if the assigned status isn't present in that array this effectively results in
<FormattedMessage id={null} />,
which causes the error described here:
|
| Comment by Zak Burke [ 01/Jul/22 ] |
|
Specifically I'd look at
./src/components/Courses.js:165: <FormattedMessage id={hideOrShowMessageId}>
./src/components/Reserves.js:142: <FormattedMessage id={hideOrShowMessageId}>
in case hideOrShowMessageId can be null. |
| Comment by Ann-Marie Breaux (Inactive) [ 04/Jul/22 ] |
|
Hi Charlotte Whitt If your preference is for these Course Reserves bugs not to be handled by Thor, is it OK for me to assign Dev Team = Other? That will at least drop them out of the search results for unassigned bugs. Thank you! |
| Comment by Anya [ 11/Jul/22 ] |
|
Support: Charlotte Whitt - bringing this to your attention. |
| Comment by Zak Burke [ 17/Jul/22 ] |
|
Molly Driscoll, it's worth noting there is a simple workaround, which is to click the note's "Edit" link on the course-details pane; this bug only presents when you click the note's row (to show the note-details full-screen) and then use the "Actions" menu to access "Edit". Previously, this bug reproduced in snapshot if you took the non-workaround approach to editing a course note (i.e. click its row, then "Actions" menu, then "Edit"). Thus, you can now test the fix there too. Charlotte Whitt, no MG release has been published for ui-courses even though there have been numerous translation updates and at least one bug fix (
|
| Comment by Molly Driscoll [ 18/Jul/22 ] |
|
Zak Burke thanks so much for working on this! I had noted this workaround in the reproduction steps above (see step 6 and sub-bullets), but that workaround was still presenting the pop-up options, which should only be present on a non-user note. |
| Comment by Charlotte Whitt [ 06/Sep/22 ] |
|
Support SIG: Molly Driscoll - I tested this in FOLIO Snapshot, and maybe we can get this work in for Morning Glory Bugfix work. To me this looks fine, but I do still see the Display note as a pop-up in the Check out app as an option. And I read your description as this should not be possible. Can you confirm what's expected: |
| Comment by Molly Driscoll [ 06/Sep/22 ] |
|
Charlotte Whitt thank you for following up! Yes, the error appears to be resolved, but the pop-up selection option should only be present on a note added to the Users app. The expected behavior is reflected in this note, added to a request in the Requests app: https://folio-snapshot.dev.folio.org/requests/notes/8e49dee4-0459-4fde-bd71-ed22eb1f63e0
If you edit the note, the pop-up options do not appear. Thanks so much! |
| Comment by Charlotte Whitt [ 19/Sep/22 ] |
|
Support SIG: Zak Burke will this work still be solved for Morning Glory Bugfix? |
| Comment by Zak Burke [ 19/Sep/22 ] |
|
Charlotte Whitt, no, the PR was not included in a Morning Glory release. Version 5.1.0 was published for Lotus, and version 5.2.0 appears to be targeted at Nolana since it includes support for an Okapi interface that won't be available until Nolana (see PR 203 and
Mike Taylor, can you clarify the target of the 5.2.0 release, Morning Glory vs Nolana? If Morning Glory, I worry that we are setting ourselves up for a failure similar to
|
| Comment by Mike Taylor [ 20/Sep/22 ] |
|
Zak Burke I had not role in deciding what flower release a given ui-courses was intended for. But:
That seems wrong to me, as the PR you linked only adds support for v10.0 of the item-storage interface, and does not remove support for v9.0 and earlier. Unless I am missing something there is no reason why ui-courses 5.2.0 can't be in MG. |
| Comment by Zak Burke [ 20/Sep/22 ] |
|
Mike Taylor , I don't know how Okapi does version resolution. The problem we had with yarn in
If that's not a concern, then you're right that ui-courses 5.2.0 is acceptable for Morning Glory. |
| Comment by Mike Taylor [ 20/Sep/22 ] |
|
I don't know the details of how Okapi does interface-version dependency resolution, but I do know three things. (1) Adam Dickmeiss is super-smart and I trust him to get it right. (2) Okapi has done the right think since we started telling it that ui-courses needed item-storage 7.1 or 8.0 back in January 2020, and it's kept doing it right as we've added 9.0 and more recently 10.0. (3) people need to stop making backwards-incompatible changes in their APIs! I am confident that ui-courses v5.2.0 will be fine in MG, and am surprised it's not already included. |
| Comment by Adam Dickmeiss [ 20/Sep/22 ] |
|
It should be OK to add an interface "range" which includes interface versions from a future FOLIO release. The module is released later and it is known that 10 or whatever is ok even for a module developed way earlier.
|
| Comment by Zak Burke [ 20/Sep/22 ] |
|
Adam Dickmeiss ,
Anyway, as Mike has already pointed out, we've already seen that Okapi does The Right Thing here, and now the only mystery is why ui-courses v5.2.0 isn't being pulled into MG builds as expected. Mike Taylor, are you on top of that? We certainly don't need three people working on that issue, but I want to make sure at least one is |
| Comment by Mike Taylor [ 20/Sep/22 ] |
|
Zak Burke I had a feeling it was your Yarn Being Dumb experience that were spooking you here I have no idea why 5.2.0 isn't in MG. I guess John Malconian would be the person to fix that? |
| Comment by John Malconian [ 20/Sep/22 ] |
|
Mike Taylor fyi. https://github.com/folio-org/platform-complete/pull/2167 |
| Comment by Mike Taylor [ 20/Sep/22 ] |
|
Thanks, John Malconian! |
| Comment by Khalilah Gambrell [ 26/Sep/22 ] |
|
Hey Charlotte Whitt. Did this issue make the Morning Glory release? |
| Comment by Zak Burke [ 06/Oct/22 ] |
|
Khalilah Gambrell, yes, this made it into v5.2.0, which is part of Morning Glory. |
| Comment by Khalilah Gambrell [ 06/Oct/22 ] |
|
Thank you Zak Burke |
| Comment by Molly Driscoll [ 28/Dec/22 ] |
|
Charlotte Whitt happy holidays! Just reviewing my notes for courses training and came back to this bug. Should I file a separate bug report to have the pop-up options removed from the notes on the courses record? The issue persists in Nolana. It doesn't appear to be causing errors any longer, but may be misleading to users since it's not functional outside of the Users app. Please let me know how you would like to handle it and I'm happy to follow your guidance. |