[UICIRC-673] Staff slip print: Stuck in Landscape, the option to change that is missing Created: 10/Aug/21  Updated: 27/Jun/22  Resolved: 30/Aug/21

Status: Closed
Project: ui-circulation
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P1
Reporter: julie.bickle Assignee: julie.bickle
Resolution: Done Votes: 0
Labels: juniper-bugfest, original, regression, staff_slips, support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: File Proof.mp4     PNG File StaffSlip_PrintView_IrisWithLayout.PNG     PNG File StaffSlip_PrintView_JuniperWithoutLayout.PNG     PNG File image-2021-08-17-11-40-54-693.png     PNG File image-2021-08-19-13-53-05-844.png     PNG File juniper_landscape_print.png    
Issue links:
Defines
is defined by UINV-288 R2 Juniper Hotfix - global CSS styles... Closed
is defined by UIOR-775 R2 Juniper Hotfix - global CSS styles... Closed
Gantt End to Start
has to be done after UICIRC-677 SPIKE: Investigate staff slip print: ... Closed
Sprint: ACQ Sprint 121
Story Points: 0
Development Team: Thunderjet
Release: R2 2021 Hot Fix #2
CSP Approved: Yes
CSP Request Details: Approved via #release_bug_triage on Sept 3, 2021
Affected Institution:
Chalmers, Cornell, MO State
RCA Group: Legitimate regression

 Description   

Overview: 

When printing a staff slip, I can only print it in landscape. In the printing options, there is no option to change back to portait.
 

Steps to Reproduce:

In FOLIO Juniper Bug Fest >> Settings >> Circulation >> Staff Slips >> [Any of the four; this bug was tested on] Transit >> Preview >> Print

I confirm this also happens when checking in an item.

I confirm that it's the exact same issue in Edge (for Iris and Juniper) [sorry, don't have other browsers or operatings systems at hand).

 

Expected Results:

In Iris, the staff slips are by defaut in Portrait - this should remain in Juniper. [StaffSlip_PrintView_IrisWithLayout.PNG]

 

Actual Results:

The page is in Landscape, and there is no option to change it. [StaffSlip_PrintView_JuniperWithoutLayout.PNG]

 

Additional Information:

I have this quote from the Vega grooming meeting of 10 Aug which could maybe help: "There's a special tag in CSS to overwrite browser settings."

 

Interested parties: Cornell // Anyone using Juniper live.



 Comments   
Comment by julie.bickle [ 10/Aug/21 ]

Thomas Trutt FYI here's the bug for the printing settings you mentioned in https://folio-org.atlassian.net/browse/UICHKIN-277 

Comment by Oleksandr Vidinieiev [ 12/Aug/21 ]

Comment by Anna Melnyk [ 16/Aug/21 ]

In comment above is the screen with styles which are the reason of current bug.
Investigation showed that changes were made by Aliaksei Chumakou in ui-orders here became a global styles and works for all modules. As well changes from ui-invoice also will affect all modules but the browser settings should not be overwritten. 

cc: Taisiya Trunova, Dmitriy Litvinenko

Comment by Brooks Travis [ 16/Aug/21 ]

In my opinion, this needs to be fixed ASAP, in Juniper.

Comment by David Bottorff [ 16/Aug/21 ]

At UChicago, we rely on receipt printers to print staff slips (particularly request hold slips), so if this would prevent us from using receipt printers, that will be a big issue for us. It seems likely to be cut, wrapped, or scaled such as to be illegible. If that's the case, this would be high priority.

Comment by Marie Widigson [ 17/Aug/21 ]

Using https://folio-snapshot.dev.folio.org/ , I tested our receipt printer (Star TSP700II) with the same settings and template as we are using in live. Got an two meter long receipt with microscopic text  We would have to use A4-printers and fold the pick up slips until this is fixed. julie.bickle

Comment by Zak Burke [ 17/Aug/21 ]

As Anna Melnyk noted above, the symptom shows up here in ui-circulation but the problem is actually global styles in other modules ( UINV-288 Closed , UIOR-775 Closed ). Once those are resolved, this ticket should resolve automatically.

FTR, this is not the first time – UICIRC-358 Closed , UICIRC-509 Closed – we have seen this problem. STRIPES-657/STRIPES-658 addresses the general need for automatically containing module-specific styles. That work has never been prioritized, but with more and more institutions in production, the impact of this kind of bug grows and grows. It may be time to spend some time on it, either automatically scoping styles, or introducing lint rules that prevent unscoped styles from being committed in the first place.

Also note, we've known about this problem for a long time – STCOR-149 Closed was filed in February 2018 – but was closed due to lack of prioritization. I know Agile methods dictate that we should remove stale tickets from the backlog in order to prevent cruft from accumulating, but this kind of issue serves as a counterpoint. I'm not saying, "Agile is wrong and we should abandon it," only that this kind of feature is a blindspot for Agile, and we should keep a bucket for this kind of work.

Comment by Victoria_Smelova [ 18/Aug/21 ]

To be fixed in scope of UINV-288 Closed and UIOR-775 Closed

Comment by Dennis Bridges [ 18/Aug/21 ]

julie.bickle do we need to consider this a Juniper Hotfix? It seems that TJET will need to update orders and invoices to resolve this but we have already passed the bug fix release deadline. thx

cc: Charlotte Whitt,Holly Mistlebauer

Comment by Brooks Travis [ 18/Aug/21 ]

Dennis Bridges julie.bickle Given the effect on those using receipt printers, this will be a blocker to upgrading to Juniper for folks. I'll reiterate my "ASAP" position.

Comment by julie.bickle [ 18/Aug/21 ]

Dennis Bridges Yes please, can we please consider this for a hot fix. After discussion with Chalmers and MO State (I'll catch up with Cornell tomorrow):

Any institution with receipt printers cannot upgrate to Juniper - unless they switch all their receipt printers to "normal" printers... Which I consider unrealistic --> No [reasonable] workaround.

Not being to print staff slips means physical items can't be transited/ shelved for pick up/ delivered --> If we go into lock-down again, then an insitution couldn't loan any physical items  --> I'm bumbing this up to P1.

Comment by Dennis Bridges [ 18/Aug/21 ]

Thanks julie.bickle I will update our related stories. Can you submit this for approval in release bug triage?

Note I have added the hotfix release tag so this will not be overlooked in the mean time. thanks!

Comment by Mikita Siadykh [ 19/Aug/21 ]

hi Tetiana Paranich
changes for related issues are available on testing env, it means this original issue is fixed as well, please review

Comment by Tetiana Paranich [ 19/Aug/21 ]

Work as expected on https://folio-testing.dev.folio.org

Google Chrome Version 92.0.4515.131 (Official Build) (64-bit)

See the attached Proof.mp4

Comment by julie.bickle [ 19/Aug/21 ]

I confirm, this worked as expected.

Though funnily enough we now have another issue that we had closed coz we throught is had gone, come back: https://folio-org.atlassian.net/browse/UICHKIN-277 
But Tetiana doesn't seem to have that issue? 

Comment by Mikita Siadykh [ 19/Aug/21 ]

hi julie.bickle it's separate issue that can be reproduced on Iris bugfest + it requires changes in ui-curcilation/or responsible for this action module, and not connected to regression that was produced by ui-orders and ui-invoices

Comment by julie.bickle [ 19/Aug/21 ]

Great, thanks for the confirmation.

Comment by Mikita Siadykh [ 30/Aug/21 ]

hi julie.bickle
could you please close this one if it works as expected? today is the last sprint day, thank you!

Comment by Dennis Bridges [ 30/Aug/21 ]

Seeing julie.bickle is away this week. Testing has been successful and the issues that was raised was determined to be separate so I am resolving this story. If there are any reaming issues julie.bickle please let us know when you return. thanks!

Comment by julie.bickle [ 15/Sep/21 ]

Looks good, thank you!

Generated at Fri Feb 09 00:30:11 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.