[UICIRC-1026] Cannot delete fixed due date schedules Created: 08/Dec/23  Updated: 20/Dec/23  Resolved: 19/Dec/23

Status: Closed
Project: ui-circulation
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P3
Reporter: Molly Driscoll Assignee: Artem Blazhko
Resolution: Done Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified
Environment:

Orchid SP #6


Attachments: File 2023-12-19_12h06_30.mp4     File E6FAC9C7-A362-4870-9EE3-27CA2546C612.MP4    
Issue links:
Defines
is defined by UICIRC-1028 Spike: Cannot delete fixed due date s... Closed
Sprint: EPAM-Veg Sprint 181
Story Points: 0.5
Development Team: Vega
Release: Quesnelia (R1 2024)
CSP Request Details: Libraries using fees/fines will be unable to update one fixed due date schedule without needing to alter all subsequent date ranges as well. This will take exponentially more time to do the longer an institution has been on FOLIO. The error is also present when creating a new fixed due date schedule.

All institutions on Orchid CSP 6 and later and Poppy are effected. Note: The error seems to have been coded 3 years ago.

The work around is manual. After the first range is deleted, all other dates can be changed. This will not be tenable for institutions with a lot of fixed due date schedules.

settings -> circulation -> fixed due date schedules creating and editing pages, fixed due date schedule details page will be impacted.

Brief explanation of technical implementation and the level of effort (in workdays) - Incorrect handling of "key" properties. Technical implementation already done and can be found here (DRAFT PR, requires additional testing locally, maybe some changes in the code, no more than 1 day) - https://github.com/folio-org/ui-circulation/pull/1109

Low to medium technical risk.

Testing - manual testing or/and automation testing of fixed due date schedules creating and editing pages, fixed due date schedules details page.

Roll back plan - revert new changes, find another approach to fix it.
Affected Institution:
!!!ALL!!!
RCA Group: Implementation coding issue
Affected releases:
Poppy (R2 2023), Orchid (R1 2023)

 Description   

See https://folio-org.atlassian.net/wiki/pages/viewpage.action?pageId=5210256 and assign the bug to the appropriate development team and PO.

Overview: In Settings > Circulation > Fixed due date schedules, users with appropriate permissions should have the ability to delete date ranges using the trash can icon. However, when trying to delete a fixed due date range, this also alters the contents of subsequent ranges, causing overlap and preventing save. This will be problematic for libraries the longer they're on FOLIO as this page gets longer with more entries.

Steps to Reproduce:

  1. Log into Poppy Bugfest: https://bugfest-poppy.int.aws.folio.org/ 
  2. Open Settings > Circulation > Fixed due date schedules
  3. Create a fixed due date schedule with at least three date ranges (not overlapping).
  4. Save and close.
  5. Click Actions > Edit on the schedule.
  6. Click the trash can icon on the first date range.

Expected Results: The first range is removed without impacting other ranges. You are able to save and close the page.

Actual Results: The first range is removed, but subsequent ranges have their dates altered. This presents an overlap conflict and prevents save.

Additional Information: First discovered on EBSCO FOLIO training tenant (Orchid SP#6), but replicated on Poppy Bugfest.
URL:

Interested parties: Molly Driscoll 



 Comments   
Comment by Molly Driscoll [ 08/Dec/23 ]

Stephanie Buck I think this should go to Vega, but please reassign if I got that wrong!

Comment by Anya [ 11/Dec/23 ]

Support: Stephanie Buck  do you know what release this might be in ?

Libraries are coming up on the time to change fixed due date schedules - so this might cause some issues - could we advise libraries to edit the current ones? 

Comment by Stephanie Buck [ 11/Dec/23 ]

It has not been assigned a release because the bug was filed Friday and today is Monday. I will speak to Vega about the earliest release this could be included in and assign then. 

Molly Driscoll, is there a potential workaround we could add to the ticket?

Comment by Molly Driscoll [ 11/Dec/23 ]

Stephanie Buck I'm not aware of a workaround, except for possibly editing the existing schedules. However, I'm not sure if re-using these schedules would have a negative impact on previous circulations using those schedules.

Comment by Stephanie Buck [ 12/Dec/23 ]

Thank you, Molly!

Comment by Oleksandr Hrusha [ 19/Dec/23 ]

Tested on snapshot, works as expected

2023-12-19_12h06_30.mp4

Comment by Oleksandr Hrusha [ 19/Dec/23 ]

Hello Molly Driscoll could you please confirm fix?

Comment by Stephanie Buck [ 19/Dec/23 ]

I have reviewed the video above and can confirm the fix. Thanks Oleksandr Hrusha

Comment by Molly Driscoll [ 20/Dec/23 ]

I also confirmed on Snapshot and it looks great! Thank you both so much!

Generated at Thu Feb 08 22:23:31 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.