Loans (UXPROD-788)

[UICHKOUT-802] Final fix to make "Check out: View Fees/Fines" work as expected Created: 07/Apr/22  Updated: 01/Sep/23  Resolved: 18/May/23

Status: Closed
Project: ui-checkout
Components: None
Affects versions: None
Fix versions: 10.0.0
Parent: Loans

Type: Task Priority: P3
Reporter: Erin Nettifee Assignee: Dmitriy Litvinenko
Resolution: Done Votes: 0
Labels: ui-only, vega_standalone
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: File C388524_passed.webm     File C388525_passed.webm     JPEG File open_accounts.JPG    
Issue links:
Defines
defines UXPROD-3960 Vega - Poppy Enhancements/Bugfixes/Te... Closed
Relates
relates to UICHKOUT-729 Permission "Check Out: View Fees/Fine... Closed
relates to UICIRC-693 Fee/Fine permissions - Create view fe... Closed
relates to FAT-5944 Review of C388524 test case Closed
relates to FAT-5945 Review of C388525 test case Closed
Sprint: EPAM-Veg Sprint 164, EPAM-Veg Sprint 165
Story Points: 1
Development Team: Vega
Release: Poppy (R2 2023)
Epic Link: Loans

 Description   

The permission ui-checkout.viewFeeFines- "Check out: View fees/fines" - was implemented in Iris to support needed functionality in the Check Out app.

In the Check Out app, libraries wanted to present information about a patron's owed fee/fines without necessarily giving full access to a patron's record.

The idea was that a patron with just ui-checkout.all would get text of the amount owed, but a patron with access to the check out app PLUS "Check out: view fees/fines" would get a link that would take them into the Users app to view more information about the patron's fine history.

However, this permission was never able to work as expected because a permission to simply view fees/fines didn't exist yet in the Users app. See UICHKOUT-729 Closed for a discussion about how the functionality was broken.

So, the link in the Scan card pane was coded to require ui-users.accounts, but ui-users.accounts grants way too much access to fine functionality.

A permission to view fees/fines (and loans, which is necessary for being able to view complete fine information) was implemented in Kiwi Bugfix - see UICIRC-693 Closed .

The permission is ui-users.feesfines.view

Now that this permission exists, we need to fix the desired functionality of "Check out: View fees/fines" by updating the permission control:

https://github.com/folio-org/ui-checkout/blob/master/src/components/UserDetail/Loans.js#L87

Rather than requiring ui-checkout.viewfeefines and ui-users.accounts to make the link work, we need to require ui-checkout.viewFeeFines and ui-users.feesfines.view to finally get to the way this link was spec'd out to work.

Acceptance criteria
1. A user assigned "ui-checkout.circulation" and "ui-checkout.viewfeesfines" and ui-users.feefines.view with no other permissions in the Users app can view a patron record in the Scan card pane. If the user has fines, they can click the fine amount as a link and have it open the fine information in the Users app.
2. A user assigned "ui-checkout.circulation" and NOT assigned "ui-checkout.viewfeesfines" will be able to view a patron record in the Scan card pane. If the user has fines, they are able to see the amount as text, but the amount is not a link to the fine information in the user record.



 Comments   
Comment by Erin Nettifee [ 07/Apr/22 ]

Holly Mistlebauer and Cheryl Malmborg - I am revisiting this issue with writing documentation for permissions updates for the Kiwi docs for docs.folio.org, as "Check out: View Fees/fines" can finally be updated to require the "Users: view fee/fines and loans" permission.

If this looks correct to you, I will assign it to Vega to get it in their queue.

Comment by Dmitriy Litvinenko [ 19/Apr/23 ]

Hello Erin Nettifee 

1. In Acceptance criteria we have only "ui-checkout.circulation" and "ui-checkout.viewfeesfines" with out  "ui-users.feesfines.view". Could you please confirm that i understood correct permission "ui-checkout.viewfeesfines" should have sub permission "ui-users.feesfines.view"?

2. In Acceptance criteria we have "they can click the fine amount as a link and have it open the fine information in the Users app." Could you please confirm that i understood correct and we should navigate to /users/{userId}/accounts/open (open_accounts.JPG)

 

CC: Stephanie Buck 

Comment by Erin Nettifee [ 20/Apr/23 ]

Hi Dmitriy Litvinenko

1. In Acceptance criteria we have only "ui-checkout.circulation" and "ui-checkout.viewfeesfines" with out "ui-users.feesfines.view". Could you please confirm that i understood correct permission "ui-checkout.viewfeesfines" should have sub permission "ui-users.feesfines.view"?

Yes, you are correct, I phrased the acceptance criteria badly. I have added this.

2. In Acceptance criteria we have "they can click the fine amount as a link and have it open the fine information in the Users app." Could you please confirm that i understood correct and we should navigate to /users/

Unknown macro: {userId}

/accounts/open (open_accounts.JPG)

Yes, your understanding is correct.

Comment by Dmitriy Litvinenko [ 20/Apr/23 ]

Thank you

Comment by Dmitriy Litvinenko [ 27/Apr/23 ]

Permissions name:

ui-checkout.circulation Check out: Check out circulating items
ui-checkout.viewFeeFines Check out: View fees/fines
ui-users.feesfines.view Users: Can view fees/fines and loans

Comment by Oleksandr Hrusha [ 18/May/23 ]

Checked on snapshot, work as expected, see attachments:

C388525_passed.webm

C388524_passed.webm

Comment by Oleksandr Hrusha [ 18/May/23 ]

Hello Erin Nettifee  could you please review the story?

Comment by Erin Nettifee [ 18/May/23 ]

PO reviewed on Snapshot; works as expected.

Generated at Fri Feb 09 00:33:34 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.