Loans
(UXPROD-788)
|
|
| Status: | Closed |
| Project: | ui-checkout |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 10.0.0 | Parent: | Loans |
| Type: | Task | Priority: | P3 |
| Reporter: | Erin Nettifee | Assignee: | Dmitriy Litvinenko |
| Resolution: | Done | Votes: | 0 |
| Labels: | ui-only, vega_standalone | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||||||||||
| Sprint: | EPAM-Veg Sprint 164, EPAM-Veg Sprint 165 | ||||||||||||||||||||||||||||
| Story Points: | 1 | ||||||||||||||||||||||||||||
| Development Team: | Vega | ||||||||||||||||||||||||||||
| Release: | Poppy (R2 2023) | ||||||||||||||||||||||||||||
| Epic Link: | Loans | ||||||||||||||||||||||||||||
| Description |
|
The permission ui-checkout.viewFeeFines- "Check out: View fees/fines" - was implemented in Iris to support needed functionality in the Check Out app. In the Check Out app, libraries wanted to present information about a patron's owed fee/fines without necessarily giving full access to a patron's record. The idea was that a patron with just ui-checkout.all would get text of the amount owed, but a patron with access to the check out app PLUS "Check out: view fees/fines" would get a link that would take them into the Users app to view more information about the patron's fine history. However, this permission was never able to work as expected because a permission to simply view fees/fines didn't exist yet in the Users app. See
So, the link in the Scan card pane was coded to require ui-users.accounts, but ui-users.accounts grants way too much access to fine functionality. A permission to view fees/fines (and loans, which is necessary for being able to view complete fine information) was implemented in Kiwi Bugfix - see
The permission is ui-users.feesfines.view Now that this permission exists, we need to fix the desired functionality of "Check out: View fees/fines" by updating the permission control: https://github.com/folio-org/ui-checkout/blob/master/src/components/UserDetail/Loans.js#L87 Rather than requiring ui-checkout.viewfeefines and ui-users.accounts to make the link work, we need to require ui-checkout.viewFeeFines and ui-users.feesfines.view to finally get to the way this link was spec'd out to work. Acceptance criteria |
| Comments |
| Comment by Erin Nettifee [ 07/Apr/22 ] |
|
Holly Mistlebauer and Cheryl Malmborg - I am revisiting this issue with writing documentation for permissions updates for the Kiwi docs for docs.folio.org, as "Check out: View Fees/fines" can finally be updated to require the "Users: view fee/fines and loans" permission. If this looks correct to you, I will assign it to Vega to get it in their queue. |
| Comment by Dmitriy Litvinenko [ 19/Apr/23 ] |
|
Hello Erin Nettifee 1. In Acceptance criteria we have only "ui-checkout.circulation" and "ui-checkout.viewfeesfines" with out "ui-users.feesfines.view". Could you please confirm that i understood correct permission "ui-checkout.viewfeesfines" should have sub permission "ui-users.feesfines.view"? 2. In Acceptance criteria we have "they can click the fine amount as a link and have it open the fine information in the Users app." Could you please confirm that i understood correct and we should navigate to /users/{userId}/accounts/open (open_accounts.JPG)
CC: Stephanie Buck |
| Comment by Erin Nettifee [ 20/Apr/23 ] |
Yes, you are correct, I phrased the acceptance criteria badly. I have added this.
Yes, your understanding is correct. |
| Comment by Dmitriy Litvinenko [ 20/Apr/23 ] |
|
Thank you |
| Comment by Dmitriy Litvinenko [ 27/Apr/23 ] |
|
Permissions name: ui-checkout.circulation Check out: Check out circulating items |
| Comment by Oleksandr Hrusha [ 18/May/23 ] |
|
Checked on snapshot, work as expected, see attachments: |
| Comment by Oleksandr Hrusha [ 18/May/23 ] |
|
Hello Erin Nettifee could you please review the story? |
| Comment by Erin Nettifee [ 18/May/23 ] |
|
PO reviewed on Snapshot; works as expected. |