[SUP-64] Error when changing licenses visibility Created: 11/Mar/22  Updated: 28/Mar/22  Resolved: 28/Mar/22

Status: Closed
Project: Support
Components: Licenses
Affects versions: None
Fix versions: None

Type: Bug Priority: P2
Reporter: Samuel Lemon Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: erm, front-end, support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint:
Development Team: Bienenvolk
Potential Workaround: making value a required field for licenses terms or making the error message say "please fill in the value field"
Affected Institution:
University of Zaragoza
RCA Group: TBD

 Description   

Overview: Error related to ERM/Licenses for https://unizar.folio.ebsco.com which is on Juniper-hotfix-4.2. When librarian tries to change the licenses conditions (Licencias) from Public (Público) to Internal (Interna) this error is retrieved: ERROR: in module @folio/licenses, operation PUT on resource "license" failed, saying: {"message¨: "Property customProperties is type-mismatched","path":"","_links":{"self":

{"href":"[http://127.0.0.1:8082|http://127.0.0.1:8082/]"}

}}, see image error: https://www.screencast.com/t/DAKiQ9FaqKd

After looking into this error more. It seems this error only occurs if you try to change the visibility of the term when the value field is empty. If the term has something in the value field, you can change the visibility successfully. 

For a Kiwi release branch website, if you change the visibility of a term that has an empty value field it will look like it was successful (Successful green pop-up message and returns you to previous page) but it will not change the visibility. If the term does have something in the value field, you can change the visibility successfully. This was tested on https://bugfest-kiwi.folio.ebsco.com/

Steps to Reproduce:

  1. Log into https://unizar.folio.ebsco.com, https://bugfest-kiwi.folio.ebsco.com/, or another folio UI
  2. Open the Licenses app.
  3. Click on one of the Licenses > Actions > Edit
  4. Scroll down to the Terms section and try to change the visibility of one of them that does not have something in the value field.

Expected Results: After you click save, a success message will pop up and the term visibility for that licenses will have changed. 

 

Actual Results: 

For Juniper releases, this error will appear: ERROR: in module @folio/licenses, operation PUT on resource "license" failed, saying: {"message¨: "Property customProperties is type-mismatched","path":"","_links":{"self":

{"href":"[http://127.0.0.1:8082|http://127.0.0.1:8082/]"}

}}, see image error: https://www.screencast.com/t/DAKiQ9FaqKd

For Kiwi releases, there will be a success message pop up but the visibility will still be the same as before. 

Additional Information: This ticket (https://folio-org.atlassian.net/browse/ERM-1741) seems to be dealing with the same issue that is described above. 

Interested parties: Owen Stephens, Khalilah Gambrell, Carole Godfrey



 Comments   
Comment by Anya [ 14/Mar/22 ]

Support: Owen Stephens we are looking for a release target. Thanks. 

Comment by Owen Stephens [ 14/Mar/22 ]

Anya This is quite a specific issue - I'm a bit surprised it's a P2 as it doesn't actually stop anything working? Perhaps I'm missing something - but basically if you don't set a value for a property it doesn't get saved.

Comment by Anya [ 14/Mar/22 ]

Owen Stephens- not being the team that set the Priority, I cannot speak to it.

Is the value required once you make it visible- in order to save? if so then it should be indicated in some way. 

Comment by Owen Stephens [ 14/Mar/22 ]

Anya it's a bit of a tricky issue to be honest. The validation on these fields is not straightforward:

  • unless you set a value it won't be saved with the license
  • we don't prevent saving the license without a value for a particular property because this is a valid thing to do (not set a value)
  • the property can't be 'visible' (or non visible) unless a value has been set

So I understand that this can be slightly confusing, but there isn't an easy way we can validate the visibility unless they also enter a value

Comment by Anya [ 28/Mar/22 ]

Support: Owen Stephens we are going to close this ticket as a wont do - and you can bring this to your sig to see if you want to change the requirment.

Generated at Thu Feb 08 22:22:20 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.