Tags - Basic
(UXPROD-250)
|
|
| Status: | Closed |
| Project: | stripes-smart-components |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 1.5.0, 1.7.0 | Parent: | Tags - Basic |
| Type: | Story | Priority: | P2 |
| Reporter: | Ann-Marie Breaux (Inactive) | Assignee: | Michal Kuklis |
| Resolution: | Done | Votes: | 0 |
| Labels: | demo43, demo47, phase_1, sprint36, sprint37, sprint42, sprint43, sprint44, sprint45, sprint46, tags | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Tester Assignee: | Ann-Marie Breaux (Inactive) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Epic Link: | Tags - Basic | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
Purpose: To display, assign, unassign, and output tags associated with individual records with various FOLIO main apps. As a staff person Tags are meant to be labels that can be assigned to individual data records in various FOLIO apps. Tags will be used as a visual indicator in the record, to gather records in some way, and to facilitate reporting. This will be a cross-app “helper app,” similar to how the Notes app is envisioned. However, unlike notes, the tags need to be easily accessible as part of the record for filtering and output purposes. Ideally, most or all of the work will be centralized in the tags app, and can be easily consumed by any of the other main FOLIO apps to display in their records. The tags app should be applicable to any type of record in various FOLIO apps, including, but not limited to: users, instances, holdings, items, order lines, vendors, ledgers, funds, budgets, and the like. For proof of concept, we can start with User records. Once we know it works, we need to implement in the acquisitions records: order line records if Orders UI is available when this story is completed, otherwise vendor records. For purposes of illustrations, used the inventory instance record, since I can't easily build screenshots for other types of acquisitions records yet. Scenarios
|
| Comments |
| Comment by Cate Boerema (Inactive) [ 09/Apr/18 ] |
|
Great story, Ann-Marie Breaux! I love the detail. A couple comments:
Thanks! |
| Comment by Ann-Marie Breaux (Inactive) [ 09/Apr/18 ] |
|
Hi Cate Boerema - I think I've got this one straightened out now. Could you check it one more time? Thank you! |
| Comment by Cate Boerema (Inactive) [ 12/Apr/18 ] |
|
Looks great! Thanks Ann-Marie Breaux! |
| Comment by Jakub Skoczen [ 30/Apr/18 ] |
|
Ann-Marie Breaux with the backend in shape for the UI work we need to create an issue for Tagging "smartcomponent". Do we have any other wireframes besides the sketches above? |
| Comment by Ann-Marie Breaux (Inactive) [ 30/Apr/18 ] |
|
Hi Jakub Skoczen I'm not sure what you mean by tagging smartcomponent. Is that basically what a tag record should look like and the data elements it should include, or how it looks on an individual record, or the actual icon being used for the tag, or something else? |
| Comment by Jakub Skoczen [ 01/May/18 ] |
|
Ann-Marie Breaux I am referring to the Stripes smart component that will be used for assigning tags. The rough sketch is in the "09-Tag 4th Pane.JPG". There's also '10 Tag Creation.jpg" but I don't understand if this is part of the same component or (as the name indicates) it's related to Tag management. Let's clarify so that John Coburn can provide some input on how to proceed (do we need a completely new component or can the devs re-use or compose existing ones). |
| Comment by John Coburn [ 01/May/18 ] |
|
Jakub Skoczen, Ann-Marie Breaux This is a new component - its usage wouldn't be limited to tagging, but any situation where we need multiple selection from potentially long lists of system-known entities. |
| Comment by Ann-Marie Breaux (Inactive) [ 02/May/18 ] |
|
Hi Jakub Skoczen and John Coburn Picture 9 shows how tags look when displayed on a record. Picture 10 shows what should happen when you start entering text in the "Enter a tag" box at the bottom right of picture 9. Once you start typing, it should start auto-suggesting based on tags already in the central tag list, and the auto-suggest options would decrease as you type more characters into the "Enter a tag" box. At any point, you can select one of the existing auto-suggestions, or (depending on permissions) create/assign a new tag if you get to the point where no auto-suggestions remain. If it would help to discuss any of this, just let me know. We can find a few minutes to look at it together. Thank you! |
| Comment by Cate Boerema (Inactive) [ 10/Jul/18 ] |
|
Hi Ann-Marie Breaux. The team and I were looking for the best starter story for Tags and we thought this was it, but weren't totally sure because of a couple of things we saw here.
Otherwise, I think this story looks good. Maybe once you've made these changes you can bump the priority to P2? Same for
Thanks! |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Jul/18 ] |
|
Hi Cate Boerema Thanks for the suggestions. I'll update the issue per your comments, and change the Priority on the 2 issues. True there's no UI for a specificTags app in the first phase, but in conversations with Jakub Skoczen, it sounds like there is an app - even though users can't see it. Same applies to Notes. These Helper Apps may or may not actually have icons in the top App bar. In any event, I think it's only semantics, so no worries. |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Jul/18 ] |
|
And great to hear that work might be starting soon! If it would be helpful to discuss anything once developers start work, I'm happy to set up any meeting(s) that we may need. |
| Comment by Michal Kuklis [ 23/Jul/18 ] |
|
Jakub Skoczen and Ann-Marie Breaux I can definitely start on the tags helper app. We will need to get the new component described byJohn Coburn in https://folio-org.atlassian.net/browse/STCOM-263 ready before we can finalize this one. |
| Comment by Michal Kuklis [ 26/Jul/18 ] |
|
Ann-Marie Breaux here is a little screencast with the progress so far: tags.webm |
| Comment by Ann-Marie Breaux (Inactive) [ 30/Jul/18 ] |
|
Hi Michal Kuklis Video looks good! See scenario 9 though - no spaces allowed in tag text strings. Also, I could use your opinion about something. We were going to use the pipe delimiter as a separator for multiple tags in incoming data being loaded to FOLIO. For example, a tag string of new|do-now|fred, would load to folio as 3 separate tags: new do-now and fred One key partner wants to output a comma as separator instead of pipe. Pipe will be significant development effort that they are not willing to do at this time. Do you think the best path forward is |
| Comment by Michal Kuklis [ 31/Jul/18 ] |
|
Ann-Marie Breaux the tags are stored in the database as an array of strings for example ["foo", "bar", "test"] so I assume when the big list of tags will be imported from another system the backend converter/importer will need to replace "foo|bar|test" or "foo,bar,test" into ["foo", "bar", "test"]. We can do the same on the front end when somebody enters "foo|bar|test" or "foo,bar,test" we can convert those strings into ["foo", "bar", "test"]. |
| Comment by Michal Kuklis [ 31/Jul/18 ] |
|
Ann-Marie Breaux I just fixed the spaces from scenario 9 and also added support for scenario 15 (adding tags to the central repo). |
| Comment by Michal Kuklis [ 07/Aug/18 ] |
|
Ann-Marie Breaux I just received a new design from Filip Jakobsen and I'm attaching it here. |
| Comment by Ann-Marie Breaux (Inactive) [ 08/Aug/18 ] |
|
Thanks, Michal Kuklis some of these designs are for Phase 2, not Phase 1, so I need to straighten that out. I'm in meetings all day Weds-Fri this week, so may not be able to get to this until early next week. Do you have other things you're working on as well? |
| Comment by Filip Jakobsen [ 08/Aug/18 ] |
|
Michal Kuklis, Ann-Marie Breaux, I've asked David García Sánchez to update the specific mockups for this particular issue. Once those are ready, we can remove the many mockups uploaded here, that are only tangentially related to this issue to avoid any confusion. We still have the full set of mockups on hand for general information for anyone working on tags, as contextual information on where the app is going longer term. |
| Comment by Filip Jakobsen [ 08/Aug/18 ] |
|
By request of Ann-Mari, we will not be changing this issue. |
| Comment by Michal Kuklis [ 13/Aug/18 ] |
|
Hi everyone. I apologize for the confusion here. Ann-Marie Breaux I have plenty of other work so this can wait for phase 2 for sure. |
| Comment by Ann-Marie Breaux (Inactive) [ 31/Aug/18 ] |
|
@michal If I can get this story cleaned up by early next week, would you be able to complete it by 14 Sept? |
| Comment by Michal Kuklis [ 31/Aug/18 ] |
|
Hi Ann-Marie Breaux most of the scenarios are done. I'm currently in the process of replacing the basic text input with the multi selection component. I think we should be able to complete it before September 14th. |
| Comment by Michal Kuklis [ 05/Sep/18 ] |
|
Ann-Marie Breaux I was able to switch it to the MultiSelection component. Here is a little preview of how this currently works: multi-select-tags.webm There are couple things which are handled differently: Scenario #9 - user will be able to type space and pipe (|) but these signs will be removed / cleaned up before they are added to the list I think ideally it would be nice to perhaps close this story (after we test it) and if we need to improve or change some things we can create new JIRAs. Does that sound good to you? Thanks! |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ] |
|
Hi Michal Kuklis That sounds good to me. I'm testing this now. One question about
|
| Comment by Michal Kuklis [ 11/Sep/18 ] |
|
Ann-Marie Breaux I think the setting is off by default. I worry we won't be able to fix it at it point because I think it will require a server side change. We can file a new JIRA to get it fixed after the release. |
| Comment by Michal Kuklis [ 11/Sep/18 ] |
|
Ann-Marie Breaux the counter next to the tags and notes icons is currently not supported (Scenario 3). Let's move this to a new JIRA if possible. This will require a bit more work not just around tags I think. |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ] |
|
No problem, Michal Kuklis. I'll add a Jira for it. See problem with scenario 3 above. Should I write a bug ticket for this one too, instead of moving this issue back to In Progress? I'll keep working through the rest of the scenarios. Thank you! |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ] |
|
Michal Kuklis Will do. Should the new Jira address the issue for both Tags and Notes, or just Tags? |
| Comment by Michal Kuklis [ 11/Sep/18 ] |
|
Ann-Marie Breaux Yes I think scenario 3 will require more work to support it for both tags and notes. We also need a UI tweak ideally from Rasmus Wølk to support these kind of counters over icons. I think this will be a larger work so I think creating a new JIRA would be great. In general I think the functionality under this story works for but I'm sure we can improve it after Q3 release. |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ] |
|
Hi Michal Kuklis Definitely some bugs that I'll enter, but in general, it's great to see this coming to life! Another question for you: Is it possible to keep ghosted text of "Enter a Tag" in the text entry box when someone is not entering a tag? That way the user knows where that entry area is. Otherwise it's a little subtle. If you think it's possible, I'll enter a new Jira ticket for it. |
| Comment by Michal Kuklis [ 11/Sep/18 ] |
|
Ann-Marie Breaux thank you for testing this! I should be able to address some of them before the release. I will double test scenario 17 and scenario 8. I should be able to fix those. The issues in scenario 7 are related to the multi selection component and I worry these may take longer to fix so a separate JIRA would be great. |
| Comment by Michal Kuklis [ 11/Sep/18 ] |
|
I will see if we can keep the placeholder (ghosted text) around when some tags are already present. If this is a quick change I will add it if not it may need to wait for the multi selection component enhancement. |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ] |
|
Hi Michal Kuklis see highlight question in scenario 12. Is this do-able? If so, I can create a new Jira for it. |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ] |
|
And Michal Kuklis I have to stop now for meetings the rest of the day. I'll come back to this later tonight, to finish testing and start adding Jira tickets. Thank you! |
| Comment by Michal Kuklis [ 11/Sep/18 ] |
|
Ann-Marie Breaux I'm a bit confused about scenario 12. We had something like that before we introduced the multi selection component (the entered tags would show up above the text field). I'm not sure how scenario 12 should work here with the multi selection component. Are you suggesting that the multi selection component should stay empty and instead we should show the tags above it? |
| Comment by Michal Kuklis [ 11/Sep/18 ] |
|
Ann-Marie Breaux thanks again for testing it so well. I made couple more changes and fixed some of the bugs you encountered (please see the green comments above). For the rest of them I think we will need separate JIRAs. Most of the remaining issues are related to the multi selection component. |
| Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ] |
|
Tags are my baby, and it's great to see it coming to life - just have to straighten out the fingers and toes a bit. On a break at the library, and I just spotted these fixes. Thank you so much for jumping on them! I hope to finish the testing later tonight, and will clean up the Jira, plus enter the other tickets for the outstanding work. Thanks for all your help, Michal Kuklis |
| Comment by Rasmus Wølk [ 12/Sep/18 ] |
|
Michal Kuklis There's a "badgeCount" prop on the IconButton that allows you to add a number next to the label. More info here: https://ux.folio.org/storybook-draft/?selectedKind=IconButton |
| Comment by Michal Kuklis [ 12/Sep/18 ] |
|
Oh beautiful Rasmus Wølk! I was not aware of that. I will try to incorporate it here today. |
| Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ] |
|
Hi Michal Kuklis The tags functionality seems to have disappeared from snapshot-stable, and folio-testing seems to be down, so I'm stuck as far as reviewing any of yesterday's changes. I'll write up some of the bugs from yesterday that have not yet been addressed. |
| Comment by Michal Kuklis [ 12/Sep/18 ] |
|
Thank you Ann-Marie Breaux. I do see them under: http://folio-snapshot-stable.aws.indexdata.com and it looks like the fixes from yesterday are there. |
| Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ] |
|
It's there now! I swear 20 minutes ago it wasn't. Thank you! |
| Comment by Michal Kuklis [ 12/Sep/18 ] |
|
Ann-Marie Breaux np! Also I just added the counters to the tags icon based on the recommendation from Rasmus Wølk. Rasmus Wølk I do have one question about it. Please see this printscreen: |
| Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ] |
|
Hi Michal Kuklis OK - here's where we stand, I think |
| Comment by Michal Kuklis [ 12/Sep/18 ] |
|
Thanks Ann-Marie Breaux! Scenario 3 is now done (should be available tomorrow) I should be able to fix Scenario 8 today. Scenarios 7 and 12 will need to wait until we have support for it in multi selection component. Ideally we should create separate JIRAs for them. I'm hoping John Coburn will be able to help us here in the future. I do have a question about Scenario 14. Where would you like to see the message? Is it ok to show it above the multi selection component? If so I think this will be doable. Thanks again for testing this Ann-Marie Breaux! |
| Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ] |
|
Hi Michal Kuklis re: scenario 14 - I think above the multi-select component should be OK. Since the central tag list will quickly be scrolling way down the page, having it at the bottom right of the page, like most badges, would be problematic, right? Attached are a couple "success" badges, one that is totally green, and one that is just a green outline. I think I like the totally green one, if that fits with today's stylings. And it should only display if the tag is new to the central tag list. It should not display if the tag is already in the central tag list, but is being added to this particular record. That way the user has 1) an indication that this is a brand new tag. If they think they are using an existing tag, that might cause them to stop and see if they made a typo. 2) and we're going to have a permission level that allows users to assign existing tags, but not create new tags. Having that "new tag" badge will be one more little visual cue to people who have that create permission verses the users who only have assign permission. |
| Comment by Michal Kuklis [ 12/Sep/18 ] |
|
Ann-Marie Breaux ah this looks like a callout component which usually shows up at the bottom of the page. This is a very nice idea and I think it should work here very well. Let me give it a try. Good thinking! |
| Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ] |
|
|
| Comment by Michal Kuklis [ 12/Sep/18 ] |
|
ok Ann-Marie Breaux the sorting from Scenario 8 should be now fixed. Also the Callout from Scenario 14 should be also working. Unfortunately for some reason I applied the correct callout type (success) but the callout stays white (not green) I think we have a bug in the callout component. For now it will stay white. |
| Comment by Ann-Marie Breaux (Inactive) [ 17/Sep/18 ] |
|
Hi Michal Kuklis I closed scenarios 3 and 14. Will create a separate bug for simultaneous number update for scenario 3. I added a video illustrating the secondary sort situation for scenario 8. Let me know if you can fix as part of this ticket or if I should enter a separate bug. Thank you! |
| Comment by Michal Kuklis [ 17/Sep/18 ] |
|
Thank you Ann-Marie Breaux. The fixes so far should be included in Q3 but the changes I will make today to fix scenario 8 won't be included so I think it would be great to actually create a new bug for it. |
| Comment by Ann-Marie Breaux (Inactive) [ 17/Sep/18 ] |
|
Hi Michal Kuklis Done - see
|
| Comment by Michal Kuklis [ 17/Sep/18 ] |
|
Perfect thank you Ann-Marie Breaux! |