Tags - Basic (UXPROD-250)

[STSMACOM-113] Tags on individual records: Assign, Unassign, Display, Output Created: 09/Apr/18  Updated: 29/Aug/23  Resolved: 17/Sep/18

Status: Closed
Project: stripes-smart-components
Components: None
Affects versions: None
Fix versions: 1.5.0, 1.7.0
Parent: Tags - Basic

Type: Story Priority: P2
Reporter: Ann-Marie Breaux (Inactive) Assignee: Michal Kuklis
Resolution: Done Votes: 0
Labels: demo43, demo47, phase_1, sprint36, sprint37, sprint42, sprint43, sprint44, sprint45, sprint46, tags
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: JPEG File 01-Tag icon.jpg     JPEG File 02-Tag Indicator in Instance Search Results.jpg     JPEG File 03-Tag Indicator in Instance Prototype Search Results.jpg     JPEG File 04-Tag Indicator in Holdings Record.jpg     JPEG File 05-Tag Indicator in Item Record.jpg     JPEG File 06-Tag Indicator in User Search Results.jpg     JPEG File 07-Tag Icon with Number Indicator.jpg     JPEG File 08-Tag indicator with Existing Tags.jpg     JPEG File 09-Tag 4th pane.JPG     JPEG File 10-Tag Creation.jpg     File AutosuggestSecondSort.mp4     File AutosuggestSortOrder2.mp4     PNG File Badge1.PNG     PNG File Badge2.PNG     File ErrorWhenAddingTags.mp4     File ErrorWhenAddingTags.mp4     File HighlightQuestion.mp4     File HighlightingPart2.mp4     PNG File LongTag.PNG     File NumberOfTags.mp4     PNG File Settings 05.png     File Show all filesHide all filesShow all filesHide all files.webloc     File UppercaseBug.mp4     File multi-select-tags.webm     PNG File screenshot-1.png     PNG File tags-counter.png     File tags.webm    
Issue links:
Blocks
blocks UITAG-10 Permissions for Tags on Individual Re... Open
blocks UITAG-11 Permissions for Tags on Individual Re... Open
blocks UITAG-12 Permissions for Tags on Individual Re... Open
blocks UITAG-13 Permissions for Tags on Individual Re... Open
blocks UITAG-14 Permissions for Tags on Individual Re... Open
blocks UITAG-15 Permissions for Tags on Individual Re... Open
is blocked by STCOM-263 Multi-selection component Closed
is blocked by FOLIO-1194 design and implement tag backend Closed
is blocked by STCOM-316 Add new tags icon Closed
Relates
relates to UITAG-10 Permissions for Tags on Individual Re... Open
relates to UITAG-11 Permissions for Tags on Individual Re... Open
relates to UITAG-12 Permissions for Tags on Individual Re... Open
relates to UITAG-13 Permissions for Tags on Individual Re... Open
relates to UITAG-15 Permissions for Tags on Individual Re... Open
relates to UITAG-17 When printing a record, print its tag... Open
relates to UITAG-18 Tags permissions: Enabling tag app in... Closed
relates to UIOR-619 Tags with ALL CAPS labels are not dis... Closed
relates to UITAG-6 Tags autosuggest subsort needs tweaking Closed
relates to UIU-660 Number of tags should update simultan... Closed
relates to UXPROD-1124 Ability to assign Tags to Finance rec... Closed
relates to UXPROD-1125 Ability to assign Tags to Order recor... Closed
relates to UXPROD-1126 Ability to assign Tags to Organizatio... Closed
relates to UXPROD-1220 Ability to assign Tags to Data Import... Closed
relates to UXPROD-2073 Assign Tags to Order records and filt... Closed
relates to UITAG-4 Issues with Tags highlighting Closed
relates to UITAG-5 Issues with Tags pane layout Closed
relates to UITAG-16 When exporting a record, export tag d... Blocked
relates to UXPROD-251 Be able to create, delete, display, o... Closed
relates to UXPROD-1115 Be able to output tags from individua... Analysis Complete
Sprint:
Tester Assignee: Ann-Marie Breaux (Inactive)
Epic Link: Tags - Basic

 Description   

Purpose: To display, assign, unassign, and output tags associated with individual records with various FOLIO main apps.

As a staff person
I want to be able to assign, unassign, view, and output tags in a FOLIO record
So that I can categorize records for filtering and reporting purposes.

Tags are meant to be labels that can be assigned to individual data records in various FOLIO apps. Tags will be used as a visual indicator in the record, to gather records in some way, and to facilitate reporting. This will be a cross-app “helper app,” similar to how the Notes app is envisioned. However, unlike notes, the tags need to be easily accessible as part of the record for filtering and output purposes.

Ideally, most or all of the work will be centralized in the tags app, and can be easily consumed by any of the other main FOLIO apps to display in their records. The tags app should be applicable to any type of record in various FOLIO apps, including, but not limited to: users, instances, holdings, items, order lines, vendors, ledgers, funds, budgets, and the like.

For proof of concept, we can start with User records. Once we know it works, we need to implement in the acquisitions records: order line records if Orders UI is available when this story is completed, otherwise vendor records. For purposes of illustrations, used the inventory instance record, since I can't easily build screenshots for other types of acquisitions records yet.

Scenarios

  1. Scenario 1
    • Given Given Enable tags = Y in Settings > Tags > General per UITAG-18 Closed
    • When a User displays an User record in a search result
    • Then the Tags Icon should display at the top right of the record in the third pane, between the Edit Pencil icon and the Notes icon.
    • A-M: tags icon is to the left of both the edit pencil and notes icon, instead of between them. I don't care, but checking with Cate and Filip to see if they do. Per Cate, no problem.
      • See wireframes 01-06 attached. Use an icon similar to the one in 01, but make sure it's easily distinguishable from the Edit Pencil icon when very small on the screen.
  2. Scenario 2
    • Given the Tags Icon
    • When hovering over it
    • Then the label "Show Tags" should appear.
  3. Scenario 3
    • Given the Tags Icon
    • When tags are already assigned to a particular record
    • Then the system should display the number of tags to the left of the Tags Icon.
      • See wireframes 07-08 attached.
      • A-M: see attached video "NumberOfTags". I think the Notes application is supposed to act like this as well (show the number of tags or notes next to the icon in the record detail pane, so that the user knows whether it's worth clicking the tags icon or notes icon to see any additional details).
      • A-M: Michael corrected, but the total in the 3rd pane is not updating simultaneously with the number in the 4th pane. Adding a bug for it.
  4. Scenario 4
    • Given the Tags Icon
    • When it is clicked
    • Then a fourth pane with tag details (hereafter called the Tags Pane) should open to the right of the existing panes, similar to the Notes pane
      • See wireframe 09 attached.
  5. Scenario 5
    • Given the Tags Pane
    • When it has been opened as the fourth pane
    • Then no other "helper app" panes (e.g. Notes) should display. A user should only be able to have one helper app pane open at a time, but the icons for all relevant helper apps should still remain at the top of the screen, so that the user can switch between them.
  6. Scenario 6
    • Given the Tags Pane
    • When it has been opened as the fourth pane
    • Then it should stay defaulted to open, even if a user clicks on a different instance in the second pane search results, changing to the tags relevant to that newly-selected instance
  7. Scenario 7 [A-M entered separate Jira bug]
    • Given the Tags Pane
    • When it is viewed
    • Then the layout should appear like this
      • Header Tags
      • Sub-header [number] Tags representing the number of tags currently assigned to the record
      • Any existing assigned tags, in alphabetical order.
      • Each tag appears as its own separate box
      • An "x" appears in the right side of each tag's box, to allow the individual tag to be unassigned from the record.
      • Assigned tags can display next to each other, unless that would cause a tag to wrap to the next line, in which case move it to the following line.
      • A-M: second tag does not move to the next line correctly; exceeds the display box; see SecondTagNotDisplayedCorrectly screenshot; I'll add a Jira bug.
      • If one tag is too long to fit on one line, it can wrap to the next line
      • A-M: really long tag does not wrap to the next line; see LongTag screenhot. I'll add a Jira bug.
      • All tags for the record are displayed, with no shortening or ellipses
      • If many tags are assigned to a record, extend the Tag Pane into a longer pane that can be scrolled down
      • At the bottom of the pane, there should be a text entry box with ghosted text of "Enter a tag." It stays within the pane, even if there is a scroll bar above it, due to many tags being assigned.
      • Is it possible to keep ghosted text of "Enter a Tag" in the tag entry box when someone is not entering a tag? That way the user knows where that entry area is. Otherwise it's a little subtle. I'll enter a new Jira ticket for it.
      • See wireframe 10 attached.
  8. Scenario 8 [won't make it into Q3; create separate bug for AutosuggestSecondSort per Michal - see FOLIO-1508]
    • Given the Tag Pane text entry box
    • When a user starts typing
    • Then FOLIO should auto-suggest existing options from the FOLIO central tag list, as follows:
      • Start suggesting as soon as the user starts typing, unless performance issues, in which case, start suggesting at 2nd or 3rd character
      • Auto-suggest looks for the typed string no matter where it appears in the existing tag
      • Any existing tags that start with the string should be presented at the top of the list in alphabetical order, followed by existing tags that have the string embedded in them, also in alphabetical order
      • A-M: Autosuggest tag list seems to be in random order, instead of in the order described in this item. See AutosuggestSortOrder screenshot. I'll enter a Jira bug.
      • MK: this should be now fixed and the autosuggestions should be ordered correctly
      • A-M: Close but not quite. See AutosuggestSortOrder2 video. Please let me know if this is do-able or not. The order within autosuggest would be a little different from the order for the regular list (before autosuggest starts acting on it). Let me know if I should enter a Jira bug.
      • A-M: one more tweak - see AutosuggestSecondSort video - is this doable?
      • A-M: Bug/error message sometimes when adding tags. See ErrorWhenAddingTags video.
      • MK: it should be now fixed
      • A-M: Yes, all good now - thanks!
  9. Scenario 9
    • Given the Tag Pane text entry box
    • When a user attempts to type a space or pipe character
    • Then do not advance the cursor. Disallow spaces and the pipe character (|) in tags. [Pipe character will be used to separate multiple tags in data being imported to FOLIO]
    • A-M: solved in a slightly different way; user can type in space or pipe, but those characters are removed before storing.
  10. Scenario 10
    • Given the Tag Pane text entry box
    • When a user attempts to type an upper-case letter
    • Then convert to lower-case
    • A-M: it's saving entries with upper-case letters as separate tags from the same tag using lower-case letters. See UppercaseBug video. I'll add a Jira bug.
    • MK: This should be now fixed. The tags will be always lowercased
    • A-M: Yes, all good now
  11. Scenario 11
    • Given the Tag Pane text entry box
    • When the user sees an appropriate tag in the auto-suggest list
    • Then they should be able to select it by clicking on it or scrolling down to it and pressing Enter, thereby completing the text in the text entry box with the auto-suggestion
  12. Scenario 12 [A-M entered separate Jira bug]
    • Given the Tag Pane text entry box
    • When the user enters text, presses "Enter," and the Tag already exists on the record
    • Then the tag should be highlighted on the screen
    • A-M: the intention was to have the highlighting up in the display of tags already assigned to the record, not in the autosuggest list. See HighlightQuestion video attached. Let me know if I should create a separate Jira for it.
    • A-M: see the HighlightingPart2 video for maybe a better explanation. Please let me know if this is do-able, and if I should enter a new Jira ticket for it
  13. Scenario 13
    • Given the Tag Pane text entry box
    • When the user enters text, presses "Enter," and the Tag does not already exist on the record, but does exist in the Library's central tag list.
    • Then the tag should be added to the record's tag list in the fourth pane.
  14. Scenario 14
    • Given the Tag Pane text entry box
    • When the user enters text, presses "Enter," and the Tag does not already exist in the Library's central tag list.
    • Then the tag should be created as follows
      • Add to the record's tag list in the fourth pane
      • With a red message saying "New tag created"
      • A-M: No "new tag created" message.
      • MK: The callout is now in place and it will appear when the new tag is being added to the central tag list
      • A-M: all good now!
      • Add to the Library's central tag list. Note that in Phase 1, users will not have UI access to the central tag list.
  15. Scenario 15
    • Given the Library's central tag list
    • When a new tag is created
    • Then the new tag should be stored in the central tag list and displayed in an individual record's tags in the same format (with regards to lower-case, spacing, and punctuation), to allow for predictability for the user when outputting or working with the tags.
    • A-M: Fine in the record UI, but there's not really a way to test/review the central tag list. Michal Kuklis Could you confirm it's working properly for the central tag list?
    • MK: Yes this is already happening. You can confirm it by looking at the available options coming from the multi selection component. Every time when you add a new tag that list should grow
    • A-M: yes, all good now. I think the combination of the error message when the system was creating new tags and the random sort order made it hard to confirm yesterday, but easy to confirm today.
  16. Scenario 16
    • Given the Tags Pane
    • When a new tag is assigned to a record
    • Then the number of tags in the Sub-header and the number next to the Tags icon should increase by 1
  17. Scenario 17
    • Given the individual tags in the Tags Pane
    • When a user clicks the "x" for that tag
    • Then the tag should be removed from the record and from the display. Note that unassigning a tag from a record does not delete the tag from the Library's central tag list, even if no other records have that tag assigned.
    • A-M: Bug when deleting tags. Always deletes the first tag, no matter which one you select. See ErrorWhenDeletingTags video. I'll add a Jira bug.
    • MK: This should be now fixed
    • A-M: Yep - all good
  18. Scenario 18
    • Given the Tags Pane
    • When a tag is unassigned from a record
    • Then the number of tags in the Sub-header and the number next to the Tags icon should decrease by 1
  19. Scenario 19 [A-M created separate Jira]
    • Given the individual tags assigned to a record
    • When the users outputs the record (for printing, downloading, delimited, reporting format, etc.)
    • Then output all tags along with the rest of the record
    • A-M: I'll move this to a separate JIra, and block it until records can be exported/printed: UITAG-16 Blocked , UITAG-17 Open


 Comments   
Comment by Cate Boerema (Inactive) [ 09/Apr/18 ]

Great story, Ann-Marie Breaux! I love the detail. A couple comments:

  1. I think scenario 11 is a duplicate of scenario 8
  2. You mention various tag permissions in here, but the way we usually sequence the development work is (1) basic feature implementation without regard to permissions (2) implementation of permissions (at which time you specify what different rights users with the various permissions get). So I would focus this story on what functionality should be expected if you have full permissions. Then move your permission-based scenarios into the permission stories you'll be creating.
  3. Can you just attach the mock-ups to the story instead of this requirements document? The details needed for the development and testing work should be in the user story and I think this additional requirements document will be confusing to wade through and will become a headache to keep in sync with the story. That said, if you really think keeping an overview document is worth the effort of keeping them in sync, you are, of course, free to do that, but if you do it, please put it in a Google doc and then link to it from the story as a "additional documentation: tags requirements overview" or something along those lines.

Thanks!

Comment by Ann-Marie Breaux (Inactive) [ 09/Apr/18 ]

Hi Cate Boerema - I think I've got this one straightened out now. Could you check it one more time? Thank you!

Comment by Cate Boerema (Inactive) [ 12/Apr/18 ]

Looks great! Thanks Ann-Marie Breaux!

Comment by Jakub Skoczen [ 30/Apr/18 ]

Ann-Marie Breaux with the backend in shape for the UI work we need to create an issue for Tagging "smartcomponent". Do we have any other wireframes besides the sketches above?

Comment by Ann-Marie Breaux (Inactive) [ 30/Apr/18 ]

Hi Jakub Skoczen I'm not sure what you mean by tagging smartcomponent. Is that basically what a tag record should look like and the data elements it should include, or how it looks on an individual record, or the actual icon being used for the tag, or something else?

Comment by Jakub Skoczen [ 01/May/18 ]

Ann-Marie Breaux I am referring to the Stripes smart component that will be used for assigning tags. The rough sketch is in the "09-Tag 4th Pane.JPG". There's also '10 Tag Creation.jpg" but I don't understand if this is part of the same component or (as the name indicates) it's related to Tag management.

Let's clarify so that John Coburn can provide some input on how to proceed (do we need a completely new component or can the devs re-use or compose existing ones).

Comment by John Coburn [ 01/May/18 ]

Jakub Skoczen, Ann-Marie Breaux This is a new component - its usage wouldn't be limited to tagging, but any situation where we need multiple selection from potentially long lists of system-known entities.
I've done a bit of work on it already - it needs some tests and some accessibility work - but it's prettymuch "shaped" like the jpg depicts it. Adding STCOM-263 Closed for tracking it.

Comment by Ann-Marie Breaux (Inactive) [ 02/May/18 ]

Hi Jakub Skoczen and John Coburn Picture 9 shows how tags look when displayed on a record. Picture 10 shows what should happen when you start entering text in the "Enter a tag" box at the bottom right of picture 9. Once you start typing, it should start auto-suggesting based on tags already in the central tag list, and the auto-suggest options would decrease as you type more characters into the "Enter a tag" box. At any point, you can select one of the existing auto-suggestions, or (depending on permissions) create/assign a new tag if you get to the point where no auto-suggestions remain.

If it would help to discuss any of this, just let me know. We can find a few minutes to look at it together.

Thank you!

Comment by Cate Boerema (Inactive) [ 10/Jul/18 ]

Hi Ann-Marie Breaux. The team and I were looking for the best starter story for Tags and we thought this was it, but weren't totally sure because of a couple of things we saw here.

  • In scenario 1, you talk about the Tags app. When I think of the Tags app, I think of an app with an icon in the top nav where you can manage Tags. What we want for the first story is just the ability to tag a record. I think if we just tweaked this scenario so it said "Given Enable tags = Y in Settings > Tags > General per FOLIO-1302" this would be a lot clearer
  • Also in scenario 1, you reference Inventory as opposed to Users. Since we are starting with Users, can we change that? There are references to "metadata records" in the purpose, as well.

Otherwise, I think this story looks good. Maybe once you've made these changes you can bump the priority to P2? Same for UITAG-18 Closed .

Thanks!

Comment by Ann-Marie Breaux (Inactive) [ 11/Jul/18 ]

Hi Cate Boerema Thanks for the suggestions. I'll update the issue per your comments, and change the Priority on the 2 issues. True there's no UI for a specificTags app in the first phase, but in conversations with Jakub Skoczen, it sounds like there is an app - even though users can't see it. Same applies to Notes. These Helper Apps may or may not actually have icons in the top App bar. In any event, I think it's only semantics, so no worries.

Comment by Ann-Marie Breaux (Inactive) [ 11/Jul/18 ]

And great to hear that work might be starting soon! If it would be helpful to discuss anything once developers start work, I'm happy to set up any meeting(s) that we may need.

Comment by Michal Kuklis [ 23/Jul/18 ]

Jakub Skoczen and Ann-Marie Breaux I can definitely start on the tags helper app. We will need to get the new component described byJohn Coburn in https://folio-org.atlassian.net/browse/STCOM-263 ready before we can finalize this one.

Comment by Michal Kuklis [ 26/Jul/18 ]

Ann-Marie Breaux here is a little screencast with the progress so far: tags.webm. A lot of parts are still missing but the basics (adding / removing tags) are now in place. The next step will be to incorporate the multi-selection component from STCOM-263 Closed .

Comment by Ann-Marie Breaux (Inactive) [ 30/Jul/18 ]

Hi Michal Kuklis Video looks good! See scenario 9 though - no spaces allowed in tag text strings. Also, I could use your opinion about something. We were going to use the pipe delimiter as a separator for multiple tags in incoming data being loaded to FOLIO. For example, a tag string of new|do-now|fred, would load to folio as 3 separate tags: new do-now and fred

One key partner wants to output a comma as separator instead of pipe. Pipe will be significant development effort that they are not willing to do at this time. Do you think the best path forward is
1) to make the comma an invalid character in tags (and allow the pipe character to be a valid character)
2) have a setting in the batch import loader that allows the library to specify the delimiter that separates multiple values within the same field (seems like overkill of dev effort in the batch loader)
3) something else that you might suggest?

Comment by Michal Kuklis [ 31/Jul/18 ]

Ann-Marie Breaux the tags are stored in the database as an array of strings for example ["foo", "bar", "test"] so I assume when the big list of tags will be imported from another system the backend converter/importer will need to replace "foo|bar|test" or "foo,bar,test" into ["foo", "bar", "test"].
I'm not sure who is writing the converter but I assume 2) shouldn't be too hard to handle and it seems like an ideal solution.

We can do the same on the front end when somebody enters "foo|bar|test" or "foo,bar,test" we can convert those strings into ["foo", "bar", "test"].

Comment by Michal Kuklis [ 31/Jul/18 ]

Ann-Marie Breaux I just fixed the spaces from scenario 9 and also added support for scenario 15 (adding tags to the central repo).

Comment by Michal Kuklis [ 07/Aug/18 ]

Ann-Marie Breaux I just received a new design from Filip Jakobsen and I'm attaching it here.

Comment by Ann-Marie Breaux (Inactive) [ 08/Aug/18 ]

Thanks, Michal Kuklis some of these designs are for Phase 2, not Phase 1, so I need to straighten that out. I'm in meetings all day Weds-Fri this week, so may not be able to get to this until early next week. Do you have other things you're working on as well?

Comment by Filip Jakobsen [ 08/Aug/18 ]

Michal Kuklis, Ann-Marie Breaux, I've asked David García Sánchez to update the specific mockups for this particular issue. Once those are ready, we can remove the many mockups uploaded here, that are only tangentially related to this issue to avoid any confusion. We still have the full set of mockups on hand for general information for anyone working on tags, as contextual information on where the app is going longer term.

Comment by Filip Jakobsen [ 08/Aug/18 ]

By request of Ann-Mari, we will not be changing this issue.

Comment by Michal Kuklis [ 13/Aug/18 ]

Hi everyone. I apologize for the confusion here. Ann-Marie Breaux I have plenty of other work so this can wait for phase 2 for sure.

Comment by Ann-Marie Breaux (Inactive) [ 31/Aug/18 ]

@michal If I can get this story cleaned up by early next week, would you be able to complete it by 14 Sept?

Comment by Michal Kuklis [ 31/Aug/18 ]

Hi Ann-Marie Breaux most of the scenarios are done. I'm currently in the process of replacing the basic text input with the multi selection component. I think we should be able to complete it before September 14th.

Comment by Michal Kuklis [ 05/Sep/18 ]

Ann-Marie Breaux I was able to switch it to the MultiSelection component. Here is a little preview of how this currently works: multi-select-tags.webm

There are couple things which are handled differently:

Scenario #9 - user will be able to type space and pipe (|) but these signs will be removed / cleaned up before they are added to the list
Scenario #12 - this is currently not possible but the MultiSelection does highlight the tags which are already in use.
Scenario #19 - I'm not really sure how this scenario should be handled.

I think ideally it would be nice to perhaps close this story (after we test it) and if we need to improve or change some things we can create new JIRAs. Does that sound good to you?

Thanks!

Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ]

Hi Michal Kuklis That sounds good to me. I'm testing this now. One question about UITAG-18 Closed , which I may have missed or not realized during testing. Is the general tags setting defaulted to enabled/on or disabled/off? When I logged onto snapshot-stable just now, the setting was defaulted to off. I'm not sure if that's because someone messed with it or because that's the default. Per story 3 of UITAG-18 Closed , the default setting should be checked (enabled/on). That way a sysadmin will have to take an action to disable tags for FOLIO, instead of having to take an action to enable them. Let me know if I need to write a quick story to make that adjustment to the default.

Comment by Michal Kuklis [ 11/Sep/18 ]

Ann-Marie Breaux I think the setting is off by default. I worry we won't be able to fix it at it point because I think it will require a server side change. We can file a new JIRA to get it fixed after the release.

Comment by Michal Kuklis [ 11/Sep/18 ]

Ann-Marie Breaux the counter next to the tags and notes icons is currently not supported (Scenario 3). Let's move this to a new JIRA if possible. This will require a bit more work not just around tags I think.

Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ]

No problem, Michal Kuklis. I'll add a Jira for it. See problem with scenario 3 above. Should I write a bug ticket for this one too, instead of moving this issue back to In Progress? I'll keep working through the rest of the scenarios. Thank you!

Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ]

Michal Kuklis Will do. Should the new Jira address the issue for both Tags and Notes, or just Tags?

Comment by Michal Kuklis [ 11/Sep/18 ]

Ann-Marie Breaux Yes I think scenario 3 will require more work to support it for both tags and notes. We also need a UI tweak ideally from Rasmus Wølk to support these kind of counters over icons. I think this will be a larger work so I think creating a new JIRA would be great.

In general I think the functionality under this story works for but I'm sure we can improve it after Q3 release.

Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ]

Hi Michal Kuklis Definitely some bugs that I'll enter, but in general, it's great to see this coming to life! Another question for you: Is it possible to keep ghosted text of "Enter a Tag" in the text entry box when someone is not entering a tag? That way the user knows where that entry area is. Otherwise it's a little subtle. If you think it's possible, I'll enter a new Jira ticket for it.

Comment by Michal Kuklis [ 11/Sep/18 ]

Ann-Marie Breaux thank you for testing this! I should be able to address some of them before the release. I will double test scenario 17 and scenario 8. I should be able to fix those.

The issues in scenario 7 are related to the multi selection component and I worry these may take longer to fix so a separate JIRA would be great.

Comment by Michal Kuklis [ 11/Sep/18 ]

I will see if we can keep the placeholder (ghosted text) around when some tags are already present. If this is a quick change I will add it if not it may need to wait for the multi selection component enhancement.

Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ]

Hi Michal Kuklis see highlight question in scenario 12. Is this do-able? If so, I can create a new Jira for it.

Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ]

And Michal Kuklis I have to stop now for meetings the rest of the day. I'll come back to this later tonight, to finish testing and start adding Jira tickets. Thank you!

Comment by Michal Kuklis [ 11/Sep/18 ]

Ann-Marie Breaux I'm a bit confused about scenario 12. We had something like that before we introduced the multi selection component (the entered tags would show up above the text field).

I'm not sure how scenario 12 should work here with the multi selection component. Are you suggesting that the multi selection component should stay empty and instead we should show the tags above it?

Comment by Michal Kuklis [ 11/Sep/18 ]

Ann-Marie Breaux thanks again for testing it so well. I made couple more changes and fixed some of the bugs you encountered (please see the green comments above). For the rest of them I think we will need separate JIRAs. Most of the remaining issues are related to the multi selection component.

Comment by Ann-Marie Breaux (Inactive) [ 11/Sep/18 ]

Tags are my baby, and it's great to see it coming to life - just have to straighten out the fingers and toes a bit. On a break at the library, and I just spotted these fixes. Thank you so much for jumping on them! I hope to finish the testing later tonight, and will clean up the Jira, plus enter the other tickets for the outstanding work. Thanks for all your help, Michal Kuklis

Comment by Rasmus Wølk [ 12/Sep/18 ]

Michal Kuklis There's a "badgeCount" prop on the IconButton that allows you to add a number next to the label.

More info here: https://ux.folio.org/storybook-draft/?selectedKind=IconButton

Comment by Michal Kuklis [ 12/Sep/18 ]

Oh beautiful Rasmus Wølk! I was not aware of that. I will try to incorporate it here today.

Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ]

Hi Michal Kuklis The tags functionality seems to have disappeared from snapshot-stable, and folio-testing seems to be down, so I'm stuck as far as reviewing any of yesterday's changes. I'll write up some of the bugs from yesterday that have not yet been addressed.

Comment by Michal Kuklis [ 12/Sep/18 ]

Thank you Ann-Marie Breaux. I do see them under: http://folio-snapshot-stable.aws.indexdata.com and it looks like the fixes from yesterday are there.

Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ]

It's there now! I swear 20 minutes ago it wasn't. Thank you!

Comment by Michal Kuklis [ 12/Sep/18 ]

Ann-Marie Breaux np! Also I just added the counters to the tags icon based on the recommendation from Rasmus Wølk.

Rasmus Wølk I do have one question about it. Please see this printscreen:
I see the counters next to the tags icon but the background under the badge stays white. Am I doing something wrong? (I'm not applying any other styles to IconButton). Thanks!

Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ]

Hi Michal Kuklis OK - here's where we stand, I think
I've finished all the testing on this ticket that I can. The changes from yesterday look good - thank you so much!
Outstanding questions on scenarios - lots less than yesterday!
Scenario 3: Looks like you're working on it, so I'll leave it on this story and wait for your confirmation. If necessary, I can move it to a separate story - just let me know.
Scenario 7: I'll move these to a separate story - will just do one bug for all of these problems in scenario 7, unless you tell me to enter separate bugs for each one.
Scenario 8: Please review the question. If do-able, can you fix it in the context of this story, or should I write a separate story? If not do-able, we can consider this resolved.
Scenario 12: Please review the question. If do-able, can you fix it in the context of this story, or should I write a separate story? If not do-able, we can consider this resolved.
Scenario 14: I'll add a Jira bug ticket
Scenario 19: I'll move to a separate ticket

Comment by Michal Kuklis [ 12/Sep/18 ]

Thanks Ann-Marie Breaux!

Scenario 3 is now done (should be available tomorrow) I should be able to fix Scenario 8 today.

Scenarios 7 and 12 will need to wait until we have support for it in multi selection component. Ideally we should create separate JIRAs for them. I'm hoping John Coburn will be able to help us here in the future.

I do have a question about Scenario 14. Where would you like to see the message? Is it ok to show it above the multi selection component? If so I think this will be doable.

Thanks again for testing this Ann-Marie Breaux!

Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ]

Hi Michal Kuklis re: scenario 14 - I think above the multi-select component should be OK. Since the central tag list will quickly be scrolling way down the page, having it at the bottom right of the page, like most badges, would be problematic, right? Attached are a couple "success" badges, one that is totally green, and one that is just a green outline. I think I like the totally green one, if that fits with today's stylings. And it should only display if the tag is new to the central tag list. It should not display if the tag is already in the central tag list, but is being added to this particular record. That way the user has 1) an indication that this is a brand new tag. If they think they are using an existing tag, that might cause them to stop and see if they made a typo. 2) and we're going to have a permission level that allows users to assign existing tags, but not create new tags. Having that "new tag" badge will be one more little visual cue to people who have that create permission verses the users who only have assign permission.

Comment by Michal Kuklis [ 12/Sep/18 ]

Ann-Marie Breaux ah this looks like a callout component which usually shows up at the bottom of the page. This is a very nice idea and I think it should work here very well. Let me give it a try. Good thinking!

Comment by Ann-Marie Breaux (Inactive) [ 12/Sep/18 ]

Comment by Michal Kuklis [ 12/Sep/18 ]

ok Ann-Marie Breaux the sorting from Scenario 8 should be now fixed. Also the Callout from Scenario 14 should be also working. Unfortunately for some reason I applied the correct callout type (success) but the callout stays white (not green) I think we have a bug in the callout component. For now it will stay white.

Comment by Ann-Marie Breaux (Inactive) [ 17/Sep/18 ]

Hi Michal Kuklis I closed scenarios 3 and 14. Will create a separate bug for simultaneous number update for scenario 3.

I added a video illustrating the secondary sort situation for scenario 8. Let me know if you can fix as part of this ticket or if I should enter a separate bug.

Thank you!

Comment by Michal Kuklis [ 17/Sep/18 ]

Thank you Ann-Marie Breaux. The fixes so far should be included in Q3 but the changes I will make today to fix scenario 8 won't be included so I think it would be great to actually create a new bug for it.

Comment by Ann-Marie Breaux (Inactive) [ 17/Sep/18 ]

Hi Michal Kuklis Done - see UITAG-6 Closed . So that finishes this ticket. Everything has been taken care of, or moved to separate Jiras. I'll go ahead and close this one. Virtual champagne!

Comment by Michal Kuklis [ 17/Sep/18 ]

Perfect thank you Ann-Marie Breaux!

Generated at Fri Feb 09 00:08:22 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.