[MODUIMP-10] mod-user-import does not respond when "deactivateMissingUsers" is set Created: 22/Mar/18  Updated: 20/May/20  Resolved: 20/May/20

Status: Closed
Project: mod-user-import
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P4
Reporter: Matt Reno Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: back-end
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint:
Development Team: Prokopovych

 Description   

Users can be imported without "active" being set. In this case, if a subsequent import is performed with "deactivateMissingUsers" set to true, the API will not return.

This is probably due to a NullPointerException in UserImportAPI.deactivateUsers() here:
if (user.getActive()) {
user.setActive(Boolean.FALSE);

Since user.getActive() will likely return null instead of Boolean.TRUE|FALSE, autoboxing will try to change null to a boolean and throw the NPE (at least that is my theory).

Since "active" is not a required field, I would expect it to ignore users without the active field or just force active to false.

Setting "active" for all user imports will cause the API to behave properly when "deactivateMissingUsers" is present.



 Comments   
Comment by Marc Johnson [ 10/Apr/19 ]

Jakub Skoczen Cate Boerema Are we continuing to support mod-user-import? If so, is this the core functional or platform team?

Comment by Cate Boerema (Inactive) [ 03/Jan/20 ]

Marc Johnson, we do want to continue to support mod-user-import as it is used. I think it should probably live with Core Functional since Core Platform is shrinking in 2020.

Comment by Marc Johnson [ 03/Jan/20 ]

Cate Boerema Ok, thanks for confirming that.

Comment by Anton Emelianov (Inactive) [ 20/May/20 ]

closing 12+ month old bugs

Generated at Thu Feb 08 23:11:16 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.