[MODSOURMAN-931] Unexpected parameter property name in /mapping-rules/marc-authority Created: 24/Nov/22  Updated: 30/Mar/23  Resolved: 28/Feb/23

Status: Closed
Project: mod-source-record-manager
Components: None
Affects versions: None
Fix versions: 3.6.1

Type: Bug Priority: TBD
Reporter: Theodor Tolstoy (One-Group.se) Assignee: Pavlo Smahin
Resolution: Done Votes: 0
Labels: back-end, epam-spitfire
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File MODSOURMAN-931_verified_orchid_auth.png     PNG File MODSOURMAN-931_verified_orchid_bib.png    
Issue links:
Blocks
blocks MODSOURMAN-962 Release v3.6.1 (R1 2023 Orchid Bugfix) Closed
Defines
defines UXPROD-3850 NFR : General Spitfire Bugfixes/Tech ... Closed
Sprint: Spitfire Sprint 160
Story Points: 0.5
Development Team: Spitfire
Release: Orchid (R1 2023)
RCA Group: Implementation coding issue

 Description   

Overview:
Steps to Reproduce:

  1. Log into some FOLIO environment as User X
  2. Fetch the bib-mapping rules by issuing a GET request to mapping-rules/marc-bib
  3. Search for occurrences of set_identifier_type_id_by_value
  4. Note the parameter "names" that contains a list of names.
  5. Fetch the authority mapping rules by issuing a GET request to /mapping-rules/marc-authority
  6. Search for occurrences of set_identifier_type_id_by_value

Expected Results:

The parameter should follow the same naming convention, having the name "names"
Actual Results:

The parameter is named "name"
Additional Information:
This makes our data migration scripts crash and is an inconsistency. 

 

Also, it would be good to add some documentation on Identifier type mapping here:
https://github.com/folio-org/mod-source-record-manager/blob/master/RuleProcessorApi.md
Interested parties:



 Comments   
Comment by Theodor Tolstoy (One-Group.se) [ 24/Nov/22 ]

Khalilah Gambrell fyi.

Comment by Ann-Marie Breaux (Inactive) [ 28/Nov/22 ]

Hi Khalilah Gambrell No dev team assigned. I added Spitfire. Please adjust if that's not correct. Thank you!

Comment by Valery_Pilko [ 30/Mar/23 ]

Verified on Orchid Bugfest environment - works as expected
See attached screenshots: 

I'm closing this issue.
cc: Khalilah Gambrell , Theodor Tolstoy (One-Group.se) 

Comment by Theodor Tolstoy (One-Group.se) [ 30/Mar/23 ]

Thank you Valery_Pilko!

Generated at Thu Feb 08 22:22:51 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.