[MODPATRON-40] Unexpected responses from GET /patron/account/<id> WRT the includeCharges query arg Created: 15/Jul/20 Updated: 14/Sep/21 Resolved: 14/Sep/21 |
|
| Status: | Closed |
| Project: | mod-patron |
| Components: | None |
| Affects versions: | 4.2.0 |
| Fix versions: | None |
| Type: | Bug | Priority: | P2 |
| Reporter: | Craig McNally | Assignee: | Kyle Felker |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Environment: |
folio-testing, fameflower production envs |
||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||||||||||||||||||
| Sprint: | Prokopovych - Sprint 123, Prokopovych - Sprint 122, Prokopovych - Sprint 121 | ||||||||||||||||||||||||||||||||||||
| Development Team: | Prokopovych | ||||||||||||||||||||||||||||||||||||
| Affected Institution: |
MO State, Okanagan College
|
||||||||||||||||||||||||||||||||||||
| Description |
|
Overview: NOTE that even when omitting or explicitly setting includeCharges=false, the response includes the total charge information. Steps to Reproduce:
Expected Results:
Actual Results:
Additional Information: $ curl $OKAPI/patron/account/c0d4a2da-7c38-46f4-869c-797bb083ee2d -H "X-Okapi-Token: $TOKEN" -w'\n' { "totalCharges" : { "amount" : 50.0, "isoCurrencyCode" : "USD" }, "totalChargesCount" : 1, "totalLoans" : 0, "totalHolds" : 0, "charges" : [ ], "holds" : [ ], "loans" : [ ] } $ curl $OKAPI/patron/account/c0d4a2da-7c38-46f4-869c-797bb083ee2d?includeCharges=false -H "X-Okapi-Token: $TOKEN" -w'\n' { "totalCharges" : { "amount" : 50.0, "isoCurrencyCode" : "USD" }, "totalChargesCount" : 1, "totalLoans" : 0, "totalHolds" : 0, "charges" : [ ], "holds" : [ ], "loans" : [ ] } $ curl $OKAPI/patron/account/c0d4a2da-7c38-46f4-869c-797bb083ee2d?includeCharges=true -H "X-Okapi-Token: $TOKEN" -w'\n' Not Found This issue must also account for the following:
URL: |
| Comments |
| Comment by Craig McNally [ 15/Jul/20 ] |
|
While the root cause of this is bad data in the account record (See
|
| Comment by Anastasiia Zakharova [ 16/Jul/20 ] |
|
Craig McNally I see this is assigned to Gulfstream with Release:Q2 2020 Hot Fix. What's the priority of this bug? Is it urgent or not? |
| Comment by Matt Reno [ 01/Sep/20 ] |
|
The current plan is to make the "itemId" returned by fees/fines optional instead of using a "0" to indicate the field is not in use. Since an item is not required in the charge schema, the code may just work. The goal would be to have charges with no itemId return without the item field set and the other fields set if in use by FOLIO. See the related JIRA for fees/fines for more info. |
| Comment by Molly Driscoll [ 30/Jul/21 ] |
|
We are receiving reports from a live library that account access in EDS is failing when they have fees/fines on their patron account that do not have a corresponding item. They are unable to view their loans or requests. It seems as if it may be tied to this bug. Are there any plans for a fix and, if so, is there a timeline? Thanks for any info you can provide. cc: Craig McNally and Matt Reno
|
| Comment by Kyle Felker [ 26/Aug/21 ] |
|
I am unable to replicate this issue on snapshot. Procedure I followed: 1. I added a fee of 5.00 to a user account (sheldon bazinga) with no item data. 2. Sent a request for the patron account data to mod-patron: As you can see, the account data is reported in the result (I added a second 3.00 charge the same way just to make sure-that's showing as well): , , , |
| Comment by Debra Howell [ 30/Aug/21 ] |
|
FROM SUPPORT SIG: Should this be closed Craig McNally and Kyle Felker? |
| Comment by Kyle Felker [ 09/Sep/21 ] |
|
I can't replicate and I have no confirmation from anyone else that it's still a problem. So yes? |
| Comment by Molly Driscoll [ 09/Sep/21 ] |
|
Kyle Felker and Craig McNally, do we know which version this would have been resolved in? I have a library on Iris HF#3 that reported this at the end of July. (Though they may have been on HF#2 or HF#1 at that point.) Should I ask them to re-test? |
| Comment by Kyle Felker [ 10/Sep/21 ] |
|
I'm not even sure it has been resolved-all I know is I can't replicate with the provided information. I'd ask them to retest and supply detailed instructions for replicating if it does show up. |
| Comment by Oleksiy_Lemeshko [ 13/Sep/21 ] |
|
Moving it to blocking till further confirmation about it's reproducibility |
| Comment by Molly Driscoll [ 13/Sep/21 ] |
|
Does the following help at all?
|
| Comment by Lisa Sjögren [ 14/Sep/21 ] |
|
Hi! The error However, similar to what Kyle Felker notes, if I try out the call edgeUrl/patron/account/atjohnson@mtmail.mtsu.edu?apikey=edgeKey&includeLoans=true&includeCharges=true&includeHolds=true |
| Comment by Khalilah Gambrell [ 14/Sep/21 ] |
|
Closing as this appears to not be an issue. |