Create, close, cancel, Purchase Orders (UXPROD-1141)

[MODORDERS-528] Trying and failing to open a PO will still create records in Inventory Created: 28/Jun/21  Updated: 05/May/22  Resolved: 08/Oct/21

Status: Closed
Project: mod-orders
Components: None
Affects versions: None
Fix versions: 12.2.0
Parent: Create, close, cancel, Purchase Orders

Type: Bug Priority: P3
Reporter: Kristin Martin Assignee: Andrei Makaranka
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File screenshot-1.png    
Issue links:
Defines
defines UXPROD-3221 Thunderjet - Lotus Enhancements/Bugfixes Closed
Relates
relates to MODORDERS-694 PendingToOpenEncumbranceStrategy is n... Closed
Sprint: ACQ Sprint 124
Story Points: 3
Development Team: Thunderjet
Release: Lotus R1 2022
Tester Assignee: Dennis Bridges
Epic Link: Create, close, cancel, Purchase Orders

 Description   

Overview:
Steps to Reproduce:

  1. Log into FOLIO Iris environment.
  2. Create a new PO and POL.
  3. Create a physical resources.
  4. Say, "Create Instance, Holdings, Items" for a physical resource.
  5. Assign a fund that will fail (I ended up in the wrong FY with no allocations and lacking expense classes).
  6. Try to open PO

Expected Results:

  • The PO will not open. Receive a message like, ""One or more fund distribution(s) on this order can not be encumbered, because there is no current budget."
  • The PO remains in Pending state. There is no link to an Inventory Instance from the POL.
  • No Inventory records are created.**
  • IF there is ever a link between POL and Instance the Title in the POL should display as hyperlink. Otherwise it is difficult to know when records are created that may need to be cleaned up

Actual Results:

  1. The PO will not open. Receive a message like, ""One or more fund distribution(s) on this order can not be encumbered, because there is no current budget."
  2. The PO remains in Pending state. There is no link to an Inventory Instance from the POL.
  3. An Inventory Instance, holdings, and Item have been created
  4. Title is not hyperlink from the POL to the instance.**

Additional Information:
This same thing happened when I tried to bring in a record from the GOBI API and it failed to open. There were still records created in Inventory, but the PO remained in a pending state, and the POL did not hyperlink to the Inventory record. There was no way to tell from the PO that anything was created in Inventory.

Interested parties: Dennis Bridges



 Comments   
Comment by Victoria_Smelova [ 01/Jul/21 ]

To be aligned with data consistency approach.

cc Raman Auramau

 

Comment by Dennis Bridges [ 04/Oct/21 ]

As discussed in grooming we will solve this issue by executing an "Open order check". The following should be validated before we run the Open logic.

  1. Are all budget criteria satisfied for creating/updating encumbrances. Eg. Does the budget have sufficient funds, is it active etc.
  2. Based on "Create inventory" setting, does the order have a valid Instance, location and/or holdings ID for creating inventory records? Are default settings in place for creating instances and items

cc: Damien

Comment by Damien [ 06/Oct/21 ]

Implementation checked with integration test - PR.

Comment by Andrei Makaranka [ 08/Oct/21 ]

Verified via integration tests
https://github.com/folio-org/folio-integration-tests/pull/299

Comment by Siarhei Hrabko [ 08/Oct/21 ]

Cross mudule -API test failed. It seems tests affected by this update

Comment by Damien [ 12/Oct/21 ]

Siarhei Hrabko  I think that issue started with MODORDERS-565 Closed .

Generated at Thu Feb 08 23:26:30 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.