[MODINVSTOR-576] Bulk delete of instance/holdings/items using CQL Created: 09/Oct/19 Updated: 25/Aug/22 Resolved: 22/Aug/22 |
|
| Status: | Closed |
| Project: | mod-inventory-storage |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 25.0.0 |
| Type: | Story | Priority: | TBD |
| Reporter: | Theodor Tolstoy (One-Group.se) | Assignee: | Julian Ladisch |
| Resolution: | Done | Votes: | 0 |
| Labels: | compatibility-breaking | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | CP: sprint 143, CP Sprint 146, CP: sprint 141, CP: sprint 144, CP: Sprint 145, CP: sprint 142 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Release: | Nolana (R3 2022) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
As a systems librarian, I want the DELETE methods in the Inventory API endpoints to support and require CQL in order to make batch operations on Inventory records more safe and useful Background: There are permissions in place in order to prevent these things from happening, so the solution/workaround for
But what this feature could enable, is a great tool for batch deleting things, but at the same time making it harder to make mistakes. Proposal: |
| Comments |
| Comment by Anya [ 12/Jan/22 ] |
| Comment by Aditya Kumar [ 05/Apr/22 ] |
|
Hi Julian Ladisch, I have noticed a very concerning behavior of this API. Please note the query parameter sent by the user. The problem is the API actually doesn't expect any query parameter. Ref doc: Item Storage It still goes ahead and delete all the data in table mod_inventory_storage.item. This case is similar for holdings: Ref doc: Holdings Storage This happened recently with a tenant. |
| Comment by Julian Ladisch [ 05/Apr/22 ] |
|
Aditya Kumar: This is exactly as documented and as described in this issue's description. What do you intend with the comment directed to me?
|
| Comment by Aditya Kumar [ 07/Apr/22 ] |
|
Hi Julian Ladisch, |
| Comment by Marc Johnson [ 01/Jun/22 ] |
|
I think the timing of this is change is unfortunate, coming only 3 days before the feature freeze for 2022 R2. It would be better if these kinds of changes could be made near the beginning of the release cycle. I would rather significant (and especially breaking changes) weren't made this close to the release period. It increases the chances of delaying the module release and that issues will be discovered in the BugFest period rather than in testing activities throughout the development cycle. If this change goes ahead please:
|
| Comment by Jakub Skoczen [ 08/Aug/22 ] |
|
Julian Ladisch will you go ahead and merge now that it is reviewed? |