[MODINVSTOR-449] Default suppress from discovery to no Created: 24/Feb/20 Updated: 11/May/21 Resolved: 03/Mar/20 |
|
| Status: | Closed |
| Project: | mod-inventory-storage |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 19.0.0 |
| Type: | Story | Priority: | P2 |
| Reporter: | Cate Boerema (Inactive) | Assignee: | Bohdan Suprun (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | back-end | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Core: F - Sprint 83 | ||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||||||||||||||
| Development Team: | Prokopovych | ||||||||||||||||||||||||||||||||||||||||||||
| Comments |
| Comment by Julian Ladisch [ 28/Feb/20 ] |
|
This does not make sense unless we either |
| Comment by Bohdan Suprun (Inactive) [ 28/Feb/20 ] |
|
Hi Julian Ladisch, Yes, I've set default:false in the instance schema, so the discoverySuppress will be defaulted to false for all the APIs: instance-storage, instance-batch(sync). See the PR https://github.com/folio-org/mod-inventory-storage/pull/403. |
| Comment by Julian Ladisch [ 02/Mar/20 ] |
|
You are right, I missed that, sorry. |
| Comment by Cate Boerema (Inactive) [ 03/Mar/20 ] |
|
Hi Bohdan Suprun. How should this be tested? Or can we just retest all the UIIN stories that are linked to as "blocked by" this one? |
| Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ] |
|
Hi Cate Boerema, Yes, it is fine to retest all the UI suppress from discovery stories. |
| Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ] |
|
I'll close the story as dev only. |
| Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ] |
|
Cate Boerema, Charlotte Whitt, There is
|
| Comment by Charlotte Whitt [ 03/Mar/20 ] |
|
Sounds all good, thanks Bohdan Suprun. Would we need a similar story as MODINSTOR-449 for Staff suppress (yes and no), and one for Previously held (yes and no)? |
| Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ] |
|
Charlotte Whitt, Yes, you need stories for these properties as well. |
| Comment by Charlotte Whitt [ 03/Mar/20 ] |
|
Bohdan Suprun - I have created:
|