[MODINVSTOR-449] Default suppress from discovery to no Created: 24/Feb/20  Updated: 11/May/21  Resolved: 03/Mar/20

Status: Closed
Project: mod-inventory-storage
Components: None
Affects versions: None
Fix versions: 19.0.0

Type: Story Priority: P2
Reporter: Cate Boerema (Inactive) Assignee: Bohdan Suprun (Inactive)
Resolution: Done Votes: 0
Labels: back-end
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
blocks UIIN-967 Filter Instance records by Suppress i... Closed
blocks UIIN-969 Filter Holdings records by Suppress f... Closed
blocks UIIN-970 Filter Item records by Suppress from ... Closed
Cloners
is cloned by MODINVSTOR-727 Backend work. Default Mark for deleti... Open
Relates
relates to MODINVSTOR-453 Set default value to false for staffS... Closed
relates to MODINVSTOR-454 Set default value to false for previo... Closed
relates to FOLIO-2517 Filtering by optional boolean properties Closed
relates to UIIN-967 Filter Instance records by Suppress i... Closed
Sprint: Core: F - Sprint 83
Story Points: 5
Development Team: Prokopovych

 Comments   
Comment by Julian Ladisch [ 28/Feb/20 ]

This does not make sense unless we either
a) make discoverySuppress a required field or
b) change the POST and PUT endpoints so that they set discoverySuppress to the default value (false) whenever it is missing in the client record.

Comment by Bohdan Suprun (Inactive) [ 28/Feb/20 ]

Hi Julian Ladisch,

Yes, I've set default:false in the instance schema, so the discoverySuppress will be defaulted to false for all the APIs: instance-storage, instance-batch(sync).

See the PR https://github.com/folio-org/mod-inventory-storage/pull/403.

Comment by Julian Ladisch [ 02/Mar/20 ]

You are right, I missed that, sorry.

Comment by Cate Boerema (Inactive) [ 03/Mar/20 ]

Hi Bohdan Suprun. How should this be tested? Or can we just retest all the UIIN stories that are linked to as "blocked by" this one?

+ Charlotte Whitt

Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ]

Hi Cate Boerema,

Yes, it is fine to retest all the UI suppress from discovery stories.

Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ]

I'll close the story as dev only.

Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ]

Cate Boerema, Charlotte Whitt,

There is UIIN-968 Closed (Filter Instance records by Staff suppress: No) which marked as blocked, please note that staff suppress is not covered by this story, will remove the link if that's fine.

Comment by Charlotte Whitt [ 03/Mar/20 ]

Sounds all good, thanks Bohdan Suprun.

Would we need a similar story as MODINSTOR-449 for Staff suppress (yes and no), and one for Previously held (yes and no)?

Comment by Bohdan Suprun (Inactive) [ 03/Mar/20 ]

Charlotte Whitt, Yes, you need stories for these properties as well.

Comment by Charlotte Whitt [ 03/Mar/20 ]

Bohdan Suprun - I have created:

  • MODINVSTOR-453 Closed Create migration script to ensure that Staff suppress is always yes or no
  • MODINVSTOR-454 Closed Create migration script to ensure that Previously held is always yes or no
Generated at Thu Feb 08 23:20:52 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.