[MODINVOICE-391] Failed save when trying to apply an acquisitions unit or invoice note to a paid invoice Created: 14/Apr/22  Updated: 20/Sep/22  Resolved: 21/Jun/22

Status: Closed
Project: mod-invoice
Components: None
Affects versions: None
Fix versions: 5.4.0

Type: Bug Priority: P2
Reporter: Molly Driscoll Assignee: Dennis Bridges
Resolution: Done Votes: 0
Labels: known-issue-lotus, support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File successful.png     PNG File successful_snapshot.png    
Sprint: ACQ Sprint 142
Story Points: 1
Development Team: Thunderjet
Release: Morning Glory (R2 2022)
Potential Workaround: There is no workaround here other than applying the Acquisition unit prior to paying the invoice. The understanding is that this is needed to correct mistakes in the workflow. For that reason it has been given P2 priority.
Affected Institution:
MI State University/Library of Michigan
RCA Group: Lack of testing

 Description   

Overview: If a library needs to add an acquisitions unit to a failed invoice, this field is editable on the paid invoice. However, when attempting to save, the user receives the error: "Invoice has not been saved"

Steps to Reproduce:

  1. Log into https://bugfest-lotus.int.aws.folio.org/
  2. Go to Settings > Acquisitions units and add your user to an acq unit
  3. Open the invoices app
  4. Filter to Status = Paid
  5. Select an invoice that does not have an acquisition unit applied
  6. Click Actions > Edit
  7. Add your acquisitions unit to the Invoice
  8. Click Save & close

Expected Results: The invoice is saved with a green toast message and the acquisitions unit applied.

Actual Results: The invoice is not saved with a UI error of "Invoice has not been saved".

The error in Developer tools is:

{
"errors" : [

{ "message" : "Cannot pay an invoice without approval", "code" : "cannotPayInvoiceWithoutApproval", "parameters" : [ ] }

],
"total_records" : 1
}

Additional Information: This was originally reported by Michigan State University Law Library (live on Kiwi HF#2) and I have since replicated on both Kiwi and Lotus Bugfest. Labeling a P1 as there is not a workaround that I am aware of.

URL:
Interested parties: Kay Granskog Lisa Smith Shawn Nicholson



 Comments   
Comment by Mikita Siadykh [ 14/Apr/22 ]

Dennis Bridges
similar issue was in https://folio-org.atlassian.net/browse/MODINVOICE-377

is it P1?

cc Andrei Makaranka

Comment by Dennis Bridges [ 14/Apr/22 ]

Mikita Siadykh I have down graded to P2 as I believe this issue has existed for multiple releases and does not block a workflow. Rather, it is needed to correct mistakes that will inevitably be made during the workflow.

We will not pursue a hotfix release for this issue if it cannot be resolved for Lotus bug fix but it should take priority over MG work if there is a change we can deliver a fix for Lotus. thx!

Comment by Mikita Siadykh [ 14/Apr/22 ]

Dennis Bridges SGTM, additionally other fields should be reviewed as well when user tries to edit paid invoice, I guess there are other except tags and acq units 

Comment by Molly Driscoll [ 14/Apr/22 ]

Request URL for the error: https://okapi-bugfest-lotus.int.aws.folio.org/invoice/invoices/2c11e5ce-52f7-430e-9145-685db57559e1

Comment by Anya [ 18/Apr/22 ]

Support: Dennis Bridges what is the target fix date or is this a workflow issue that can be solved in a different way? Is this an enhancement or a bug? 

Comment by Anya [ 25/Apr/22 ]

Support: Dennis Bridges what is the target fix date or is this a workflow issue that can be solved in a different way? Is this an enhancement or a bug? 

Comment by Dennis Bridges [ 25/Apr/22 ]

Support, this was deferred to Morning Glory as we did not have capacity to complete for Lotus. 

As a workaround I might suggest tagging these invoices so that they can more easily be updated after the MG release.

cc: Anya

Comment by Dzmitry Butramyou [ 15/Jun/22 ]

Verified on local env

Comment by Dzmitry Butramyou [ 17/Jun/22 ]

Verified on snapshot env

Comment by Dennis Bridges [ 21/Jun/22 ]

Test successful in folio-snapshot.

Generated at Thu Feb 08 22:22:27 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.