[MODAT-5] Add health check for authtoken-module Created: 21/Feb/17  Updated: 18/Oct/21  Resolved: 18/Oct/21

Status: Closed
Project: mod-authtoken
Components: None
Affects versions: None
Fix versions: 2.9.0

Type: New Feature Priority: P4
Reporter: Hongwei Ji Assignee: Kurt Nordstrom
Resolution: Done Votes: 0
Labels: for-next-sprint
Remaining Estimate: Not Specified
Time Spent: 1 hour
Original estimate: Not Specified

Sprint:

 Description   

Currently authtoken-module does not provide a health check endpoint. It would be nice to have one and be consistent with other RMB based modules (/admin/health).



 Comments   
Comment by Kurt Nordstrom [ 10/May/17 ]

So a question about this implementation. Possible somebody on the Okapi team (Heikki Levanto, Adam Dickmeiss)? might have thoughts.

Currently, the RMB exposes its health check at /admin/health

The issue with the way the authtoken module is implemented is that it proxies all endpoints from Okapi. If we have it give special behavior at the /admin/health endpoint, this would mean that if, for some reason, a module in the system registers at /admin/health, then the health check for the authtoken module will mask this module's proxy.

Should it perhaps listen on an endpoint that won't ever be a valid proxy, such as /_/admin/health?

Comment by Heikki Levanto [ 11/May/17 ]

There is a serious disconnect with all RMB modules providing an /admin endpoint, and Okapi requiring that each endpoint matches one module.

I am thinking about a solution where Okapi can broadcast requests to all modules that implement a given endpoint, or some selected modules, or some selected instances of those modules. I have written about that in Okapi-305. But nothing has been coded yet.

Comment by Kurt Nordstrom [ 11/May/17 ]

It's not terrible if we consider that the modules will be accessed directly by the resource manager, as opposed to through Okapi, but perhaps this is part of a larger conversation that needs to happen.

Generated at Thu Feb 08 23:06:06 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.