[MODAES-6] Upgrade mod-aes to the latest Vert.x Created: 22/Apr/20 Updated: 30/Apr/20 Resolved: 30/Apr/20 |
|
| Status: | Closed |
| Project: | ARCHIVED: mod-aes |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 0.0.2 |
| Type: | Story | Priority: | TBD |
| Reporter: | Matt Reno | Assignee: | Matt Reno |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: |
| Description |
|
The current release of mod-aes is using Vert.x 3.5.4. There have been many improvements in Vert.x since that release and several around the Kafka client, including fixing at least one security vulnerability. We should update Vert.x, which will require code changes as well as features we use are now deprecated. As part of this refactor, we should also switch to Log4j2 and away from the soon to be internal only Vert.x logging framework. This way we can take advantage of the garbage free logger as well as being able to isolate potentially costly logging code, like this, into a lambda. This:
JsonObject data = collectData(ctx);
String msg = data.encodePrettily();
logger.trace(msg);
becomes something like:
JsonObject data = collectData(ctx);
logger.trace(() -> data.encodePrettily());
|