[MGRTENANT-10] Allow underscore in tenant names Created: 01/Feb/24 Updated: 06/Feb/24 |
|
| Status: | In Review |
| Project: | mgr-tenants |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Story | Priority: | P1 |
| Reporter: | Craig McNally | Assignee: | Pavel Filippov |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | back-end, epam-eureka, eureka-phase4 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue links: |
|
||||||||
| Sprint: | Eureka Sprint 45 | ||||||||
| Story Points: | 1 | ||||||||
| Development Team: | Eureka | ||||||||
| RCA Group: | TBD | ||||||||
| Description |
OverviewPresently, tenant names are restricted to the following pattern: {{[a-z][a-z0-9] {0,30}}}. This is too restrictive for naming conventions used by FSE.There are naming restrictions in Keycloak and Postgres. The restriction in the manager components need to take both of these into consideration * Keycloak: The Realm name must not contain spaces, or any special character other than "_" or "-". * Postgres: _ is allowed, - and spaces are not. Length must be < 64 bytes h2. Approach Adjust the naming convention to allow underscores in tenant names, as these are allowed in both Keycloak and Postresql. With this, FSE can continue to use existing naming conventions. * Old Pattern: {{[a-z][a-z0-9]{0,30} }}
Acceptance Criteria
Additional Info/LinksSee https://folio-org.atlassian.net/wiki/display/TC/DR-000002+-+Tenant+Id+and+Module+Name+Restrictions. In pages linked from here, a potential name clash is described, but it seems highly unlikely to happen unless tenants use suffixes like _mod or _edge and modules which don't use the standard mod- or edge- name prefix. If needed, we can consider adding checks for these to mgr-tenants to prevent this from happening. |
| Comments |
| Comment by Yauhen Viazau [ 05/Feb/24 ] |
|
Tested on “evrk“ environment - works as expected A tenant with one or multiple “_“ in the name can be successfully created. See screencast with an example: Note: tenant names with an underscore at the beginning or an end of a name are not allowed, as per pattern in ticket description |