Batch Importer (Bib/Acq) (UXPROD-47)

[LIQUTIL-17] Pass exceptions, don't catch and swallow them Created: 15/Feb/22  Updated: 21/Feb/22  Resolved: 16/Feb/22

Status: Closed
Project: liquibase-util
Components: None
Affects versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.2.1
Fix versions: 1.4.0
Parent: Batch Importer (Bib/Acq)

Type: Bug Priority: P3
Reporter: Julian Ladisch Assignee: Julian Ladisch
Resolution: Done Votes: 0
Labels: data-import, epam-folijet
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
blocks RMB-895 mod-srs: Upgrade (when liquibase exce... Closed
Defines
defines UXPROD-3262 NFR: Data Import R1 2022 Lotus Techni... Closed
Relates
relates to MODSOURCE-380 Exception when upgrading from Iris to... Closed
relates to MODSOURCE-381 Source Record Storage upgrade fails w... Closed
Sprint: CP: sprint 134
Story Points: 0
Development Team: Core: Platform
Release: Lotus R1 2022
Epic Link: Batch Importer (Bib/Acq)
RCA Group: Implementation coding issue

 Description   

LiquibaseUtil catches exceptions, logs them, but swallows (ignores) them so that the caller assumes that the method succeeded successfully:

https://github.com/folio-org/folio-liquibase-util/blob/v1.3.0/src/main/java/org/folio/liquibase/LiquibaseUtil.java#L46

https://github.com/folio-org/folio-liquibase-util/blob/v1.3.0/src/main/java/org/folio/liquibase/LiquibaseUtil.java#L64

See these reports of silent liquibase fails:

RMB-895 Closed
MODSOURCE-380 Closed
MODSOURCE-381 Closed

LiquibaseUtil should pass on all exceptions. Checked exceptions should be wrapped as unchecked exceptions to avoid a breaking change of the method declaration.



 Comments   
Comment by Julian Ladisch [ 15/Feb/22 ]

@ folijet: Please code review and merge this pull request, I don't have write permissions for this repository: https://github.com/folio-org/folio-liquibase-util/pull/14

 

Comment by Ann-Marie Breaux (Inactive) [ 16/Feb/22 ]

Hi Kateryna Senchenko Please see above comment - thank you!

Comment by Kateryna Senchenko [ 16/Feb/22 ]

Hi Julian Ladisch, thank you! PR is merged

Comment by Julian Ladisch [ 16/Feb/22 ]

Thanks!

Generated at Thu Feb 08 22:13:33 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.