Batch Importer (Bib/Acq)
(UXPROD-47)
|
|
| Status: | Closed |
| Project: | liquibase-util |
| Components: | None |
| Affects versions: | 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.2.1 |
| Fix versions: | 1.4.0 | Parent: | Batch Importer (Bib/Acq) |
| Type: | Bug | Priority: | P3 |
| Reporter: | Julian Ladisch | Assignee: | Julian Ladisch |
| Resolution: | Done | Votes: | 0 |
| Labels: | data-import, epam-folijet | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||
| Sprint: | CP: sprint 134 | ||||||||||||||||||||||||||||
| Story Points: | 0 | ||||||||||||||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||||||||||||||
| Release: | Lotus R1 2022 | ||||||||||||||||||||||||||||
| Epic Link: | Batch Importer (Bib/Acq) | ||||||||||||||||||||||||||||
| RCA Group: | Implementation coding issue | ||||||||||||||||||||||||||||
| Description |
|
LiquibaseUtil catches exceptions, logs them, but swallows (ignores) them so that the caller assumes that the method succeeded successfully: See these reports of silent liquibase fails:
LiquibaseUtil should pass on all exceptions. Checked exceptions should be wrapped as unchecked exceptions to avoid a breaking change of the method declaration. |
| Comments |
| Comment by Julian Ladisch [ 15/Feb/22 ] |
|
@ folijet: Please code review and merge this pull request, I don't have write permissions for this repository: https://github.com/folio-org/folio-liquibase-util/pull/14
|
| Comment by Ann-Marie Breaux (Inactive) [ 16/Feb/22 ] |
|
Hi Kateryna Senchenko Please see above comment - thank you! |
| Comment by Kateryna Senchenko [ 16/Feb/22 ] |
|
Hi Julian Ladisch, thank you! PR is merged |
| Comment by Julian Ladisch [ 16/Feb/22 ] |
|
Thanks! |