[FOLIO-989] Add mod-codex-mux to blackbox builds Created: 15/Dec/17 Updated: 12/Nov/18 Resolved: 15/Dec/17 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | Continuous Integration |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P2 |
| Reporter: | Wayne Schneider | Assignee: | Wayne Schneider |
| Resolution: | Done | Votes: | 0 |
| Labels: | ci, sprint28 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 2 hours, 30 minutes | ||
| Original estimate: | Not Specified | ||
| Sprint: |
| Comments |
| Comment by Wayne Schneider [ 15/Dec/17 ] |
|
I think this will require that all modules with a codex interface (including mod-codex-mux) have an "interfaceType": "multiple" key on the interface – is that correct, Adam Dickmeiss? If so, the module descriptor template for mod-codex-mux, mod-codex-inventory, and mod-codex-mock all need to be updated. I can file issues in each project if needed. |
| Comment by Adam Dickmeiss [ 15/Dec/17 ] |
|
Not mod-codex-mux. The UI will use codex and that will be the one that provides it. I think mod-codex-mock is already updated. |
| Comment by Adam Dickmeiss [ 15/Dec/17 ] |
|
mock provides 3 MDs two of which has multiple and one is standard ( https://github.com/folio-org/mod-codex-mock/blob/master/descriptors/ModuleDescriptor-template.json ) |
| Comment by Wayne Schneider [ 15/Dec/17 ] |
|
But only the standard one is posted to the registry: http://folio-registry.aws.indexdata.com/_/proxy/modules/mod-codex-mock-1.0.1-SNAPSHOT.14 So if the mux module provides the only "standard" codex interface, and all others are interfaceType "multiple", the UI doesn't have to supply the X-Okapi-Module-Id header? |
| Comment by Adam Dickmeiss [ 15/Dec/17 ] |
|
Exactly, Wayne Schneider. |
| Comment by Adam Dickmeiss [ 15/Dec/17 ] |
|
Yep. So mod-codex-mock's standard ModuleDescriptor-template.json needs updating. I'll do that. |
| Comment by Adam Dickmeiss [ 15/Dec/17 ] |
|
Want me to release mod-codex-mock or is taking from master/snapshot OK? |
| Comment by John Malconian [ 15/Dec/17 ] |
|
snapshots should be fine |
| Comment by Wayne Schneider [ 15/Dec/17 ] |
|
mod-codex-mux has been added to the "testing" builds (Vagrant boxes folio/testing and folio/testing-backend, and folio-testing.aws.indexdata.com). It won't get pulled into the "snapshot" builds until ui-search updates its interface requirement (currently it requires v1 of the codex interface, so it pulls in an older version of mod-codex-mock). In my testing, ui-search appears to work fine with mod-codex-mux in front of mod-codex-mux, even though the interface version has changed. |