[FOLIO-982] Get Frontside's ui-eholdings running on folio-testing Created: 12/Dec/17 Updated: 12/Nov/18 Resolved: 18/Jan/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P2 |
| Reporter: | Mike Taylor | Assignee: | John Malconian |
| Resolution: | Done | Votes: | 0 |
| Labels: | alpha, ci, sprint28, sprint29, sprint30 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 2 hours | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||
| Sprint: | |||||||||||||||||||||
| Description |
|
And add it to 'folio-sample-platform'. |
| Comments |
| Comment by Mike Taylor [ 13/Dec/17 ] |
|
Note: this is important for the Codex work, because once I am getting Codex records from the EBSCO KB Codex provider, I'll need to use their id and source to link into the Frontside ui-eholdings app. |
| Comment by Mike Taylor [ 13/Dec/17 ] |
|
Related: I will need to have the EBSCO KB Codex provider running on our FOLIO installation – ideally within the folio-testing-backend VM – in order to have its output included in that of the Codex multiplexer. John Malconian, can you please point me at the Jira issue for getting mod-codex-ekb running ? And Wayne Schneider, do you have an issue for adding it to the VM? |
| Comment by Mike Taylor [ 13/Dec/17 ] |
|
I think is more likely to fall into Wayne Schneider's bailiwick than John Malconian's. |
| Comment by Jakub Skoczen [ 19/Dec/17 ] |
|
Charles Lowell We have discussed that this involves moving ui-eholdings and mod-ebsco-kb to folio-org GitHub. Is that something you will be looking at? |
| Comment by John Malconian [ 10/Jan/18 ] |
|
Having issues adding the module to the Stripes 'folio-testing-platform' (https://github.com/folio-org/folio-testing-platform). 'yarn install' exits with the following error: [4/4] Building fresh packages...
verbose 30.099 Error: /home/jenkins/folio-testing-platform/node_modules/@folio/eholdings: Command failed.
Exit code: 1
Command: bin/link-self
Arguments:
Directory: /home/jenkins/folio-testing-platform/node_modules/@folio/eholdings
Output:
ln: failed to create symbolic link 'node_modules/@folio/eholdings': No such file or directory
at MessageError (/usr/lib/node_modules/yarn/lib/cli.js:139:5)
at ProcessTermError (/usr/lib/node_modules/yarn/lib/cli.js:158:1)
at ChildProcess.proc.on (/usr/lib/node_modules/yarn/lib/cli.js:29991:15)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:920:16)
at Socket.<anonymous> (internal/child_process.js:351:11)
at emitOne (events.js:96:13)
at Socket.emit (events.js:188:7)
at Pipe._handle.close [as _onclose] (net.js:497:12)
error /home/jenkins/folio-testing-platform/node_modules/@folio/eholdings: Command failed.
Exit code: 1
Command: bin/link-self
Arguments:
Directory: /home/jenkins/folio-testing-platform/node_modules/@folio/eholdings
Output:
ln: failed to create symbolic link 'node_modules/@folio/eholdings': No such file or directory
'link-self' is a shell script included in the bin directory of the eholdings package ans is specified in the module's "scripts": { "postinstall": "bin/link-self", ... When it is invoked, the directory, node_modules, does not exist in 'folio-testing-platform/node_modules/@folio/eholdings' |
| Comment by Mike Taylor [ 11/Jan/18 ] |
|
How are you getting @folio/eholdings into the build? Are you installing it from an NPM package, using yarn link from your platform, or some other approach? IIRC I got ui-eholdings running locally a while back using yarn link. It was 100% useless because it couldn't talk to an EBSCO KB, but it was at least running to the point where it was able to tell me that. |
| Comment by John Malconian [ 11/Jan/18 ] |
|
NPM package like all other builds. Clone folio-testing-platform, add the module to package.json and stripes.config.js and run 'yarn install' at the top-level directory. I shouldn't have to do any linking. |
| Comment by Mike Taylor [ 11/Jan/18 ] |
|
I've never found that there even is a release of that package: ringo:stripes-sample-platform mike$ yarn add @folio/eholdings yarn add v0.24.6 [1/4] Resolving packages... error An unexpected error occurred: "https://repository.folio.org/repository/npm-folio/@folio%2finventory: Package '@folio/inventory' not found". info If you think this is a bug, please open a bug report with the information provided in "/Users/mike/git/folio/stripes/stripes-sample-platform/yarn-error.log". info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command. ringo:stripes-sample-platform mike$ |
| Comment by John Malconian [ 11/Jan/18 ] |
|
They snapshot releases are built by Jenkins and are located in the FOLIO CI repo - npm-folioci |
| Comment by Mike Taylor [ 11/Jan/18 ] |
|
Oh, yes, of course, folioci. |
| Comment by John Malconian [ 11/Jan/18 ] |
|
Updated https://folio-org.atlassian.net/browse/STRIPES-494 and assigned to Jeffrey Cherewaty at Frontside. |
| Comment by John Malconian [ 18/Jan/18 ] |
|
Completed. eholding now included in current instance of http://folio-testing.aws.indexdata.com. Will be included in the Vagrant image during next scheduled build tonight. |