[FOLIO-937] Design and implement "CODEX Instance" multiplexer module Created: 16/Nov/17 Updated: 12/Nov/18 Resolved: 22/Dec/17 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Jakub Skoczen | Assignee: | Adam Dickmeiss |
| Resolution: | Done | Votes: | 0 |
| Labels: | alpha, core, sprint27, sprint28 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 7 hours | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||||||
| Description |
|
In
While
Requirements
Interface Implementation Time is of essence. The module first and foremost use case is to merge Instance data and as such it's okay to keep it specific to this particular schema, especially if it simplifies the implementation. If it makes sense, we would like to utilize the "multiple" interface feature of Okapi. The multiplexer module would be the singleton implementator of this interface. https://github.com/folio-org/raml/tree/master/examples/codex |
| Comments |
| Comment by Jakub Skoczen [ 16/Nov/17 ] |
|
Adam Dickmeiss Heikki Levanto Guys, please look and discuss this issue and ping me if you have any question or want to chat. I'd like to make this a priority for one of you for next week. Thanks! |
| Comment by Heikki Levanto [ 21/Nov/17 ] |
|
We can get pretty far without Okapi-418. It means we may have to repeat the interface in the ModuleDescriptors, but that is not very hard to do. It will be easy to change those to refer to a specifically defined InterfaceDescriptor when we get that far. No need to let that slow us down at this point. |
| Comment by Khalilah Gambrell [ 28/Nov/17 ] |
|
Hey all - question |
| Comment by Adam Dickmeiss [ 07/Dec/17 ] |
|
The sort order for identical sort keys is in target-order.. Ie the way that modules are returned from Okapi.. So it will "always" show instance 1 from first returned module and instance 2 from 2nd returned module if they have the same sort key.. Such as title. We don't merge them or anything like that. |
| Comment by Adam Dickmeiss [ 07/Dec/17 ] |
|
In your exampe Khalilah Gambrell. .. Suppose 20 results have same title - 10 from each, then it would show 10 from first one (Inventory) and next 10 from eHoldings.. Again provided they all have exact same title. |
| Comment by Khalilah Gambrell [ 07/Dec/17 ] |
|
Thanks Adam Dickmeiss |
| Comment by Adam Dickmeiss [ 22/Dec/17 ] |
|
Closing now. From now one, new issues with specific improvements,, eg
|