[FOLIO-929] Don't fail CI build based on ESLint errors for front-end components Created: 08/Nov/17 Updated: 12/Nov/18 Resolved: 13/Nov/17 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P2 |
| Reporter: | John Malconian | Assignee: | John Malconian |
| Resolution: | Done | Votes: | 0 |
| Labels: | ci, sprint26 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 1 hour | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||
| Sprint: | |||||||||
| Description |
|
Post ESLint errors to PR comments and don't fail CI build if lint errors are present. Enforce successful PR Merge/CI build before merging to master. |
| Comments |
| Comment by John Malconian [ 08/Nov/17 ] |
|
ESLint change merged into master branch pipeline shared libs. Holding off on enabling enforcement of successful PR Merge/CI build (a GitHub configuration option) until the change has been running for a few days. |
| Comment by John Malconian [ 10/Nov/17 ] |
|
Not-failing-builds-due-to-ESLint-errors has been fully-implemented. Enabled 'require status checks to pass before merging' for pr-merge on ui-requests and ui-users. Let's see how that goes before enabling this option on all repos. |
| Comment by John Malconian [ 10/Nov/17 ] |
|
Also configured for ui-circulation and stripes-smart-components. |
| Comment by John Malconian [ 13/Nov/17 ] |
|
stripes-components, stripes-core, ui-instances, ui-items, stripes-connect, ui-organization, ui-checkout now require status checks to pass before merging' for pr-merge. |