[FOLIO-879] Add notes.domain.all permission for diku_admin in blackbox Created: 04/Oct/17 Updated: 12/Nov/18 Resolved: 09/Oct/17 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | Continuous Integration |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P2 |
| Reporter: | Wayne Schneider | Assignee: | Wayne Schneider |
| Resolution: | Done | Votes: | 0 |
| Labels: | ci, sprint23, sprint24 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 1 hour | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||
| Sprint: | |||||||||
| Description |
|
Recent permissions changes in mod-notes have caused some breakage. |
| Comments |
| Comment by Wayne Schneider [ 04/Oct/17 ] |
|
Despite various attempts to give the admin user the correct permissions, I was unable to get this working. Heikki Levanto – can you help me figure out what permissions need to be defined in mod-permissions, and which need to be granted to a user, in order to make this work? |
| Comment by Heikki Levanto [ 05/Oct/17 ] |
|
Oh, don't use the latest from git. It passes the tests, but the permissions will not work well until mod-authtoken / mod-permissions will handle wildcards in desiredPermissions, see
For now, you should be able to get away with granting the 'notes.domains.all' permission to diku-admin, and to everyone who needs to operate on notes. I just added it to the MD (in master) I hope to release 2.0 this week, with permissions and user names in place. Notification stuff can come in 2.1, without changing the interface. I will need to write something about the permissions in the readme, and make some sort of integration test. |
| Comment by Wayne Schneider [ 05/Oct/17 ] |
|
Should be resolved by recent changes in mod-notes (https://github.com/folio-org/mod-notes/commit/1a24948566d9982627549499b448df5fca9eac57). |
| Comment by Heikki Levanto [ 10/Oct/17 ] |
|
Yesterday I merged new stuff in the master of mod-notes. The most important thing is a script, run.sh that sets up the whole Okapi stack, with auth and permissions, one user on one tenant, with the right permission (notes.domain.all). I hope that helps. |