[FOLIO-844] integrate SonarQube test coverage into PR verification Created: 19/Sep/17  Updated: 12/Nov/18  Resolved: 03/Oct/17

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P2
Reporter: Jakub Skoczen Assignee: John Malconian
Resolution: Done Votes: 0
Labels: ci, montreal, sprint23
Remaining Estimate: Not Specified
Time Spent: 6 hours
Original estimate: Not Specified

Issue links:
Relates
relates to FOLIO-1049 Reject pull request if new code doesn... Open
relates to FOLIO-843 require reviewers for PRs Closed
relates to OKAPI-430 Fix code smells for MainCluster Closed
Sprint:

 Description   

We decided during the plenary session that we would like to ensure that new commits (not refactors) come with test coverage and it seems that SQ can give us a measure of whether the coverage level drops below a certain point with the new commit. We want to first establish the coverage levels and review SQ reports for existing project before we make any decisions to move forward with this.

Project integrated so far:

  • okapi


 Comments   
Comment by Jakub Skoczen [ 26/Sep/17 ]

We will keep this open until all projects are integrated.

Comment by John Malconian [ 02/Oct/17 ]

Sonarqube analysis and feedback is now enabled on pull requests for all server side FOLIO components now. The front-end has opted out and instead has chosen eslint ( FOLIO-845 Closed ). There is a GitHub setting that can be enabled which will enforce that all checks have passed before merging to 'master' branch. I have not YET enabled this until devs get a little used to seeing and dealing with the Sonarqube checks.

Generated at Thu Feb 08 23:08:44 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.