[FOLIO-829] Implement classic-jekyll-theme for dev.f.o phase 2 Created: 11/Sep/17 Updated: 11/Jan/19 Resolved: 11/Jan/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | David Crossley | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | devweb | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||
| Sprint: | |||||||||
| Description |
|
Implement the Balancingrock/classic-jekyll-theme. See investigation in
|
| Comments |
| Comment by Peter Murray [ 12/Sep/17 ] |
|
David Crossley – are you working with Patricia DeStefano on these changes? I know she was looking at re-theming as well. |
| Comment by Patricia DeStefano [ 12/Sep/17 ] |
|
Yes, I am working on re-theming as well. I was just about finished my 3rd branch with 3 options for everyone to look over- one branch with just the common nav bar, one branch with the common nav bar & a 2nd nav bar, and lastly, one branch with with a common nav bar, 2nd dev nav bar & left hand navigation. Then, Peter Murray & I met with the EBSCO marketing web team and other partners. The EBSCO marketing web team also looked over dev.folio.org. They had some recommendations as well. Once I hear back from them to verify how to accommodate the team's recommendations, I can post the top navigation recommendation (it has changed...) in
|
| Comment by David Crossley [ 13/Sep/17 ] |
|
Peter, yes. Patti is a Watcher on these issues. I have been making my changes available via these issues and seeking feedback. The
Over recent months i have been gradually improving the site (already done initial basic top navigation bar and topic sections in
All intending to provide a framework to accommodate the recommendations to come from the related wider explorations. |
| Comment by Patricia DeStefano [ 13/Sep/17 ] |
|
Sounds good David Crossley. It is nice to have several options to work with or combine into one solution. I am working towards a POC with a navigation solution as well. I was able to show Peter Murray what I was working towards at our meeting. I was just about ready to check everything into my fork, but the top nav changed again...so, I am adding the changes to my POC. I checked with the marketing group to verify again and have attached the latest top nav to
|
| Comment by David Crossley [ 14/Sep/17 ] |
|
Thanks for the progress update. (I am not sure where higher-level comments should be added.) |
| Comment by David Crossley [ 14/Sep/17 ] |
|
Because this classic-jekyll-theme is not one of the listed github-pages automatically supported themes, its theme files need to be copied and included. Later, when we build and deploy the site differently (
Your PoC seems to be close now. I am going to wait with merging this, until we are more confident that this theme is a suitable framework. |
| Comment by David Crossley [ 15/Sep/17 ] |
|
Wow. The responsiveness of the theme developer is inspiring. See note today in
I am going to proceed. It would be good to have this next stage of improvement to be ready for next week's developer meeting. Then we can follow on more leisurely to assess and integrate your PoC. |
| Comment by David Crossley [ 05/Dec/17 ] |
|
Now using the jekyll-remote-theme ability of Jekyll. Apart from the normal configuration files for this theme, we also maintain copies of two actual theme files in the _includes directory. See pull/115. |
| Comment by David Crossley [ 18/Dec/17 ] |
|
Now using the upcoming version 2 of classic-jekyll-theme. (Pinned to the current version of classic-jekyll-theme dev/@afb9c24) Apart from the normal configuration files for this theme, we also maintain copy of one actual theme file: _includes/banner-area.html to include our extra menubar. See other notes in
|
| Comment by David Crossley [ 29/Dec/17 ] |
|
Pinned to the current release version 2.0.0 of classic-jekyll-theme. |
| Comment by David Crossley [ 24/Jan/18 ] |
|
Merged the branch
There is no re-arrangement of content yet. |
| Comment by David Crossley [ 11/Jan/19 ] |
|
Done. This theme is implemented. The fixed banner was removed in
|