[FOLIO-733] stripes-demo-platform builds should be repeatable Created: 19/Jul/17  Updated: 12/Nov/18  Resolved: 09/Aug/17

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: New Feature Priority: P2
Reporter: Jakub Skoczen Assignee: Wayne Schneider
Resolution: Done Votes: 0
Labels: ci, sprint19
Remaining Estimate: Not Specified
Time Spent: 1 hour
Original estimate: Not Specified

Sprint:

 Description   

A stripes-demo-platform build uses ^X.X.X npm dependencies. This should be correct, but in practice it means that a new build of a bundle from stripes-demo-platform may introduce new (minor) versions of modules with unexpected regressions.
One (possibly partial) solution would be to pin dependencies more specifically, e.g. ~X.X.X or even X.X.X. I'm very open to other solutions – for example, committing a yarn.lock file to the repository.
For my own reference, npm's doc on SemVer parsing: https://docs.npmjs.com/misc/semver



 Comments   
Comment by Wayne Schneider [ 19/Jul/17 ]

A stripes-demo-platform build uses ^X.X.X npm dependencies. This should be correct, but in practice it means that a new build of a bundle from stripes-demo-platform may introduce new (minor) versions of modules with unexpected regressions.

One (possibly partial) solution would be to pin dependencies more specifically, e.g. ~X.X.X or even X.X.X. I'm very open to other solutions – for example, committing a yarn.lock file to the repository.

For my own reference, npm's doc on SemVer parsing: https://docs.npmjs.com/misc/semver

Comment by Mike Taylor [ 19/Jul/17 ]

Committing the yarn-lock file seems like the right solution here.

Comment by Wayne Schneider [ 02/Aug/17 ]

I'm willing to take on updating stripes-demo-platform when there is a new release, running the build, and committing the yarn.lock file. That may mean that we can't be quite as cavalier about updates to package.json in this repo when there's a new release, if we want yarn.lock to be consistent with package.json. Is that an acceptable tradeoff?

Comment by Niels Erik Nielsen [ 03/Aug/17 ]

Wayne Schneider I would definitely welcome the coordination and the measure of predictability.

Comment by Jakub Skoczen [ 09/Aug/17 ]

It looks like yarn.lock has been checked in to stripes-demo-platform. I assume this concludes the work here, if not please re-open.

Generated at Thu Feb 08 23:07:56 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.