[FOLIO-552] Test Site Issues Created: 10/Apr/17  Updated: 12/Nov/18  Resolved: 21/Jun/17

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P2
Reporter: Cate Boerema (Inactive) Assignee: John Malconian
Resolution: Done Votes: 0
Labels: sprint12, sprint13
Remaining Estimate: Not Specified
Time Spent: 3 hours, 30 minutes
Original estimate: Not Specified

Attachments: PNG File screenshot-1.png     PNG File screenshot-2.png    
Issue links:
Blocks
is blocked by STRIPES-326 Update all client-side permission nam... Closed
is blocked by FOLIO-560 http://folio-uidemo.aws.indexdata.com... Closed
is blocked by STRIPES-310 Fix all inter-package Stripes depende... Closed
is blocked by FOLIO-550 Release new versions of ui-users, ui-... Closed
is blocked by STRIPES-316 Editing item records makes right pane... Closed
Relates
relates to STRIPES-314 Diku_admin Doesn't Have Permissions i... Closed
relates to STRIPES-308 Duplicate items both get highlighted Closed
relates to STRIPES-312 Make new stripes-demo-platform Closed
Sprint:

 Description   

Overview: There are a number of issues with http://folio-uidemo.aws.indexdata.com/ today

Steps to Repro:

Actual results:

  • Get a permission error anytime I click on any user (usually diku_admin has all permissions so this is surprising, but maybe someone removed some of the permissions for this user? can we make them super user again?) STRIPES-314 Closed
  • Click to edit an item record and a new pane on the right obscures half of the record edit area FIXED
  • Click an item, click edit, then click New item. The new item form is populated with the data from the item previously being edited FIXED
  • LIBAPP-168 Closed changes not apparent despite having been merged to master 2 days ago.
  • Go to Items and select one of the top 2 items in the list (both named Temeraire, but with different barcodes). Note they are both selected. FIXED
  • Item Status (e.g. checkout out, available etc) no longer displaying on the item detail form (I could have sworn it was)
  • Diku_admin no longer has permission to edit or add new users (related to the first bullet, I am sure) STRIPES-314 Closed

Per Jakub, I am going to create separate bugs for these issues and link them up so we can individually track when they are completed.



 Comments   
Comment by Jakub Skoczen [ 10/Apr/17 ]

Mike Taylor Niels Erik NielsenI just played with the demo site myself and can confirm all those issues. It looks like a set of serious regressions, what should we do to remedy this? Should more specific issues be created?

Comment by Mike Taylor [ 10/Apr/17 ]

The permission one was expected – it's a result of the names of all the permission bits having changed straight after the demo: see DMOD-180. I suspect the demo site is using the new ui-users but an older folio-backend-auth VM. Upgrading both should fix this.

It's possible that the same upgrade might fix some of these other issues, too, so I suggest we not worry too much about them until we're running up-to-date versions of everything. Then let's see what remains.

(The Temeraire bug is old, though. If someone wants to file that separately, I'll take a look at it.)

Comment by Mike Taylor [ 10/Apr/17 ]

Actually, I will file that one.

Comment by Mike Taylor [ 10/Apr/17 ]

The Temeraire bug is now its own issue, STRIPES-308 Closed ("Duplicate items both get highlighted").

Comment by Mike Taylor [ 10/Apr/17 ]

On part 2:

Click to edit an item record and a new pane on the right obscures half of the record edit area

I don't see this (running from an up-to-date Users module against folio-backend-auth v0.8.3), but I do see oddities in how the right pane presently works – eg. when I cancel an edit, the three panes no longer fill the full width of my page. I think this is not a regression, but related to ongoing work that John Coburn is doing – perhaps in LIBAPP-80 Closed . Maybe John can clarify.

Comment by Matt Connolly [ 10/Apr/17 ]

Might some of the edit view issues be browser-related? I know there is a problem with the create/edit views not appearing properly in Safari, at least; see STRIPES-223 Closed .

Comment by Mike Taylor [ 10/Apr/17 ]

I have released all relevant packages now, including the new ui-users that checks permission-names compatible with folio-backend-auth v0.8.3.

John, can you please rebuild the demo site, and we'll see how many of these issues remain.

Comment by John Malconian [ 10/Apr/17 ]

demo site has been rebuilt.

Comment by Cate Boerema (Inactive) [ 11/Apr/17 ]

All these issues still repro.

Comment by Niels Erik Nielsen [ 11/Apr/17 ]

This may be old news as I've been away for a day but for what it's worth, this behavior looks like what I have with latest NPMs and black box 0.8.0.

(with latest NPMs and black box 0.8.3 I cannot log in but get "No running module instance found for authtoken")

Comment by Cate Boerema (Inactive) [ 11/Apr/17 ]

I am using Chrome. This is what I mean by the pane obscuring the edit view. It's also odd that edit is happening in the right pane rather than in the full-page pane like it used to (similar to Create). Was this change made intentionally? It does align with some things Filip has talked about in the past, but I didn't realize we had prioritized it.

Comment by Niels Erik Nielsen [ 11/Apr/17 ]

I saw that locally end of last week and assumed it was related to the work on a collapsible detail pane - LIBAPP-80 Closed I think.

Comment by Niels Erik Nielsen [ 11/Apr/17 ]

I think Mike Taylor solved multiple dependency issues as per FOLIO-548 Closed .

The UI npm's now works against the latest black box for what I can tell from a quick walk-through. When this propagates to the test site, the test site should hopefully improve too.

(no permissions listed in current user menu, don't know if that's a bug or if it's already known)

Comment by Mike Taylor [ 11/Apr/17 ]

The absence of permissions from the user menu is a feature, not a bug: see STRIPES-271 Closed .

Comment by Mike Taylor [ 11/Apr/17 ]

So, Niels Erik Nielsen, you're not getting "No running module instance found for authtoken" any more?

Comment by Mike Taylor [ 11/Apr/17 ]

Cate Boerema: "This is what I mean by the pane obscuring the edit view."

Right, got you. Yes, I am seeing this too, not only on the demo site but in the newest code.

I think John Coburn has got something wrong in his recent work on the multi-pane display. Can you please file that one as a separate issue for him? It's nothing to do with the demo site per se.

Comment by Niels Erik Nielsen [ 11/Apr/17 ]

No Mike Taylor - it logs you in alright now.

Comment by Mike Taylor [ 11/Apr/17 ]

Weird. But good

Comment by John Coburn [ 11/Apr/17 ]

Yes, some of these oddities were introduced with updates to the Pane-related components... I've got them fixed locally - they'll be remedied on the next release of stripes-components! (0.6.0)

Comment by Mike Taylor [ 11/Apr/17 ]

I've talked to John about a release-based demo site. STRIPES-312 Closed is the first step towards making it happen.

Comment by Mike Taylor [ 11/Apr/17 ]

I'm pleased to say John has released stripes-components v0.6.0.

I will release new UI modules that depend on it soon.

Comment by Mike Taylor [ 12/Apr/17 ]

Hold on, Cate. I think many or most of these are fixed in source. Let's get John to rebuild the demo before you waste time filing.

Comment by Mike Taylor [ 12/Apr/17 ]

John Malconian, can you please rebuild the demo?

Comment by Mike Taylor [ 12/Apr/17 ]

Cate Boerema, see recent comments on STRIPES-310 Closed if you are interested in the gritty details. But you needn't go down to that level – all you need to know is that as things stand now, the demo site (once rebuilt) should work right. As should a system made by doing:

$ git clone git@github.com:folio-org/stripes-sample-platform
$ cd stripes-sample-platform/
$ yarn install
$ yarn start
Comment by Cate Boerema (Inactive) [ 12/Apr/17 ]

Thanks Mike Taylor! In that case, I'm not going to file any more separate issues. We can just go through this one when the site has been rebuilt and check that everything is working.

Comment by Mike Taylor [ 12/Apr/17 ]

Agreed! See also STRIPES-312 Closed , an important step towards a more stable demo platform.

Comment by John Malconian [ 12/Apr/17 ]

Demo has been rebuilt using newest UI components.

Comment by Mike Taylor [ 12/Apr/17 ]

Thanks, John. Am testing it now.

Comment by Mike Taylor [ 12/Apr/17 ]

"Get a permission error anytime I click on any user" is happening.

When I build the exact same front-end on my box, this works, so the permissions are in place. I wonder if the problem is that the sample site is using some other back-end VM than folio-backend-auth v0.8.3?

John or Wayne, can you verify?

Comment by Mike Taylor [ 12/Apr/17 ]

"Click to edit an item record and a new pane on the right obscures half of the record edit area"

If find that actually editing the record works OK, now – but that after having edited, the full record display shrinks, leaving a big empty margin on the right. Further edits seem to make the blank area wider, and the full-record display even narrower.

Comment by Wayne Schneider [ 12/Apr/17 ]

I would be almost certain that the mod-users and mod-auth on the sample site is different than folio-backend-auth v0.8.3. Permission names are (still!) being realigned, I should be able to get working versions of everything backend-related this morning.

Comment by Mike Taylor [ 12/Apr/17 ]

sigh

Can we please just give up on the demo site completely until the back-end people have decided once and for all what they want the permission names to be? This is a ridiculous waste of my and Cate's time.

Comment by Mike Taylor [ 12/Apr/17 ]

I moved the items-editing bug out to its own new issue, STRIPES-316 Closed , since it also occurs when running from the most recent code.

Comment by Mike Taylor [ 13/Apr/17 ]

As Wolfram has noted, the entire demo site is now down. See FOLIO-560 Closed .

Comment by Niels Erik Nielsen [ 13/Apr/17 ]

Mike:

So, Niels Erik Gilvad Nielsen, you're not getting "No running module instance found for authtoken" any more?

NE:

No Mike Taylor - it logs you in alright now.

Mike:

Weird. But good

This issue reappeared, but mystery solved. Depending on your bandwidth the box can now take quite some time to get all modules pulled and start the containers (on my very slow land-line, 30 minutes or so, on my faster mobile 10 minutes). So as I was trying out different boxes I tried logging in well ahead of the modules being started.

Comment by John Malconian [ 13/Apr/17 ]

We have our back end module issues resolved and the demo site is back up. However, note that the UI for Users is still going to be broken until the permission names in the UI catch up to the backend.

Might as well keep this issue open for ongoing issues with the demo.

Comment by Cate Boerema (Inactive) [ 19/Apr/17 ]

Thanks, guys! Do we have a sense of when the permission names in the UI will be caught up with the backend? Is someone working on this?

Also, Niels Erik Nielsen, would you expect the Scan validation from LIBAPP-168 Closed to be present in this environment? That story has been marked done for a while but I'm still not seeing it here. Thanks!

Comment by Niels Erik Nielsen [ 19/Apr/17 ]

Mea culpa Cate Boerema

Merged and committed but not pushed to github. Until just now.

Comment by Mike Taylor [ 19/Apr/17 ]

Thanks, guys! Do we have a sense of when the permission names in the UI will be caught up with the backend? Is someone working on this?

I'll work on it as soon as I am assured by the back-end people that the present version of the folio-backend-auth VM has the final permission names in place and will not change again.

Wayne Schneider, Kurt Nordstrom, Heikki Levanto: Do you know if this is yet the case?

Comment by Mike Taylor [ 19/Apr/17 ]

I added STRIPES-326 Closed ("Update all client-side permission names to match new backend") as a blocker. Backend people, let me know when everything is stable enough for me to do this.

Comment by Mike Taylor [ 19/Apr/17 ]

I added STRIPES-326 Closed ("Update all client-side permission names to match new backend") as a blocker. Backend people, let me know when everything is stable enough for me to do this.

Generated at Thu Feb 08 23:06:38 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.