[FOLIO-524] CQL translator: support <> (not equal) operator Created: 28/Mar/17 Updated: 12/Nov/18 Resolved: 25/Apr/17 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P3 |
| Reporter: | Jakub Skoczen | Assignee: | frances.webb@cornell.edu |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | sprint11, sprint12, sprint13 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||
| Sprint: | |||||||||||||
| Description |
|
The support should include both string fields and fields that are arrays (0 element array should match) and nested object (null object should match) The cases we want to support:
|
| Comments |
| Comment by frances.webb@cornell.edu [ 28/Mar/17 ] |
|
I put my understanding of the goal in the issue description. |
| Comment by frances.webb@cornell.edu [ 28/Mar/17 ] |
|
In the spirit of consistency, it seems like we should also have String == "" match records where the string element doesn't exist or is empty. It looks like we already have String = "" matching records where the string exists and may or may not be empty (as an empty string is a substring of any string). |
| Comment by Julian Ladisch [ 30/Mar/17 ] |
|
To be consistent using any of the predefined cql relations =, ==, <>, <, >, <=, >= with a string should require that the string element exists. Therefore I suggest:
This has been implemented since Februar 6. Now there are explicit test cases for them: |
| Comment by Julian Ladisch [ 30/Mar/17 ] |
|
The existing implementation has not yet special support for arrays but treats an array like a string so this is already possible:
Matching a single array element is also possible:
|
| Comment by Julian Ladisch [ 03/Apr/17 ] |
|
Please check whether the NOT and array capabilities implemented in cql2pgjson >= 1.1.0-SNAPSHOT and raml-module-builder/domain-models-runtime >= 10.0.5-SNAPSHOT and described in the readme https://github.com/folio-org/cql2pgjson-java/ are sufficient and report any missing features. |
| Comment by frances.webb@cornell.edu [ 04/Apr/17 ] |
|
It looks like the work done by Julian Ladisch on
|
| Comment by Adam Dickmeiss [ 25/Apr/17 ] |
|
Not doing it here, since
|