[FOLIO-3967] Add mod-dcb to folio-snapshot reference environment Created: 29/Jan/24 Updated: 08/Feb/24 Resolved: 07/Feb/24 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | TBD |
| Reporter: | Tetiana Gusar | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||
| Sprint: | DevOps Sprint 160 | ||||||||||||||||
| Development Team: | FOLIO DevOps | ||||||||||||||||
| Description |
|
Dear DevOps team, Please add the new module to the hosted environments for testing and demo purposes: mod-dcb https://github.com/folio-org/mod-dcb/releases/tag/2023.12.12 Module is ready to be installed as per the guideline below, please let us know if any additional detail are required. CC: Oleksii Petrenko, Gurleen Kaur1 |
| Comments |
| Comment by David Crossley [ 29/Jan/24 ] |
|
You need to create separate Jira tickets for each module. You also need to follow the instructions for raising FOLIO DevOps tickets: Your team also needs to follow the links from here (and earlier in this document) to be sure that your modules are ready to be installed: |
| Comment by Tetiana Gusar [ 30/Jan/24 ] |
|
David Crossley thank you for comments, I'll create the separate jira's and will follow your guidelines. |
| Comment by David Crossley [ 31/Jan/24 ] |
|
Thanks. Note that the folio-testing environment was discontinued ages ago. I modified these ticket titles. |
| Comment by David Crossley [ 07/Feb/24 ] |
|
The mod-dcb has been added to platform-complete snapshot branch. It is now included in today's folio-snapshot build. However there is a problem. See each https://dev.folio.org/guides/automation/#platform-hourly-build (for example https://jenkins-aws.indexdata.com/job/Automation/job/build-platform-complete-snapshot/24498/consoleFull) Search there for: mod-dcb Note that it does not have -SNAPSHOT.xx appended, as do other modules (e.g. the related mod-circulation-item DEVOPS-3969). This module does have a docker image deployed to Docker Hub. See https://hub.docker.com/r/folioci/mod-dcb/tags ... i.e. 1.0.0-SNAPSHOT.66 Wayne Schneider – Would you please try to determine what is amiss. I cannot figure it out. |
| Comment by Wayne Schneider [ 07/Feb/24 ] |
|
A release has been made (v1.0.0 – I note that in addition there are several non-semantic tags, which are not proper releases and are meaningless to our CI processes), but I believe that the release procedures were not properly followed. In particular, the version in the pom.xml is still 1.0.0-SNAPSHOT, which under semantic versioning is a prerelease of v1.0.0. Based on semantic versioning sorting, the most recent release is v1.0.0, not v1.0.0-SNAPSHOT.66, so that is why it is chosen. The team should please please please review the release procedures and, I believe, set the version in pom.xml to 1.1.0-SNAPSHOT to ensure that the head of the master branch is deployed to the reference environments. |
| Comment by David Crossley [ 07/Feb/24 ] |
|
Thanks Wayne. Gurleen Kaur1 – Please remedy the POM version as Wayne suggests. Yes, the release procedure must be followed in future. |
| Comment by Gurleen Kaur1 [ 08/Feb/24 ] |
|
Hi David Crossleyand Wayne Schneider - Firstly, my apologies for the trouble caused. The v1.0.0 tag that was created for mod-dcb isn't required any more (it was created for test purpose in Oct’23). Therefore, if I delete this tag and keep the same version in pom.xml as 1.0.0-SNAPSHOT will that work i.e the builds will happen safely and the head of the master branch is deployed to the reference environments ? |
| Comment by David Crossley [ 08/Feb/24 ] |
|
This issue is not about git tags. It is about the version in the POM. I have done some more digging, and i think that i can explain the problem. Do this query to the ModuleDescriptor registry and see the final item: Note that it is “mod-dcb-1.0.0”. And the other more recent descriptors have “mod-dcb-1.0.0-SNAPSHOT.xx” but should be mod-dcb-1.1.0-SNAPSHOT.xx”. I assume that this came from your tmp-release-1.0.0 branch at commit: https://github.com/folio-org/mod-dcb/commit/e6beb099baabf7749a76d046bee204f0d64421fe After that the POM in master branch needed to be 1.1.0-SNAPSHOT as explained in the release procedures. The only way to fix it now is to increment your POM to “1.1.0-SNAPSHOT”. |
| Comment by Gurleen Kaur1 [ 08/Feb/24 ] |
|
Thanks David Crossley I will merge the PR. Do we have any problems like these with edge-dcb or mod-circulation-item modules ? |
| Comment by Gurleen Kaur1 [ 08/Feb/24 ] |
|
Done the pom is rectified. |