[FOLIO-3667] folio-org/mod-data-export-worker using SAP CLA license text instead of FOLIO CLA text Created: 19/Dec/22  Updated: 23/Jan/23  Resolved: 23/Jan/23

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: TBD
Reporter: Julian Ladisch Assignee: Peter Murray
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: File cla-assistant-data-import-raml-storage.csv     File cla-assistant-edge-common-spring.csv     File cla-assistant-mod-data-export-worker.csv    
Issue links:
Blocks
blocks MODEXPW-344 Upgrades: Spring Boot 2.7.6, ssh-sftp... Closed
blocks MODEXPW-346 Upgrade vulnerable dependencies for O... Closed
Relates
relates to FOLIO-3048 folio-org/acq-models using SAP CLA li... Closed
Sprint: DevOps Sprint 157
Development Team: FOLIO DevOps
RCA Group: Third party component integration

 Description   

Overview:

https://github.com/folio-org/mod-data-export-worker requires authors of pull requests to sign the SAP CLA.

Steps to Reproduce:

  1. Given a developer that has signed the FOLIO CLA text https://dev.folio.org/guidelines/cla-process/
  2. That developer opens a pull request against default (master) branch of https://github.com/folio-org/mod-data-export-worker

Expected Results:

CLA Assistant accepts the pull request of the developer.

Actual Results:

CLA Assistant rejects the pull request of the developer and requests that the developer signs the SAP CLA.

What is wrong?

It should be the FOLIO CLA, not the SAP CLA.

Additional Information:

Example pull request: https://github.com/folio-org/mod-data-export-worker/pull/383

Example CLA Assistant message:


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Text to accept/sign:

Please agree to the CLA for folio-org/mod-data-export-worker

Version: 2022-11-21

https://cla-assistant.io/#sap-individual-contributor-license-agreementSAP Individual Contributor License Agreement

...

9 months ago we had the same issue with folio-org/acq-models: FOLIO-3048 Closed



 Comments   
Comment by David Crossley [ 15/Jan/23 ]

Peter Murray – Would you please attend to this. I have attempted to follow what you did with FOLIO-3048 Closed but cannot find how you got to screenshot-1. Perhaps i need to login as the special user, but dunno the credentials.

Comment by Peter Murray [ 23/Jan/23 ]

Odd — there were three GitHub projects that were overridden to use the SAP CLA. I downloaded the signatures for these three projects against the SAP SLA and removed these repository-specific configurations.

These three repositories will now default to the default FOLIO CLA, so the developers should not notice any difference (unless there are developers that are unique to these three projects and have not yet signed the FOLIO project CLA).

Comment by Julian Ladisch [ 23/Jan/23 ]

Thank you, now it's the right CLA!

Generated at Thu Feb 08 23:29:49 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.