[FOLIO-3608] Replace FolioVertxCompletableFuture usage Created: 10/Oct/22 Updated: 15/Dec/23 Resolved: 15/Dec/23 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Umbrella | Priority: | P2 |
| Reporter: | Julian Ladisch | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||||||||||||||||||||||
| Development Team: | Thunderjet | ||||||||||||||||||||||||||||||||||||||||||||
| Release: | Quesnelia (R1 2024) | ||||||||||||||||||||||||||||||||||||||||||||
| RCA Group: | TBD | ||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
Remove any usage of the FolioVertxCompletableFuture and VertxCompletableFuture class. The library maintainer Clement Escoffier, a Vert.x Core developer, says at https://github.com/cescoffier/vertx-completable-future/issues/45 :
FolioVertxCompletableFuture and VertxCompletableFuture make a bridge between CompletionStage and a Vert.x Future. This mixes two architectures:
There is never a need to mix these two architectures. Vert.x based modules should always use Futures, non-Vert.x based modules should always use CompletionStage. Mixing them requires the developer to take care of both thread architectures, this is a complex and error-prone task and should be avoided where possible. VertxCompletableFuture should never be used in production:
|
| Comments |
| Comment by Serhii_Nosko [ 13/Nov/23 ] |
|
Hi Julian Ladisch we completed all stories for this feature, I think it can be considered for closing, feel free to close, thanks |
| Comment by Julian Ladisch [ 15/Dec/23 ] |
|
Thanks, look good! |