[FOLIO-3608] Replace FolioVertxCompletableFuture usage Created: 10/Oct/22  Updated: 15/Dec/23  Resolved: 15/Dec/23

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Umbrella Priority: P2
Reporter: Julian Ladisch Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Defines
is defined by MODFIN-283 Replace FolioVertxCompletableFuture u... Closed
is defined by MODFIN-327 [Merge part] Replace FolioVertxComple... Closed
is defined by MODINVOICE-431 Replace FolioVertxCompletableFuture u... Closed
is defined by MODORDERS-780 Replace FolioVertxCompletableFuture u... Closed
is defined by MODORDERS-805 Replace FolioVertxCompletableFuture u... Closed
is defined by MODGOBI-176 Replace FolioVertxCompletableFuture u... Closed
is defined by MODINVOSTO-148 Replace FolioVertxCompletableFuture u... Closed
is defined by MODORDSTOR-318 Replace FolioVertxCompletableFuture u... Closed
Relates
relates to FOLIO-3607 FOLIO fork of https://github.com/cesc... Closed
Sprint:
Development Team: Thunderjet
Release: Quesnelia (R1 2024)
RCA Group: TBD

 Description   

Remove any usage of the FolioVertxCompletableFuture and VertxCompletableFuture class.

The library maintainer Clement Escoffier, a Vert.x Core developer, says at https://github.com/cescoffier/vertx-completable-future/issues/45 :

I don't believe it would be part of Vert.x, and in terms of API, I'm not recommending CompletionStage anymore after having seen quite some code horrors.

FolioVertxCompletableFuture and VertxCompletableFuture make a bridge between CompletionStage and a Vert.x Future.

This mixes two architectures:

  • Fork join thread pool of CompletionStage.
  • Single-threaded async operation of Vert.x Future.

There is never a need to mix these two architectures.

Vert.x based modules should always use Futures, non-Vert.x based modules should always use CompletionStage.

Mixing them requires the developer to take care of both thread architectures, this is a complex and error-prone task and should be avoided where possible.

VertxCompletableFuture should never be used in production:



 Comments   
Comment by Serhii_Nosko [ 13/Nov/23 ]

Hi Julian Ladisch we completed all stories for this feature, I think it can be considered for closing, feel free to close, thanks

Comment by Julian Ladisch [ 15/Dec/23 ]

Thanks, look good!

Generated at Thu Feb 08 23:29:22 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.