[FOLIO-3568] Add ui-serials-management and mod-serials-management to snapshot Created: 26/Aug/22 Updated: 08/Nov/22 Resolved: 28/Oct/22 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | TBD |
| Reporter: | Jack Golding | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||
| Sprint: | DevOps Sprint 151 | ||||||||
| Development Team: | FOLIO DevOps | ||||||||
| RCA Group: | TBD | ||||||||
| Description |
|
Add serials-management UX and backend modules to snapshot Associated PR: https://github.com/folio-org/platform-complete/pull/2186
|
| Comments |
| Comment by David Crossley [ 27/Oct/22 ] |
|
I have reviewed both modules regarding the CI-related aspects of https://dev.folio.org/faqs/how-to-install-new-module/ Mostly okay for both modules. However, as noted on the PR pull/2186, there is something incorrect. The package.json for ui-serials-management does not have any "okapiInterfaces" section. (See for example "ui-oa".) As explained at this doc, if the front-end module does declare the interface "serials-management" then the back-end module mod-serials-management will be automatically included in the platform. Otherwise the mod-serials-management will need to be temporarily added to the platform-complete snapshot "install-extras.json" file. |
| Comment by David Crossley [ 27/Oct/22 ] |
|
Some things are missing for both repositories, according to https://dev.folio.org/guidelines/create-new-repo/ "The branch protection and its required checks" "Ensure that the required copyright and license statement is near the top of the README" |
| Comment by Jack Golding [ 27/Oct/22 ] |
|
Thanks for pointing out those issues, the changes to mod/ui-serials-management have been merged this morning |
| Comment by David Crossley [ 28/Oct/22 ] |
|
Okay, the platform-complete snapshot PR is merged, and the subsequent hourly platform build was successful. The modules are now in today's folio-snapshot. |
| Comment by David Crossley [ 28/Oct/22 ] |
|
By the way, there are some other tasks that are not yet done for these modules. |