[FOLIO-3504] GA pipeline failing in some repos but successful in Jenkins Created: 16/May/22  Updated: 09/Aug/22  Resolved: 09/Aug/22

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: TBD
Reporter: Ankita Sen Assignee: Ankita Sen
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
blocks FOLIO-3452 Roll out Github Actions to remaining ... Closed
is blocked by UIDATIMP-1211 Github Actions: The yarn test step fa... Closed
is blocked by UIDEXP-282 Github Actions: Test failures with bo... Closed
is blocked by ERM-2277 Karma tests fail on Github Actions CI... Closed
is blocked by UIF-400 Github Actions: The yarn test step fa... Closed
is blocked by UIFC-277 Github Actions: The yarn test step fa... Closed
is blocked by UIOR-997 Github Actions: Test failures with bo... Closed
Relates
relates to FOLIO-3067 Replace Jenkins UI and Stripes CI pip... Closed
Sprint: DevOps Sprint 146, DevOps Sprint 144, DevOps Sprint 140, DevOps Sprint 145
Development Team: FOLIO DevOps
RCA Group: TBD

 Description   

The Github Actions Pipeline in failing in the test step for a few other repositories but are showing successful Jenkins run.

The repositories which are currently failing with either Node 16, Node 14 or both:

  • ui-orders  (yarn test fails for both Node 14 and 16)


 Comments   
Comment by Zak Burke [ 13/Jun/22 ]

Ankita Sen, When we moved ui-users from Node v12 to v16, we hit a bunch of unexpected errors ( UIU-2607 Closed , PR #2144) that we did not have a great explanation for:

Lots of clean up of lots of tests. In classic style, "How did this ever work?" Our working theory is that some things that were warnings under NodeJS v12 have been converted to errors in v16, thus causing new failures. Still, some of these issues do seem like outright errors, e.g. incorrect selector IDs, so it's hard to say for certain.

It's possible you're hitting the same thing here and will need assistance from the repo owners to resolve the test failures.

Related, I can see from the karma tests in stripes-erm-components that they implement the same pattern we removed in STCOR-620/PR #1193, leveraging multiple mount() functions that sometimes conflict. Another common anti-pattern here is the importing of some harness functions and components from stripes-core by private path while others are defined locally; all harnesses should be defined locally.

Finally, we recently cleaned up some deps in stripes-webpack that may need to be restored here by running

yarn add -D @bigtest/mirage
Comment by John Malconian [ 13/Jun/22 ]

Note that Jenkins uses Nodejs 14, I think. I'm not sure which Node version is used in the GA workflow testing, but we should try to get an apples-to-apples comparison by running the GA workflow with Node 14 to see if the results still differ. If a GA workflow with Node 14 and the Jenkins pipeline both pass, but fail with Node 16, then that is an issue for the devs.

Comment by Ankita Sen [ 05/Jul/22 ]

Update: 05-07.2022

As of now the stipes-erm-components and the ui-erm-comparisons give the same error during the yarn test setp both on Node 14 and 16. The error is as follows:

START:
7705 07 2022 12:08:49.717:WARN [filelist]: All files matched by "/tmp/_karma_webpack_701325/**/*" were excluded or matched by prior matchers.
78Webpack bundling...
7905 07 2022 12:08:50.203:ERROR [karma-server]: UnhandledRejection: Error: Could not find the npm peerDependency "favicons".
80Please run:
81npm i favicons
82 - or -
83yarn add favicons
8485Error: 
86Something went wrong installing the "sharp" module
8788Cannot find module '../build/Release/sharp.node'
89Require stack:
90- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/sharp/lib/constructor.js
91- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/sharp/lib/index.js
92- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/favicons/dist/helpers.js
93- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/favicons/dist/index.js
94- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/favicons-webpack-plugin/src/index.js
95- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-webpack/webpack/stripes-branding-plugin.js
96- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-webpack/webpack/stripes-webpack-plugin.js
97- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-cli/lib/cli/stripes-core.js
98- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-cli/lib/commands/test/karma.js
99- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-cli/lib/commands/test.js
100- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-cli/node_modules/yargs/build/index.cjs
101- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-cli/node_modules/yargs/yargs
102- /home/runner/work/stripes-erm-components/stripes-erm-components/node_modules/@***/stripes-cli/lib/stripes-cli.js
103104- Remove the "node_modules/sharp" directory then run
105  "npm install --ignore-scripts=false --verbose sharp" and look for errors
106- Consult the installation documentation at https://sharp.pixelplumbing.com/install107- Search for this error at https://github.com/lovell/sharp/issues 
Comment by Jakub Skoczen [ 11/Jul/22 ]

Anton Emelianov any chance you could help Ankita Sen coordinate the work that needs to be done by the development teams to fix failing Karma tests?

Comment by Ankita Sen [ 09/Aug/22 ]

All the repositories are now migrated to Github Actions

Generated at Thu Feb 08 23:28:38 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.