[FOLIO-3477] FE: update outdated dependencies Created: 22/Apr/22 Updated: 17/May/22 Resolved: 17/May/22 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Tech Debt | Priority: | P3 |
| Reporter: | Khalilah Gambrell | Assignee: | Priyanka Terala |
| Resolution: | Done | Votes: | 0 |
| Labels: | epam-spitfire, front-end | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||||||||||||||||||
| Sprint: | Spitfire Sprint 140, Spitfire Sprint 139 | ||||||||||||||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||||||||||||||
| Development Team: | Spitfire | ||||||||||||||||||||||||||||||||||||
| Release: | Morning Glory (R2 2022) | ||||||||||||||||||||||||||||||||||||
| RCA Group: | TBD | ||||||||||||||||||||||||||||||||||||
| Description |
|
Please do this work for modules owned by Spitfire. Below requirements were provided by Zak Burke .
Additional notes from Zak: Some of these warnings (classnames, prop-types, prop-types-extra) should be straight deps, not peers. Some probably should be peers, but that means adding them to the platform and making them peers in modules where they are currently direct deps. This'll take a keen eye.
Also review this story
|
| Comments |
| Comment by Priyanka Terala [ 10/May/22 ] |
|
Zak Burke 2. Although I update the package versions appropriately(in local), the linking warnings are still visible. Please find the reference below - |
| Comment by Zak Burke [ 10/May/22 ] |
|
Priyanka Terala, yes, moment can be unpinned from ~2.24.0 and bumped to ^2.29.0. I don't remember what the 2.25.0 bug was, but I remember it being completely unusable for us at the time. The rest of those "unmeet peer react..." warnings are because your workspace's package.json is missing the deps that platform-complete's package.json provides. Add those, plus @folio/stripes which will pull in -core, -connect, -stripes-smart-components etc. Copy those into the workspace's package.json and most warnings will disappear. If the warnings are still present, then it is an indication of something that needs to be fixed, e.g.
|
| Comment by Priyanka Terala [ 11/May/22 ] |
|
Instead of using the platform workspace approach, I had cloned "Platform-Complete", checked out the branch "snapshot" and ran "yarn install". Here I could see 2. three warnings(pertaining to those modules owned by Spitfire Team ) while linking dependencies Zak Burke Could you please help me with the exact steps to build "platform-complete", if this is not the correct approach? |
| Comment by Zak Burke [ 11/May/22 ] |
|
Priyanka Terala, yarn install within platform-complete will pull in platform-complete's deps (and so on transitively, i.e. deps fo deps, deps of deps of deps...) and its dev-deps. It will not pull in dev-deps transitively. Thus, things we find out about with this kind of install are (1) incorrect dependencies from any module and (2) incorrect dev-deps from the platform. WRT your questions above:
If you want to learn about incorrect dev-deps in an individual module, you need to clone that module and run yarn install for it. Just as yarn install in a platform can tell us about problems with the platform's dev-deps, yarn install in a UI app can tell us about problems with the app's dev-deps. |
| Comment by Priyanka Terala [ 12/May/22 ] |
|
Zak Burke |