[FOLIO-3407] Don't use curl for java container health check Created: 11/Feb/22 Updated: 06/Nov/22 Resolved: 03/Nov/22 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | Continuous Integration |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Umbrella | Priority: | P3 |
| Reporter: | Julian Ladisch | Assignee: | Julian Ladisch |
| Resolution: | Done | Votes: | 0 |
| Labels: | security, security-reviewed | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||||||||||
| Development Team: | None | ||||||||||||||||||||||||||||||||
| RCA Group: | TBD | ||||||||||||||||||||||||||||||||
| Description |
|
Remove curl from Many java based modules use curl for their health check; they set this healthChkCmd in their Jenkinsfile: curl -sS --fail -o /dev/null http://localhost:8081/apidocs/ || exit 1 Jenkins runs this command inside of the java container (containerHealthCheck.groovy, run healthcheck, builder healthcheck). This requires that curl is installed inside of the java container. Currently we add curl to the java container: folio-java-docker/openjdk11/Dockerfile#L14 curl should be removed from this container and replaced by busybox wget or maven integration tests. This has several advantages:
Module developers have several options:
|
| Comments |
| Comment by Craig McNally [ 03/Nov/22 ] |
|
Curl is no longer being installed into the openjdk17 base image. See https://github.com/folio-org/folio-tools/blob/master/folio-java-docker/openjdk17/Dockerfile
Closing this as done |