[FOLIO-3350] Migrate stripes-react-hotkeys repo to FOLIO GH Actions workflow Created: 19/Nov/21  Updated: 24/May/22  Resolved: 24/May/22

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: TBD
Reporter: John Malconian Assignee: John Malconian
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint: DevOps Sprint 135, DevOps Sprint 136, DevOps Sprint 137, DevOps Sprint 138, DevOps Sprint 139, DevOps Sprint 140
Development Team: FOLIO DevOps

 Description   

The folio-org/stripes-react-hotkeys repository is a little different than other stripes repositories in that the node_modules directory that is created after 'yarn install' needs to be preserved when an NPM package is published. I think the best way to deal with this exception is to migrate this repo from Jenkins to the build-npm workflow. ASAIK, that workflow does not remove the node_modules directory. Instead, NPM publish relies on the contents of the repo's .gitignore and .npmignore files to determine what's included or excluded from the NPM package. After we migrating to a GH workflow, a .npmignore file that doesn't exclude node_modules (and possibly yarn.lock?) will need to be added to the repo to override the .gitignore file.



 Comments   
Comment by John Malconian [ 19/Nov/21 ]

From John C: So long as what ends up on NPM includes the 'cjs, umd, es' folders (all in the gitignore), should be good. (these are listed in the package.json of the repo)

Comment by Zak Burke [ 06/May/22 ]

npm publish always excludes node_modules from the bundle so no special handling is necessary.

Comment by John Malconian [ 24/May/22 ]

The stripes-react-hotkeys repository has been migrated to Github Actions. NODEJS_VERSION is set to '16'.

Generated at Thu Feb 08 23:27:27 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.