[FOLIO-3301] name GA workflow files consistently with their templates Created: 28/Sep/21  Updated: 15/Feb/22  Resolved: 15/Feb/22

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: TBD
Reporter: Zak Burke Assignee: Ankita Sen
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Duplicate
is duplicated by FOLIO-3305 Workflows need to use consistent file... Closed
Sprint: DevOps Sprint 124, DevOps Sprint 133
Development Team: FOLIO DevOps

 Description   

Summary: GitHub Actions workflow files should be named consistently with the template files (buildNPM-Release.yml, buildNPM.yml) in the .github workflow template repository.

Details: The following repositories have inconsistently named files:

  • stripes-components
  • stripes-connect
  • stripes-final-form
  • stripes-util
  • stripes-smart-components
  • stripes
  • ui-users


 Comments   
Comment by Ankita Sen [ 04/Oct/21 ]

Have started updating the file names. I am going forward with this naming convention 

  • build-npm.yml
  • buil-npm-release.yml

It is updated in the .github workflow repository as well as the above mentioned repositories.

Comment by Ankita Sen [ 04/Oct/21 ]

The workflow files are updates with the new uniform naming conventions.

Comment by Zak Burke [ 04/Oct/21 ]

Reopening this, Ankita Sen, as several stripes-* repos still have GA Workflow files that do not follow the conventions listed above:

Comment by Ankita Sen [ 06/Oct/21 ]

Zak Burke - stripes-core and stripes-form is now updated, however, stripes-smart-components and stripes-components have test failures due to which I am unable to merge my code, I have been trying since Monday to check and re-run the jobs but they seem to be failing all the time. So unless the test issues are resolved I won't be able to merge my PR with the updated names.

Comment by Zak Burke [ 06/Oct/21 ]

Thanks for the update, Ankita Sen. Alas, the SSC failures reproduce for me locally; I'll get in touch with those folks.

Comment by Ankita Sen [ 07/Oct/21 ]

Merged with master by overriding the CI failure. The repositories are updated now with the above given naming conventions.

Comment by David Crossley [ 06/Jan/22 ]

I scanned all front-end repositories. Found that there is still one at ui-orders with the old filename (buildNPM.yml). It seems to be partially implemented (perhaps an early test one) as the Jenkinsfile is also still in operation there.

Re-opened this ticket.

Comment by Ankita Sen [ 15/Feb/22 ]

Cleaned the ui-orders repository. It has only Jenkins installed for now.

Generated at Thu Feb 08 23:27:06 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.