[FOLIO-3278] FOLIO testing unavailable due incompatible expectations for source-manager-parsed-records interface Created: 03/Sep/21  Updated: 03/Sep/21  Resolved: 03/Sep/21

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: TBD
Reporter: Marc Johnson Assignee: Pavlo Smahin
Resolution: Done Votes: 0
Labels: hosted-environments, interface-incompatibility, outage
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
blocks FAT-947 mod-data-import: Set up default data ... Closed
Relates
relates to MODSOURMAN-553 Update GET /change-manager/parsedReco... Closed
Sprint:
Development Team: Spitfire

 Description   

Volodymyr Rohach reported that the folio-testing environment was unavailable.

After some investigation of the latest build, the cause was identified as an incompatible interface expectations for the source-manager-parsed-records interface:

Incompatible version for module mod-quick-marc-2.2.0-SNAPSHOT.122 interface source-manager-parsed-records. Need 2.0. Have 3.0/mod-source-record-manager-3.2.0-SNAPSHOT.456"

Unfortunately, it isn't possible to easily identify the work that contributed to this outage, as the change was made directly to the mainline with no reference to a JIRA issue.

Interested parties: Oleksii Petrenko Anton Emelianov



 Comments   
Comment by Wayne Schneider [ 03/Sep/21 ]

This work was announced on the FOLIO #development Slack channel. PR: https://github.com/folio-org/mod-source-record-manager/pull/476/files

Comment by Wayne Schneider [ 03/Sep/21 ]

The PR references MODSOURMAN-553 Closed , which appears to suggest a breaking change ("Update GET /change-manager/parsedRecords to have externalId param instead [of] instanceId"). Certainly looking at the API documentation, there is definitely a breaking change to this interface, in that the instanceId query parameter is no longer supported. I note in the PR for the mod-quick-marc change related to this issue that there is no code change, only a module descriptor change, so while the system may build, it may be that mod-quick-marc will be unable to use the new interface.

It occurs to me that it might be possible to introduce a new query parameter and deprecate the use of the old one, avoiding a breaking change. Shans Kaluhin, Pavlo Smahin, it might be much less disruptive to downstream consumers to use this strategy in the future.

Comment by Wayne Schneider [ 03/Sep/21 ]

With the change in the mod-quick-marc module descriptor, folio-testing has been rebuilt.

Generated at Thu Feb 08 23:26:56 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.