[FOLIO-3251] After hotfix 3, many apps fail with a UI error Created: 27/Jul/21  Updated: 29/Jul/21  Resolved: 27/Jul/21

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P2
Reporter: Zak Burke Assignee: John Malconian
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint: DevOps Sprint 119
Development Team: FOLIO DevOps

 Description   

Overview: Teh UI is broke in Orders, Circulation log, Export manager
Steps to Reproduce:

  1. Log into a folio-environment with 2021-R2, Hotfix 3 installed 
  2. Click Orders, Circulation log, or Export manager

Expected Results: Apps load
Actual Results: Apps fail with a UI error, "Something went wrong"

Interested parties: Philip Robinson, Björn Muschall, Jenn Colt



 Comments   
Comment by Zak Burke [ 27/Jul/21 ]

Preliminary findings: stripes-acq-components contains references to two components/functions that are part of Juniper, not Iris:

"export 'KeyboardShortcutsModal' was not found in '@folio/stripes/components'
"export 'getLocaleDateFormat' was not found in '@folio/stripes/components'

Any app depending on @folio/stripes-acq-components will thus fail.

Comment by John Malconian [ 27/Jul/21 ]

I've pinned some dependencies to Iris versions using resolutions. A subsequent Iris build is available at https://folio-iris.dev.folio.org

Comment by Zak Burke [ 27/Jul/21 ]

This is the same problem we had long, long ago in stripes-land that caused us to move from caret-deps to tilde-deps for the inter-stripes dependencies. The problem is two-fold:

  1. given a build with ~ and ^ deps, instead of respecting the ~ if it satisfies both and hoisting a single version, yarn will install nested versions of each. That is, given foo versions 1.2.3 and 1.3.3, a platform-dep like foo: "~1.2.3", and an app-dep like foo: "^1.2.3", yarn will install both in nested node_modules directories instead of just hoisting 1.2.3.
  2. we probably should move direct-deps on stripes-$foo-components to peer-deps. this would prevent yarn from hiding this problem from us.
Generated at Thu Feb 08 23:26:44 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.