Inventory (UXPROD-785)

[FOLIO-3241] Test inventory optimistic locking in scratch environment Created: 19/Jul/21  Updated: 13/Sep/21  Resolved: 13/Sep/21

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None
Parent: Inventory

Type: Story Priority: TBD
Reporter: Julian Ladisch Assignee: Mikhail Fokanov
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File image-2021-08-23-10-21-47-957.png    
Issue links:
Defines
defines UXPROD-3089 Inventory. Implementing Optimistic Lo... Closed
Sprint: CP: sprint 122
Story Points: 5
Development Team: Core: Platform
Epic Link: Inventory

 Description   

Before testing we need to deploy changes to the core platform scratch enviroment. In order to do this we can do the following:

1) merge to master everything that can be merged
2) deploy feature branches for the changes that can't be merged:

  • mod-inventory-storage
  • mod-inventory

The docker containers are

docker.dev.folio.org/mod-inventory-storage:MODINVSTOR-713-optimistic-locking-failOnConflict
docker.dev.folio.org/mod-inventory:MODINV-398-optimistic-locking-version

Optimistic locking in inventory requires interface bump in many modules. Some module require some changes to properly process the new _version property.

This issue is for running a complete FOLIO system with all optimistic locking changes to test that it properly works.



 Comments   
Comment by Julian Ladisch [ 16/Aug/21 ]

Enabling failOnConflict for instance, holding and item in mod-inventory-storage bumped provided interface versions in mod-inventory-storage and mod-inventory.

New provided interface versions

mod-inventory-storage = MODINVSTOR-726 Closed = https://github.com/folio-org/mod-inventory-storage/pull/624/files

  • instance-storage 8.0
  • holdings-storage 5.0
  • item-storage 9.0
  • item-storage 9.0
  • instance-storage-batch 1.0
  • instance-storage-batch-sync 1.0
  • holdings-storage-batch-sync 1.0
  • item-storage-batch-sync 1.0

mod-inventory = MODINV-398 Closed = https://github.com/folio-org/mod-inventory/pull/344/files

  • inventory 11.0
  • inventory-batch 1.0

New required interface versions

All front-end and back-end modules that use these new provided interface versions need to declare them as "required" or "optional" in their ModuleDescriptor or package.json, otherwise the platform build will reject this.

Examples:

mod-inventory = MODINV-398 Closed = https://github.com/folio-org/mod-inventory/pull/344/files

mod-inventory provides 2 interfaces that were bumped:

mod-patron = MODPATRON-56 Closed = https://github.com/folio-org/mod-patron/pull/53/files

The "inventory" interface for instances was changed from
"5.2 6.0 7.0 8.0 9.0 10.0" to
"5.2 6.0 7.0 8.0 9.0 10.0 11.0".
The "holdings-storage" interface was removed because investigation showed that the CQL query could be rewritten to avoid the holdings API.

mod-feesfines = MODFEE-192 Closed = https://github.com/folio-org/mod-feesfines/pull/183/files

Simply added the new version to the list of allowed versions for the instance, holding and item interface. Investigation showed that the declared "inventory" was not used and therefore it has been removed.

ui-checking = UICHKIN-258 Closed = https://github.com/folio-org/ui-checkin/pull/441/files

The version 11.0 was added to the list of possible "inventory" interface versions after finding out that the declared "item-storage" interface was wrong and was replaced by the "inventory" interface.

Comment by Steve Ellis [ 18/Aug/21 ]

One issue we may face is that we (at least I don't) have write permission on every module's repo that we may want to merge, so we should probably discuss how we want to handle that.

Comment by Julian Ladisch [ 20/Aug/21 ]

We ask the development team ( https://folio-org.atlassian.net/wiki/display/REL/Team+vs+module+responsibility+matrix ) to merge the PR to master.

Generated at Fri Feb 09 00:29:59 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.