[FOLIO-3193] DECISION: In which repository should okapi-curl live? Created: 08/Jun/21 Updated: 10/Jun/21 |
|
| Status: | Open |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Story | Priority: | TBD |
| Reporter: | Julian Ladisch | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | tech-debt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: | |
| Development Team: | None |
| Description |
|
The shell script okapi-curl currently lives in two repositories:
A third possibility is to move https://github.com/MikeTaylor/okapi-curl to https://github.com/folio-org/okapi-curl The code should be maintained at one repository only. Which repository should FOLIO use for okapi-curl? See also the conversation on https://github.com/folio-org/okapi/pull/1132 |
| Comments |
| Comment by Adam Dickmeiss [ 08/Jun/21 ] |
|
Originally okapi-curl was in okapi. But Mike Taylor and I couldn't agree on a technical detail, so we decided he could maintain it and decide what goes in there. Some may prefer curl as it is, some may prefer stripes command line or even okapi-cli. I think the best we can do is to make a list of tools out there, so people can choose to their needs. I'm using Mike's okapi-curl at the moment. It has its flaws, like you need to pass the path first (it should be allowed everywhere so it's a true curl replacement). Of course, if individuals has a client that they no longer maintain, because something else is better, we should deprecate it. okapi-curl-env is NOT the same script as okapi-curl. |
| Comment by Mike Taylor [ 08/Jun/21 ] |
|
To me, the biggest bug here is that okapi-curl-env was forked from okapi-curl. I think it should just have been done as a set of enhancements to the existing code. If tis changes get merged back into the original, I will be happy. I don't care where it lives so long as it has one single home, and if the FOLIO organization would like to take it from me I'm 100% happy with that. |
| Comment by Wayne Schneider [ 08/Jun/21 ] |
|
FWIW, okapi-curl-env was created for one reason only – to build a Docker image that I could use for the external scheduling of two timer tasks that were removed from the mod-circulation module descriptor before Okapi's enhanced timer interface was introduced. They have since been re-introduced into the module descriptor. But perhaps the utility has some use outside of that. I would be happy to take the time to unify the two utilities and allow them to live in one place. For something simple like this, I think leaving it in Mike Taylor's GitHub account is just fine, as I doubt anyone really has the time or inclination to formally maintain it as part of the FOLIO project. |
| Comment by Wayne Schneider [ 09/Jun/21 ] |
| Comment by Wayne Schneider [ 10/Jun/21 ] |
|
The PR has been accepted, and Mike Taylor's okapi-curl now supports the use case for which okapi-curl-env was created (while remaining backward compatible). I would advocate for replacing the folio-tools version with a README that contains a deprecation notice pointing anyone interested directly to Mike's repository. Then the original PR for updating the Okapi documentation can be closed without merging. Thoughts? |