|
All of the modules in folio-integration-tests repository uses hardcoded tenant/username/password for the admin user. It is a bad practice to commit password to git what was highlighted by Hongwei Ji and Anton Emelianov.
The existing Jenkins job should be adjusted so that it provides these properties either via ENV variables or as a command arguments (it is up to the DevOps team to decide, which one is easier).
Proposed names for ENV variables:
- TENANT_NAME
- ADMIN_USERNAME
- ADMIN_PASSWORD
Proposed names for arguments:
- karate.tenant.name
- karate.admin.username
- karate.admin.password
These arguments can be passed in following way (in similar way how karate.env is passed):
mvn test -Dkarate.env=<env> -Dkarate.tenant.name=<tenant> -Dkarate.admin.username=<username> -Dkarate.tenant.password=<password>
Out of scope:
- Generating password each run, it should be the same as it is now;
- Migrating the modules to use this properties.
|