[FOLIO-3153] UPSTREAM: vertx-pac4j: form parameters not read correctly - upstream Created: 10/May/21  Updated: 19/May/21  Resolved: 19/May/21

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P3
Reporter: Julian Ladisch Assignee: Adam Dickmeiss
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Relates
relates to FOLIO-3149 vertx-pac4j: form parameters not read... Closed
Sprint: CP: sprint 114
Story Points: 1
Development Team: Core: Platform

 Description   

Task:

Create a pull request against the upstream repository https://github.com/pac4j/vertx-pac4j that contains the FOLIO-3149 Closed fix.

Description:

MODLOGSAML-97 Closed reveals that vertx-pac4j 5.0.2 (FOLIO) does not read form parameters

We are maintaing:

https://github.com/folio-org/vertx-pac4j/commits/vertx-4-0-2-folio

(branch is named after Vert.x, not pac4j version, which admittedly, could be confusing)

Let's fix it here:
https://github.com/folio-org/vertx-pac4j/blob/2f3c3cbb3ce86ff080ed401e9d645881e784d62b/src/main/java/org/pac4j/vertx/VertxWebContext.java#L82

and release this. At the same time, vertx-pac4j might as well be upgraded to use 4.0.3

NOTE:

Not a high priority but resolving this will allow us to stop maintaining our fork.



 Comments   
Comment by Adam Dickmeiss [ 10/May/21 ]

vertx-pac4k is still using Vert.x 3. We have https://github.com/pac4j/vertx-pac4j/pull/161 out. Perhaps just push this fix to that branch?

Comment by Adam Dickmeiss [ 19/May/21 ]

Pushed form parameter fix to https://github.com/pac4j/vertx-pac4j/pull/161 .
Also updated to Vert.x 4.0.3.

Comment by Adam Dickmeiss [ 19/May/21 ]

Closing as this was about making a PR (not waiting it to be merged).

Generated at Thu Feb 08 23:26:01 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.