[FOLIO-3115] Include mod-service-interaction into reference environments Created: 12/Apr/21  Updated: 06/May/21  Resolved: 06/May/21

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: TBD
Reporter: Jag Goraya Assignee: Ian Hardy
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Requires
is required by UXPROD-612 Dashboard with PoC widgets from ERM Closed
Sprint: DevOps Sprint 113
Development Team: FOLIO DevOps

 Description   

To allow integration the module mod-service-interaction needs to be added into folio-snapshot/testing environments:

GitHub: https://github.com/folio-org/mod-service-interaction

 

This works the same way as mod-agreements, so configuration can be largely copied from that. 

 



 Comments   
Comment by Ian Hardy [ 19/Apr/21 ]

Looks like the build for mod-service-interaction has been failing on publishing the MD and docker image.  

+ docker tag folioci/mod-service-interaction:1.0.0-SNAPSHOT.001-SNAPSHOT.10 folioci/mod-service-interaction:latest
Error response from daemon: No such image: folioci/mod-service-interaction:1.0.0-SNAPSHOT.001-SNAPSHOT.10

Looks to me like FOLIO CI is seeing this is a build of "master" and appending -SNAPHSOT.10, but "SNAPSHOT.001" is explicitly specified in gradle.properties.

I reckon removing that would allow for the MD and image to be published following the example in mod-agreements: https://github.com/folio-org/mod-agreements/blob/master/service/gradle.properties. 

I did see there's a k-int Jenkinsfile here as well so rather than make the change straight away, I wanted to bring it up with Ethan Freestone and Ian Ibbotson (Use this one).  Let me know if that works for you.

Comment by Ian Hardy [ 26/Apr/21 ]

Hi Ethan Freestone and Ian Ibbotson (Use this one) Ran into an issue with deployment on a test build of folio-snapshot. I see the port specified in the launch descriptor is 8078: https://github.com/folio-org/mod-service-interaction/blob/1b3058b8f723e0b4ffd139c93954c4ef183be00d/service/src/main/okapi/ModuleDescriptor-template.json#L381

But, the Dockerfile in the root of the repo has EXPOSE 8080. 

Should the launchDescritptor here also be 8080? If I modify the descriptor to use 8080 also as a test, the deployment goes through.

Comment by Ian Ibbotson (Use this one) [ 26/Apr/21 ]

Oddly enough I spotted this too and asked ethan about it - I think it was done because ethan wants to run several modules locally at the same time and this was a belt-and-braces change - but I don't think this descriptor actually impacts any of our systems - local dev boxes or k8s deployments because we aren't relying upon the launch descriptor (If I've misunderstood how this works, holler please). I think you are free to change it as you see fit.

Comment by Ian Hardy [ 29/Apr/21 ]

Ethan's pointed out that mod-service-interaction is not loading its reference data. When it gets enabled it will have both loadSample and loadReference set to true. In the module log I see the following error:

2021-04-28 14:27:20.775 ERROR --- [pool-1-thread-3] com.k_int.okapi.DataloadingService       
: Error executing tenant init script.java.io.FileNotFoundException: /./src/main/okapi/tenant/sample_data/widgetTypes 

This looks like it could be a bad path "/./" looks fishy to me.

Generated at Thu Feb 08 23:25:43 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.