Create, close, cancel, Purchase Orders (UXPROD-1141)

[FOLIO-3093] Can not save POL with product ID Created: 19/Mar/21  Updated: 29/Mar/21  Resolved: 29/Mar/21

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None
Parent: Create, close, cancel, Purchase Orders

Type: Bug Priority: P1
Reporter: Dennis Bridges Assignee: Dennis Bridges
Resolution: Done Votes: 0
Labels: acq-dev-grooming
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File Screen Shot 2021-03-19 at 9.19.04 AM.png     PNG File result_locking-form.png    
Issue links:
Defines
defines UXPROD-2169 Thunderjet - R1 2021 Enhancements/Bug... Closed
Sprint: ACQ Sprint 110
Story Points: 2
Development Team: Thunderjet
Release: R1 2021 Bug Fix
Tester Assignee: Dennis Bridges
Epic Link: Create, close, cancel, Purchase Orders

 Description   

Overview: Can not save a POL in testing or snapshot with a product ID. Unclear what is happening but it seems nothing happens when clicking Save & close. This has also been observed when editing POL.

Steps to Reproduce:

  1. Log into some FOLIO environment as User X
  2. Click orders app
  3. Create ongoing subscription order
  4. click Add POL
  5. Add title
  6. add product id
  7. add cost details
  8. add location
  9. click save and close

Expected Results: POL is saved successfully

Actual Results: Nothing happens when clicking save and close

Additional Information:
URL:
Interested parties:



 Comments   
Comment by Aliaksei Chumakou [ 23/Mar/21 ]

It's hard for me to make a proper fix for final-form, so I only filed an github issue for them https://github.com/final-form/final-form/issues/408.

Since fixing it might take time, I would suggest to lock this lib version to the previous patch release (v4.20.1) and make a PR with it to platform-compete repo. After a proper fix we can remove the lock.

Comment by Aliaksei Chumakou [ 24/Mar/21 ]

Dennis Bridges we can go to the IRIS release with the locked version, it's now at the hosted env (snapshot branch of platform-complete). If it's OK there, we'll need to include the same to the release branch of platform-complete as well. 

Please check this ticket on testing/snapshot.

Also, it might be a case for previous release, if it will be building after that final-form patch released - because dependency system fetches the latest version. So it might require similar change to the previous release

Comment by Aliaksei Chumakou [ 24/Mar/21 ]

Comment by Aliaksei Chumakou [ 24/Mar/21 ]

After clarification from Anton Emelianov it looks like if issue is not reproducible on the bugfest-honeysuckle then it will be the same in production. I don't think we need any changes for honeysuckle then.

Comment by Victoria_Smelova [ 26/Mar/21 ]

Moved to FOLIO project as it involves commit to platform-complete (not into ui-orders).

Comment by Aliaksei Chumakou [ 26/Mar/21 ]

Dennis Bridges John M. gracefully added corresponding resolution to the q3-2020 of platfrom-complete, as well as to R1-2021 branch
Basically this means that if FSE team uses q3-2020 branch of platform-complete for customers releases, they could rebuild and deploy FOLIO platform without the issue

Comment by Dennis Bridges [ 26/Mar/21 ]

That is excellent Aliaksei Chumakou, I assume the q3-2020 branch includes all hotfixes as well, correct?

Comment by Aliaksei Chumakou [ 26/Mar/21 ]

Dennis Bridges that's something I'm not sure in. I think it's better to ask FSE team, from which branch they deploy FOLIO Honeysuckle, Hanna Hulevich might know the right person

Comment by Hongwei Ji [ 26/Mar/21 ]

We (FSE) use our internal GitHub repo to track which version of modules to deploy. We can update our package.json to include the resolution and then redeploy for our customers as needed. Cc Carole Godfrey since she created a PR for our internal repo branch this morning.

Comment by Dennis Bridges [ 29/Mar/21 ]

Test successful in bugfest-iris.

Generated at Thu Feb 08 23:25:33 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.